From: Sergei Trofimovich <slyich@gmail.com>
To: gcc-patches@gcc.gnu.org
Cc: David Malcolm <dmalcolm@redhat.com>,
Sergei Trofimovich <slyich@gmail.com>,
Sergei Trofimovich <siarheit@google.com>
Subject: [PATCH] diagnostics: fix gcc-urlifier.cc bootstrap failure [PR112379]
Date: Sat, 4 Nov 2023 16:23:18 +0000 [thread overview]
Message-ID: <20231104162318.4142088-1-slyich@gmail.com> (raw)
From: Sergei Trofimovich <siarheit@google.com>
Without the change `./configure --enable-checking=release` bootstrap
fails as:
gcc/gcc-urlifier.cc:100:1: error: 'get_url_suffix_for_quoted_text()'
defined but not used [-Werror=unused-function]
This happens because the helper is used only in `ASSERT` macros which
don't always get expanded to executable code.
The fix marks helper function with `ATTRIBUTE_UNUSED`.
gcc/
PR bootstrap/112379
* gcc-urlifier.cc (get_url_suffix_for_quoted_text): Mark as
ATTRIBUTE_UNUSED.
---
gcc/gcc-urlifier.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gcc/gcc-urlifier.cc b/gcc/gcc-urlifier.cc
index 269246bc703..0dbff985313 100644
--- a/gcc/gcc-urlifier.cc
+++ b/gcc/gcc-urlifier.cc
@@ -37,7 +37,8 @@ public:
char *get_url_for_quoted_text (const char *p, size_t sz) const final override;
const char *get_url_suffix_for_quoted_text (const char *p, size_t sz) const;
- const char *get_url_suffix_for_quoted_text (const char *p) const;
+ /* We use ATTRIBUTE_UNUSED as this helper is called only from ASSERTs. */
+ const char *get_url_suffix_for_quoted_text (const char *p) const ATTRIBUTE_UNUSED;
private:
static char *
--
2.42.0
next reply other threads:[~2023-11-04 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 16:23 Sergei Trofimovich [this message]
2023-11-04 17:36 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231104162318.4142088-1-slyich@gmail.com \
--to=slyich@gmail.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=siarheit@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).