From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id ECF373858D32 for ; Sat, 4 Nov 2023 16:23:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ECF373858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ECF373858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::432 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699115005; cv=none; b=QDTKnA1X5wDlHeU0wFfed4GgvaUBfA+jbC5s+tJ5YxYbIP2vHMfsl7cUfo5s/yavL0W8irEyskldr8qp1OW7/T4pjIERQLf0WFXX+uNjYMaoZD1EdZHbnW+9Jq25eZ8HV7au6lsCzgATsFG4cUobBH/x77qGoghqBPirRPGoOro= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699115005; c=relaxed/simple; bh=POB47vWOkBlGLLFMK7V5ZAx0rKaLkgOg9II0W8YlvD8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=whxKsNxEXNQOk/jmCuoz9HjO3LVIlNTvn67u3wfXSZeIg9lRStXq0e/8zhbi6C5lb2KAtpZ1Lk+oI9PjoCdglcHmWMSSFgL35wqYWJjzNoypq65vBbzuib1tvwYdefaH+PMaecSYtiAUk1shBYi1xK+iSCgHnjgyXmIst82baPk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-32d834ec222so1539883f8f.0 for ; Sat, 04 Nov 2023 09:23:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699115002; x=1699719802; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zVh8freunJe011itgzKth1owxB9WKPyrWCKXNbCZzFY=; b=DtZUcMtoe2tuvjODgHjamQsgXoXTpiS0it8fEvbrPwNogo+bMhqeo9D8JQO6LMJkKl BR36vepLj15iJtV2cfHIc+9ZCNfYUpVww1sUn5GVPnHbDUH16CEeFos6Q+dKjhuE9Wd5 DmHn8RyW4lCtRsdN+OsI0W7JCfw+RkHoO4FWgHAnvieabqB84Wyc6PQcjuWpRXuFE5m2 JwYRWTri4r1QHk4PqRjRAQWZnv76mCPiqAmeqDdxbcrhn/GT+0WV0x47Ix4ww9Vql9iN uEqGBTbxk+XVAg9oKS4yFyfvFjCsA5A0vZNeMFwh6JO6kp0j2Ux7p3PKJuvCQbJWJGRG XhVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699115002; x=1699719802; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zVh8freunJe011itgzKth1owxB9WKPyrWCKXNbCZzFY=; b=PTmrLTqqVbO2WXbVMaNoVOsiEQg93mTIyEtMnF+Y4TRGA24S35iZ2OOuCyxKVDGmCK pmbmUhkG0F4dibt6vzMmtFjqgtn5lNF9019Lo0MdmSQXRzEtNXuqWzxPPbbYVWzFAhvB EpdU+xWR32F6/TZ1/U56w8taUB1JuQck4XpaLyzzINC0ktpjTf4drj6crB6Uk7EjJMH/ Qq9MUizIKRJroSzbJES/ZZto4MYYzmSzYiz/KjFfONdT2vuevunQcEPUCbnEI05VCuMU hC2/zZdhmZIoeu2uP4JRHS8DPOsqGgVgeapxni2H/YwoEe+1uLX+taCgVZOp38e+gzz+ wL3g== X-Gm-Message-State: AOJu0YwNcLKVPvF1d+ikCZNWU1SB+N2IwgKF+OvfPZj0QHCJgeCQhYsu d/R1k15ds5vH3uGN00ixsV5rw7+dHUY= X-Google-Smtp-Source: AGHT+IH+vXpT5SkI6BmsJhSvEtrPFgS+D7QNIGOTd+YQ6egRpWOsDfBOSYw1bQHmweTyjncMDwLcsQ== X-Received: by 2002:a5d:4e03:0:b0:32d:83b7:bdb3 with SMTP id p3-20020a5d4e03000000b0032d83b7bdb3mr15331770wrt.70.1699115002014; Sat, 04 Nov 2023 09:23:22 -0700 (PDT) Received: from nz.home ([2a00:23c8:a613:101:729c:d1ff:fe4f:94a3]) by smtp.gmail.com with ESMTPSA id r8-20020adfce88000000b003233b554e6esm3141534wrn.85.2023.11.04.09.23.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Nov 2023 09:23:21 -0700 (PDT) Received: by nz.home (Postfix, from userid 1000) id 2E327127329968; Sat, 4 Nov 2023 16:23:21 +0000 (GMT) From: Sergei Trofimovich To: gcc-patches@gcc.gnu.org Cc: David Malcolm , Sergei Trofimovich , Sergei Trofimovich Subject: [PATCH] diagnostics: fix gcc-urlifier.cc bootstrap failure [PR112379] Date: Sat, 4 Nov 2023 16:23:18 +0000 Message-ID: <20231104162318.4142088-1-slyich@gmail.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Sergei Trofimovich Without the change `./configure --enable-checking=release` bootstrap fails as: gcc/gcc-urlifier.cc:100:1: error: 'get_url_suffix_for_quoted_text()' defined but not used [-Werror=unused-function] This happens because the helper is used only in `ASSERT` macros which don't always get expanded to executable code. The fix marks helper function with `ATTRIBUTE_UNUSED`. gcc/ PR bootstrap/112379 * gcc-urlifier.cc (get_url_suffix_for_quoted_text): Mark as ATTRIBUTE_UNUSED. --- gcc/gcc-urlifier.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/gcc-urlifier.cc b/gcc/gcc-urlifier.cc index 269246bc703..0dbff985313 100644 --- a/gcc/gcc-urlifier.cc +++ b/gcc/gcc-urlifier.cc @@ -37,7 +37,8 @@ public: char *get_url_for_quoted_text (const char *p, size_t sz) const final override; const char *get_url_suffix_for_quoted_text (const char *p, size_t sz) const; - const char *get_url_suffix_for_quoted_text (const char *p) const; + /* We use ATTRIBUTE_UNUSED as this helper is called only from ASSERTs. */ + const char *get_url_suffix_for_quoted_text (const char *p) const ATTRIBUTE_UNUSED; private: static char * -- 2.42.0