From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 1C1D93858D28 for ; Mon, 6 Nov 2023 08:56:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C1D93858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1C1D93858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:67c:2178:6::1c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699260961; cv=none; b=age/Gb5AbBZSZ9gBZE9cVxOT6Upr6XalL9WpkVaZ1cQ1g5Z3ZWP2RnfGth418xV2eHAL042N4yZnLrmqzA7ot6KYqG56zIqZ/9ahCMSqViZIT1Fu/1iS/T2Ov74SjLOb4u6C5gptz9bgUaxvWtk9YuOdafS1EO5nCdsTRzv9Cxk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699260961; c=relaxed/simple; bh=dF4A8JO5w6O/Pk/l9pGQwLm/WdLeyr5BqClnPrkE5U0=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:MIME-Version; b=fXCQITwgW1VKH7MzJ49x2wBOsEMdH1Hguq94mNEGSN9uxFAKtVBbb17CRISdsaVn+o6s9rdGYyV1/S7/3bc5XK35n7qV19nHP0JVths02yCAGKQzkgV2rwT50NbZnTsFE1Vobmy8NxvvwN+HmNrtlSDE9mxKu3hamNvDvParPyM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 077C42184E for ; Mon, 6 Nov 2023 08:55:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1699260959; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=DigCcXrNOa12o5gWb2BVkpgb9WHoyeB7nIyGpi8LivU=; b=b8DZlwREDqdDlrr4+j2+Efp3qZhdpmvz4ryXP3MoQo20PTtg7+Ph1on850X/rK+GzKWZ9S HzAEZWP5hMlMVUueGAR5Z9Xro1zyS2QAG30vumN/wplbYS69D2nkGHh0STslxLju7Zxxcq DOxz6Nm1kHlaMmoFoSNIUSGRRgpchF4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1699260959; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=DigCcXrNOa12o5gWb2BVkpgb9WHoyeB7nIyGpi8LivU=; b=w1KCPqXpit6hpGfku5X0Ur/CzKRc/vYgRgTDNaGtksqkhDgH9tCRODCbrHu7XBxFeycyDd QqVbGRzUq1adYXCw== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id C38EC2C864 for ; Mon, 6 Nov 2023 08:55:58 +0000 (UTC) Date: Mon, 6 Nov 2023 08:55:58 +0000 (UTC) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/112369 - strip_float_extensions and vectors User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,MISSING_MID,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20231106085558.okBuJePejpJGyf4M2gN-7F6Rxx8m0ao10eThxrgYmeY@z> The following fixes an error in strip_float_extensions when facing vector conversions. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/112369 * tree.cc (strip_float_extensions): Use element_precision. * gcc.dg/pr112369.c: New testcase. --- gcc/testsuite/gcc.dg/pr112369.c | 23 +++++++++++++++++++++++ gcc/tree.cc | 2 +- 2 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/pr112369.c diff --git a/gcc/testsuite/gcc.dg/pr112369.c b/gcc/testsuite/gcc.dg/pr112369.c new file mode 100644 index 00000000000..677e3543f54 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr112369.c @@ -0,0 +1,23 @@ +/* { dg-do compile } */ +/* { dg-options "-O3" } */ +/* { dg-additional-options "-mavx2" { target avx2 } } */ + +struct GdkRGBA2 { + double a[4]; +}; +struct GdkRGBA3 { + float a[4]; +}; +struct GdkRGBA3 f(struct GdkRGBA2 *color) { + struct GdkRGBA3 t1; + for(int i = 0; i < 4; i++) + t1.a[i] = color->a[i]; + struct GdkRGBA3 t2; + for(int i = 0; i < 4; i++) + { + float tmp = t1.a[i]; + if (__builtin_isnan(tmp)) + t2.a[i] = tmp; + } + return t2; +} diff --git a/gcc/tree.cc b/gcc/tree.cc index cfead156ddf..9c9b057cd88 100644 --- a/gcc/tree.cc +++ b/gcc/tree.cc @@ -12138,7 +12138,7 @@ strip_float_extensions (tree exp) if (DECIMAL_FLOAT_TYPE_P (expt) != DECIMAL_FLOAT_TYPE_P (subt)) return exp; - if (TYPE_PRECISION (subt) > TYPE_PRECISION (expt)) + if (element_precision (subt) > element_precision (expt)) return exp; return strip_float_extensions (sub); -- 2.35.3