public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@axis.com>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v2 1/7] aarch64: Use br instead of ret for eh_return
Date: Mon, 13 Nov 2023 01:27:38 +0100	[thread overview]
Message-ID: <20231113002738.ABC2520432@pchp3.se.axis.com> (raw)
In-Reply-To: <3e94445d1e342a47a9676c33376564e112fbc8af.1699025214.git.szabolcs.nagy@arm.com> (message from Szabolcs Nagy on Fri, 3 Nov 2023 15:36:08 +0000)

> From: Szabolcs Nagy <szabolcs.nagy@arm.com>
> Date: Fri, 3 Nov 2023 15:36:08 +0000

I don't see others commenting on this patch, and you're not
mentioning this aspect, so I wonder:

> 	* config/aarch64/aarch64.h (EH_RETURN_TAKEN_RTX): Define.
> 	(EH_RETURN_STACKADJ_RTX): Change to R5.
> 	(EH_RETURN_HANDLER_RTX): Change to R6.

Isn't this an ABI change?

(I've forgotten relevant bits of the exception machinery; if
throw and catch are always in the same object and everything
in between register-number-agnostic then the only flaw would
be not mentioning that in the commit message.)

brgds, H-P

  reply	other threads:[~2023-11-13  0:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-03 15:36 [PATCH v2 0/7] aarch64 GCS preliminary patches Szabolcs Nagy
2023-11-03 15:36 ` [PATCH v2 1/7] aarch64: Use br instead of ret for eh_return Szabolcs Nagy
2023-11-13  0:27   ` Hans-Peter Nilsson [this message]
2023-11-13 11:18     ` Szabolcs Nagy
2023-11-26 12:11   ` Richard Sandiford
2023-11-03 15:36 ` [PATCH v2 2/7] aarch64: Do not force a stack frame for EH returns Szabolcs Nagy
2023-11-26 12:12   ` Richard Sandiford
2023-11-03 15:36 ` [PATCH v2 3/7] aarch64: Add eh_return compile tests Szabolcs Nagy
2023-11-26 14:37   ` Richard Sandiford
2023-11-27 10:04     ` Szabolcs Nagy
2023-11-27 15:57     ` Szabolcs Nagy
2023-12-02 19:23   ` Andrew Pinski
2023-11-03 15:36 ` [PATCH v2 4/7] aarch64: Disable branch-protection for pcs tests Szabolcs Nagy
2023-11-03 15:36 ` [PATCH v2 5/7] aarch64,arm: Remove accepted_branch_protection_string Szabolcs Nagy
2023-11-26 14:50   ` Richard Sandiford
2023-11-03 15:36 ` [PATCH v2 6/7] aarch64,arm: Fix branch-protection= parsing Szabolcs Nagy
2023-12-07 13:02   ` Richard Earnshaw
2023-11-03 15:36 ` [PATCH v2 7/7] aarch64,arm: Move branch-protection data to targets Szabolcs Nagy
2023-12-07 13:13   ` Richard Earnshaw
2024-01-11 14:43     ` Szabolcs Nagy
2024-01-11 14:49       ` Richard Earnshaw (lists)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231113002738.ABC2520432@pchp3.se.axis.com \
    --to=hp@axis.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=szabolcs.nagy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).