From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2085.outbound.protection.outlook.com [40.107.104.85]) by sourceware.org (Postfix) with ESMTPS id 130AC3858D28 for ; Mon, 13 Nov 2023 00:27:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 130AC3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 130AC3858D28 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.104.85 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699835263; cv=pass; b=jor0pR8p44jsfOaZFmkN26XNRgk46ousjQu/MGL9IC37rLXMRvX58SMa7P/7JlX57cZDgha/IJ4taEVHblwtCkkkFbLJPibA/Z+QnDLhzFj5npqg3AnCd7dt/b5+Y3hDYhxFDzrjKrIko9AxWAKLexDqnwU55rxjqAvPH7/K8oY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699835263; c=relaxed/simple; bh=ojeD/l7KHrh7D/5HTS7jK8dXMrQJAcT3HfvEK8aEvos=; h=DKIM-Signature:From:To:Subject:MIME-Version:Message-ID:Date; b=LplSxzx5ljwluxlRCEkzt2YgUYR48GW/gohimOtS/bb2hC598151i55YWWjK9ofnbrVh7VoKOipfwKDkQUrea7kegAzyETQN+JUBB7O99byCJpAUIaTjhgx/mTlEC0Xl70jGd4yAFL7fgj+wnIKP+f2NF1NhsnVhgJ1+FjNwbC4= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mv3jwUSo3G1K8SOVEqRgFADvo88tZF3Zp0J8Xozg8z1cHM0xTorKGLUoyYFgX2uSTNwWEpyebDKtlAujFGKbeu+cZgxeflbqyCvfVfsE/o156Qf0Tsl3v/nNktZz0r2wAfirdGPI3ZGN/lmDckRwGXFMd8ud3/oD8MeSk1GysuKnUyIEA1if+dvHahimCzn5N4Y5P1jKaTR3II6rMNe2SQHpBwVB9Gla5zLXk7UpAiU2WAjYYYq+TQwTYC3D7TH7/lICF2P0w84wFPxEVBjnFefQOlEG3q+Kqx+FhHeKaOmXhXX7aqkSIUB7A3u5wz3jIEuQAQzAVqFKarr28ptPpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L6DZgO9T28jbLqjcWj7/JZGQjgbvrvGF8MOaLSgyGBM=; b=bHIJCAiNAalO8Kbphjy/t2HtfOUzGa6BjfahchqrMwv90UErYevrgqX0ZWtFJoA+UeFAGYErnDKP8moFY5A0/bdICyim4qHfbMUyVKCLzCDpiorsrph02whsNTk52buii6Rgz7U4FQT6i9GPsatRA7bDtKgvIa9de5itqXw6p4xiGdf8NJAZ+QpwE+HCw1PYBcu73eBq9lMvO3dQ44i1UAG4HW0E0xjuvKl+Ll2x8VRU8jiwWZBRn5o8QvIKyAuJZ+xeiMm8DGCbpcPDIKB9i0i6mUUt/mgwBbWFqPBvFPFzJ7i1CeV1mpZ6+/ca407CNj7mGJDcGGwRurJ0DEIIIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 195.60.68.100) smtp.rcpttodomain=arm.com smtp.mailfrom=axis.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=axis.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L6DZgO9T28jbLqjcWj7/JZGQjgbvrvGF8MOaLSgyGBM=; b=PzfDfFMglCbkQ3rlzP1pXVVW27cGauK8fv6rctbc2QEMNjlcRg/xN29vcHLWTOVySLDCnqS/IqWkP1Hp1EE1dgOJqUROwg+Q2tIbKxkCa0pakcr+fZ4oBRVmF5ZN9HyRMKmSYjvgkXODBHtTnjFJyiP7U4IX9r5a8a+Gp9eQp5Y= Received: from AS9PR04CA0164.eurprd04.prod.outlook.com (2603:10a6:20b:530::16) by PAXPR02MB7815.eurprd02.prod.outlook.com (2603:10a6:102:229::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.29; Mon, 13 Nov 2023 00:27:39 +0000 Received: from AM4PEPF00027A68.eurprd04.prod.outlook.com (2603:10a6:20b:530:cafe::4f) by AS9PR04CA0164.outlook.office365.com (2603:10a6:20b:530::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.29 via Frontend Transport; Mon, 13 Nov 2023 00:27:39 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 195.60.68.100) smtp.mailfrom=axis.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=axis.com; Received-SPF: Fail (protection.outlook.com: domain of axis.com does not designate 195.60.68.100 as permitted sender) receiver=protection.outlook.com; client-ip=195.60.68.100; helo=mail.axis.com; Received: from mail.axis.com (195.60.68.100) by AM4PEPF00027A68.mail.protection.outlook.com (10.167.16.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7002.13 via Frontend Transport; Mon, 13 Nov 2023 00:27:39 +0000 Received: from SE-MAILARCH01W.axis.com (10.20.40.15) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 13 Nov 2023 01:27:38 +0100 Received: from se-mail01w.axis.com (10.20.40.7) by SE-MAILARCH01W.axis.com (10.20.40.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 13 Nov 2023 01:27:38 +0100 Received: from se-intmail01x.se.axis.com (10.0.5.60) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 13 Nov 2023 01:27:38 +0100 Received: from pchp3.se.axis.com (pchp3.se.axis.com [10.88.21.53]) by se-intmail01x.se.axis.com (Postfix) with ESMTP id AEF125EDE; Mon, 13 Nov 2023 01:27:38 +0100 (CET) Received: by pchp3.se.axis.com (Postfix, from userid 171) id ABC2520432; Mon, 13 Nov 2023 01:27:38 +0100 (CET) From: Hans-Peter Nilsson To: Szabolcs Nagy CC: In-Reply-To: <3e94445d1e342a47a9676c33376564e112fbc8af.1699025214.git.szabolcs.nagy@arm.com> (message from Szabolcs Nagy on Fri, 3 Nov 2023 15:36:08 +0000) Subject: Re: [PATCH v2 1/7] aarch64: Use br instead of ret for eh_return MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <3e94445d1e342a47a9676c33376564e112fbc8af.1699025214.git.szabolcs.nagy@arm.com> Message-ID: <20231113002738.ABC2520432@pchp3.se.axis.com> Date: Mon, 13 Nov 2023 01:27:38 +0100 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM4PEPF00027A68:EE_|PAXPR02MB7815:EE_ X-MS-Office365-Filtering-Correlation-Id: 12b1824b-9308-465f-eaaf-08dbe3df57c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8xlVxO/BE5JjC9LgrvzDaoMSlvg1k7b31yBYy3BLhw17diagW4gGKSpgnDmlO8c8YSQrbKozjx9TcvZnwG1ItJV6YAL1kgo13oQs4BxS52xE2Z+7f+1nR/PfCMs820JZU7h/sbLn/gBHb6itBOeLqiiq2DCkqW6Yetiyi0pTlw+WYK0sGxd/HR72YduAQjyQ4bCq/Us4njU78glTWpf9fg0AOvsq8dgkMCnQM2Ep7TmO7MI1p+AZByxfggrfbl0LZc9AXED2sAfwjy/R8lHQQdkxLMZMpMdphK4oyjWDplbXgHERrF4ebzzIauhL5BjkaqLm0KAv8jMySA2rrg3R40KFK6p4kVvnPW4YLRHLleTmatTF22+clD/mmRDffo35Ge1n10puRMldRcm+XD8POx0OSHWHBVLBDex6em7GN0R7dtXDNzd4d2n9myvNC9OC1Eo22XKtCugy5KbZ+lWmgv+u/qqfFYNVlPb43NFHaX3A6XK/YClYOl1iwc07/psGM5c4kATWeUkeftOOd4b9xQNKUhmdaerxD4WXjXPIn/GMosXt8wPV307Hd9c6HeflWDoqwo0FUXFNU5FOkTGyD9s8iucRqgBA9z3oG3ELj/V6FZVuMixdmHKTVPohx4pUwF5XOOTDFNAi+kQJcHoaVZRWQFxj5SIcbMH/GBuBVOVJTN8zzOVFoldBkOrwmTLU3dx75wPCIiV14I/4llgxBKaQaMcMON5bscwAkZV8qQ5eJK+5NQ5CbuSUl581DlmTeNtL2PY3pGA8dLBWcP7haA== X-Forefront-Antispam-Report: CIP:195.60.68.100;CTRY:SE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.axis.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(376002)(346002)(39850400004)(136003)(396003)(230922051799003)(451199024)(186009)(1800799009)(64100799003)(82310400011)(36840700001)(40470700004)(46966006)(36860700001)(2906002)(1076003)(4744005)(40460700003)(5660300002)(41300700001)(47076005)(6266002)(33656002)(426003)(336012)(26005)(82740400003)(42186006)(70206006)(70586007)(6916009)(316002)(83380400001)(81166007)(478600001)(356005)(8676002)(4326008)(40480700001)(8936002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: axis.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2023 00:27:39.2807 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 12b1824b-9308-465f-eaaf-08dbe3df57c9 X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=78703d3c-b907-432f-b066-88f7af9ca3af;Ip=[195.60.68.100];Helo=[mail.axis.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00027A68.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR02MB7815 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Szabolcs Nagy > Date: Fri, 3 Nov 2023 15:36:08 +0000 I don't see others commenting on this patch, and you're not mentioning this aspect, so I wonder: > * config/aarch64/aarch64.h (EH_RETURN_TAKEN_RTX): Define. > (EH_RETURN_STACKADJ_RTX): Change to R5. > (EH_RETURN_HANDLER_RTX): Change to R6. Isn't this an ABI change? (I've forgotten relevant bits of the exception machinery; if throw and catch are always in the same object and everything in between register-number-agnostic then the only flaw would be not mentioning that in the commit message.) brgds, H-P