From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id B25A4392C297 for ; Mon, 13 Nov 2023 14:27:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B25A4392C297 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B25A4392C297 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699885649; cv=none; b=EimOZtNE4vgBQNAZW6NSzEcpB7dPhRWcudY7TkCu90kB+8C0mAtxn/35jsbUwHjhqkcc69VroN6kDX4kIigFtBJFsGDcz1CYmu7tmxiiomuKxlRRAo1hoA19gdvqM8/xfvv7ju1fHsJcJmJ668tEcTk3+FS9eCazWL9Ir8JOvyg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699885649; c=relaxed/simple; bh=6eqMfh1q//F97xmMprHvrP8HS+GCxPWM9tnU+uoliFE=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=HxHIxzxcFg5qsYquHHhKMCSTJizbTtSUwaHw8coA5bUvUur0ddOjBv/oPNInmvUBgPu0otd205bCoSMgdSAfzCHzWO9r6IVWt3fhi5vRAcxFRWESu/hD2Tp5BttQwU5DTLgTvNOKEzGMH8+pYDIanLrkTkdKFjEoKS/rS3X4iF4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 00E5C1007; Mon, 13 Nov 2023 06:28:14 -0800 (PST) Received: from e126323.arm.com (unknown [10.57.41.187]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1280D3F7B4; Mon, 13 Nov 2023 06:27:27 -0800 (PST) From: Richard Earnshaw To: gcc-patches@gcc.gnu.org Cc: Richard Earnshaw Subject: [committed 07/22] arm: testsuite: tidy up pre-run check for g2.c Date: Mon, 13 Nov 2023 14:26:43 +0000 Message-Id: <20231113142658.69039-8-rearnsha@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231113142658.69039-1-rearnsha@arm.com> References: <20231113142658.69039-1-rearnsha@arm.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------2.34.1" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------2.34.1 Content-Type: text/plain; charset=UTF-8; format=fixed Content-Transfer-Encoding: 8bit gcc.target/arm/g2.c is an xscale-only test, but the test is quite old and we have improved the infrastructure for setting up such tests now. So make use of that to reduce the number of cases where this test fails to run. gcc/testsuite: * lib/target-supports.exp (check_effective_target_arm_arch_FUNC_ok): Add entry to check for xscale. * gcc.target/arm/g2.c: Use it. --- gcc/testsuite/gcc.target/arm/g2.c | 10 ++++------ gcc/testsuite/lib/target-supports.exp | 1 + 2 files changed, 5 insertions(+), 6 deletions(-) --------------2.34.1 Content-Type: text/x-patch; name="0007-arm-testsuite-tidy-up-pre-run-check-for-g2.c.patch" Content-Transfer-Encoding: 8bit Content-Disposition: attachment; filename="0007-arm-testsuite-tidy-up-pre-run-check-for-g2.c.patch" diff --git a/gcc/testsuite/gcc.target/arm/g2.c b/gcc/testsuite/gcc.target/arm/g2.c index ca5e3ccff66..04334c97713 100644 --- a/gcc/testsuite/gcc.target/arm/g2.c +++ b/gcc/testsuite/gcc.target/arm/g2.c @@ -1,11 +1,9 @@ /* Verify that hardware multiply is preferred on XScale. */ /* { dg-do compile } */ -/* { dg-options "-mcpu=xscale -O2 -marm" } */ -/* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-march=*" } { "-march=xscale" } } */ -/* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-mcpu=*" } { "-mcpu=xscale" } } */ -/* { dg-skip-if "Test is specific to ARM mode" { arm*-*-* } { "-mthumb" } { "" } } */ -/* { dg-require-effective-target arm_arch_v5te_arm_ok } */ -/* { dg-require-effective-target arm32 } */ +/* { dg-options "-O2" } */ +/* { dg-require-effective-target arm_arch_xscale_arm_ok } */ +/* { dg-add-options arm_arch_xscale_arm } */ + /* Brett Gaines' test case. */ unsigned BCPL(unsigned) __attribute__ ((naked)); diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index 7d83bd8740f..9d2958626ad 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -5411,6 +5411,7 @@ foreach { armfunc armflag armdefs } { v5te "-march=armv5te+fp -mfloat-abi=softfp" __ARM_ARCH_5TE__ v5te_arm "-march=armv5te+fp -marm" __ARM_ARCH_5TE__ v5te_thumb "-march=armv5te+fp -mthumb -mfloat-abi=softfp" __ARM_ARCH_5TE__ + xscale_arm "-mcpu=xscale -mfloat-abi=soft -marm" __XSCALE__ v6 "-march=armv6+fp -mfloat-abi=softfp" __ARM_ARCH_6__ v6_arm "-march=armv6+fp -marm" __ARM_ARCH_6__ v6_thumb "-march=armv6+fp -mthumb -mfloat-abi=softfp" __ARM_ARCH_6__ --------------2.34.1--