From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id D00C53858286; Wed, 15 Nov 2023 17:42:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D00C53858286 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D00C53858286 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::629 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700070169; cv=none; b=FFCgPM2IL0SeXezjOFW2xTCXAVTW49hrRE2y6vKUQXhXNh7eb8nV2xlNtFfaOrZ/M7j7PScKn8aFOLCp70QXoXz8SedKICKYy6SbXwHE32gKPwpkHdnZHNCD0OtJklR7qctTR1EuBP69IHFnpjCsGoMtRweiEhD1GlN+Ys/LVpc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700070169; c=relaxed/simple; bh=L04VyM2MHrrDFCEHOCu1v028H2ugLJ01ebRLlI17FZc=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=QdVlAIPp/5Ps9tShJlPGDmEw1Jl3tMhYD6Fe6ZrPsPUZ9Cba58OLUB8ChQylsr35Dnjx/eGjQfHmGufhyAkpVJ8zXBd5CQL8L9s1iyu8tttHyiQWEjFXUAo2kcIQmBoNaXpQ46ir8QpaokFnVl6Ek0BR3BDi8FZ/jdVUn6HucKM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9f26ee4a6e5so163658966b.2; Wed, 15 Nov 2023 09:42:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700070166; x=1700674966; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=mgBosq0z+WUCTE//VYTjHKHvex+jrLO241u4RvRdVqc=; b=MIOQdTgZXirG7ToDRaPDKLITpQJaSL50R8x8yP1CZsPjysP1Prz3ChDn3A0vr+Mjab 2qYXfY1pQjfl1bvkjX02N5KLlzJgGi8y43iJDOwG79MZ2Kf3YDcwD1R624aPYu6h5hD4 yuyLALrJZOHa1xf2EUzImBB8cLi/8S9EF6uERk73A9Dy6lAMjFueKtpF/xkeoLbdskVN NPOiASiaBTa/hTR6W5A+aACr0YuEeBm+jyQpbAGs3PSzsHz52odbdBLLzmTlqn9YuJrU XTfY6bY6l52LWTGI1dPYDAtEC8goMKJv3l88JSIr2/m8isxc7V+8HQPj2lnZpX8iXUdN HoMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700070166; x=1700674966; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mgBosq0z+WUCTE//VYTjHKHvex+jrLO241u4RvRdVqc=; b=w2FZxXkyfAP2XTf75wjtBEHodlgjJniyKKcqyPSga9aY2NtlplPuWsYiQm49LIBgbv n6Ls1mZpd6apDXVT87Elt20DXVBhrjz/435INun+V9C8s8Wev6uxtXStq4P2/zu+jm5a 9YaJkZWyAt/pToMZFMLZO53nINNo+5NB841/DiWTAHLf1K773Ov2xyv2Yh7VR7e0tmvL ZZ4sXJS0/nGT+eE6XPZ+KGT6Is2FQ3tfhj9txA6GIk86q9qJZyRyMF/jHCIzA32MIvwq 8Q6RGaaZuYBIQikNh1zb5YPSWblwviSXg8kLfZiKkxEXiJMbavNZm+OEVh+xLSK1To5W dIQg== X-Gm-Message-State: AOJu0Yw1evSHw3UW3C35nawgBQ7KJIIfF6bsuqztBoZgK3G+uh2huMVV w3Nyv24yhPrRgc46tYAko/ur9uzdE7U= X-Google-Smtp-Source: AGHT+IGyTINofZUORF4ksgle3beJxIprBhMt5C3EA3FdO2x/pszyOlLzakSeBv9MtDAsmjV+vTN9JQ== X-Received: by 2002:a17:906:3049:b0:9bd:f155:eb54 with SMTP id d9-20020a170906304900b009bdf155eb54mr8232876ejd.6.1700070166056; Wed, 15 Nov 2023 09:42:46 -0800 (PST) Received: from nbbrfq.loc ([2001:62a:4:203::25]) by smtp.gmail.com with ESMTPSA id cw18-20020a170906c79200b0099bd7b26639sm7338770ejb.6.2023.11.15.09.42.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 09:42:45 -0800 (PST) Date: Wed, 15 Nov 2023 18:42:43 +0100 From: Bernhard Reutner-Fischer To: Jason Merrill Cc: rep.dot.nop@gmail.com, Patrick Palka , David Malcolm , gcc-patches@gcc.gnu.org, Bernhard Reutner-Fischer Subject: Re: [PATCH 04/14] c++: use _P() defines from tree.h Message-ID: <20231115184243.3542102e@nbbrfq.loc> In-Reply-To: <5953eb94-b877-bbaa-77bc-b08744c91c81@redhat.com> References: <20230513232321.279733-1-rep.dot.nop@gmail.com> <20230513232321.279733-5-rep.dot.nop@gmail.com> <20230601183346.71664610@nbbrfq.loc> <20230601201007.28f7ca15@nbbrfq.loc> <5953eb94-b877-bbaa-77bc-b08744c91c81@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 8 Aug 2023 16:31:39 -0400 Jason Merrill wrote: > On 8/2/23 12:51, Patrick Palka via Gcc-patches wrote: > > On Thu, Jun 1, 2023 at 2:11=E2=80=AFPM Bernhard Reutner-Fischer > > wrote: =20 > >> > >> Hi David, Patrick, > >> > >> On Thu, 1 Jun 2023 18:33:46 +0200 > >> Bernhard Reutner-Fischer wrote: > >> =20 > >>> On Thu, 1 Jun 2023 11:24:06 -0400 > >>> Patrick Palka wrote: > >>> =20 > >>>> On Sat, May 13, 2023 at 7:26=E2=80=AFPM Bernhard Reutner-Fischer via > >>>> Gcc-patches wrote: =20 > >>> =20 > >>>>> diff --git a/gcc/cp/tree.cc b/gcc/cp/tree.cc > >>>>> index 131b212ff73..19dfb3ed782 100644 > >>>>> --- a/gcc/cp/tree.cc > >>>>> +++ b/gcc/cp/tree.cc > >>>>> @@ -1173,7 +1173,7 @@ build_cplus_array_type (tree elt_type, tree i= ndex_type, int dependent) > >>>>> } > >>>>> > >>>>> /* Avoid spurious warnings with VLAs (c++/54583). */ > >>>>> - if (TYPE_SIZE (t) && EXPR_P (TYPE_SIZE (t))) > >>>>> + if (CAN_HAVE_LOCATION_P (TYPE_SIZE (t))) =20 > >>>> > >>>> Hmm, this change seems undesirable... =20 > >>> > >>> mhm, yes that is misleading. I'll prepare a patch to revert this. > >>> Let me have a look if there were other such CAN_HAVE_LOCATION_P chang= es > >>> that we'd want to revert. =20 > >> > >> Sorry for that! > >> I'd revert the hunk above and the one in gcc-rich-location.cc > >> (maybe_range_label_for_tree_type_mismatch::get_text), please see > >> attached. Bootstrap running, ok for trunk if it passes? =20 > >=20 > > LGTM! =20 >=20 > Yes, OK. Now applied as r14-5508 (186331063dfbcf1eacb445c473d92634c9baa90f) thanks