From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id 657F93858C60 for ; Thu, 16 Nov 2023 19:30:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 657F93858C60 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 657F93858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=116.202.254.214 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700163051; cv=none; b=M0MhCROPk4hF3zAjhT14kWmG2TjgSIImNBYN5ihz02aqpqwPN2hpepSbIMsWGmNwZg6aE7oqieXCpzglgVU8X6HbOJ21EwLy7WN2pM/dQq4Y3TTI58lt5fsZHgR8cuO5taBBf2eblVXtiKhBFqb3G/DPOO6G1AbDqSfl8gGU8LU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700163051; c=relaxed/simple; bh=+wOxrtGQvlj+0NTN5Rf66O4D/lgbPCbNyH3RM8/FqFc=; h=To:From:Subject:Date:Message-ID:Mime-Version; b=qDfBoxkK4YqU5uwKz5yPQqpDtahRzzWIcZYraNHYnayhTyJRbes1vZXBJwvcO8gz2rT7KyRt8zL3Gqh/wlfd9WwQZ+/2CMLfV8oXob34Vjg8zHKb6oKfLaYtJbdswb5lXtAuwq/Z1/Vu7M8QALK9qH/FB+VstGreooBFpCV4FBQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1r3i4b-0001SB-S2 for gcc-patches@gcc.gnu.org; Thu, 16 Nov 2023 20:30:46 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Harald Anlauf Subject: Re: [Patch] Fortran: Accept -std=f2023 support, update line-length for Fortran 2023 Date: Thu, 16 Nov 2023 20:30:32 +0100 Message-ID: <750b022e-0291-4d35-9cd1-0957023cbb4a@gmx.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla Thunderbird Content-Language: en-US In-Reply-To: Cc: fortran@gcc.gnu.org X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20231116193032.xoyUT0QNktBTzf5_2s_Mg-DUSQb1gDHAB6oigbrOCCU@z> Hi Tobias, On 11/16/23 14:01, Tobias Burnus wrote: > This adds -std=f2023, which is mostly a prep patch for future changes. > > However, Fortran 2023, https://j3-fortran.org/doc/year/23/23-007r1.pdf > changes two things which is taken > care in this patch: > > (A) In "6.3.2.1 Free form line length": > > Fortran 2018: "If a line consists entirely of characters of default kind > (7.4.4), it shall contain at most 132 characters" > Fortran 2023: "A line shall contain at most ten thousand characters." > > (B) In "6.3.2.6 Free form statements": > Fortran 2018: "A statement shall not have more than 255 continuation > lines." > Fortran 2023: "A statement shall not have more than one million > characters." this is really a funny change: we're not really prepared to handle this. According to the standard one can have 999999 lines with only "&" and then an ";", but then only 100 lines with 10000 characters. There is a similar wording for fixed-form which you overlooked: 6.3.3.5 Fixed form statements Fortran 2023: "A statement shall not have more than one million characters" Please adjust the fixed-form limits in your patch. If you think that we need testcases for fixed-form, add them, or forget them. I don't bother. > I have not added a testcase for exceeding the latter but otherwise there > are new > tests and I had to add a couple of -std=f2018 to existing tests. > > Comments, suggestions, approval? I have the following comments: - there are existing testcases continuation_5.f, continuation_6.f, thus I suggest to rename your new continuation_{5,6}.f90 to continuation_17.f90+ . - I don't understand your new testcase line_length_14.f90 . This is supposed to test -std=gnu, but then -std=gnu is not a standard but a moving target, which is why you had to adjust existing testcases. So what does it buy us beyond line_length_1{2,3}.f90 ? > Tobias > > PS: I find it funny that -std=c23, -std=c++23 and -std=f2023 will get > added in the same GCC release. :-) > PPS: I did not bother adding .f23 as file extension; I believe that also > .f18 is unsupported. I never use extensions other than .f90 for portable code. With the above fixed, I am fine with your patch. Thanks, Harald > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, > 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: > Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; > Registergericht München, HRB 106955