public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@axis.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: <libstdc++@gcc.gnu.org>, <gcc-patches@gcc.gnu.org>
Subject: Re: [committed] libstdc++: Implement std::out_ptr and std::inout_ptr for C++23 [PR111667]
Date: Fri, 17 Nov 2023 05:43:55 +0100	[thread overview]
Message-ID: <20231117044355.43F5720420@pchp3.se.axis.com> (raw)
In-Reply-To: <20231116081324.1221069-1-jwakely@redhat.com> (message from Jonathan Wakely on Thu, 16 Nov 2023 08:12:39 +0000)

> From: Jonathan Wakely <jwakely@redhat.com>
> Date: Thu, 16 Nov 2023 08:12:39 +0000

> 	PR libstdc++/111667
> 	* include/Makefile.am: Add new header.
> 	* include/Makefile.in: Regenerate.
> 	* include/bits/out_ptr.h: New file.
> 	* include/bits/shared_ptr.h (__is_shared_ptr): Move definition
> 	to here ...
> 	* include/bits/shared_ptr_atomic.h (__is_shared_ptr): ... from
> 	here.
> 	* include/bits/shared_ptr_base.h (__shared_count): Declare
> 	out_ptr_t as a friend.
> 	(_Sp_counted_deleter, __shared_ptr): Likewise.
> 	* include/bits/unique_ptr.h (unique_ptr, unique_ptr<T[], D>):
> 	Declare out_ptr_t and inout_ptr_t as friends.
> 	(__is_unique_ptr): Define new variable template.
> 	* include/bits/version.def (out_ptr): Define.
> 	* include/bits/version.h: Regenerate.
> 	* include/std/memory: Include new header.
> 	* testsuite/20_util/smartptr.adapt/inout_ptr/1.cc: New test.
> 	* testsuite/20_util/smartptr.adapt/inout_ptr/2.cc: New test.
> 	* testsuite/20_util/smartptr.adapt/inout_ptr/shared_ptr_neg.cc:
> 	New test.
> 	* testsuite/20_util/smartptr.adapt/inout_ptr/void_ptr.cc: New
> 	test.
> 	* testsuite/20_util/smartptr.adapt/out_ptr/1.cc: New test.
> 	* testsuite/20_util/smartptr.adapt/out_ptr/2.cc: New test.
> 	* testsuite/20_util/smartptr.adapt/out_ptr/shared_ptr_neg.cc:
> 	New test.
> 	* testsuite/20_util/smartptr.adapt/out_ptr/void_ptr.cc: New
> 	test.

This commit, r14-5524-gc7f6537db94f7c, exposed or caused, for several targets:
FAIL: g++.dg/modules/xtreme-header-4_b.C -std=c++2b (internal compiler error: tree check: expected class 'type', have 'declaration' (template_decl) in get_originating_module_decl, at cp/module.cc:18649)
FAIL: g++.dg/modules/xtreme-header-4_b.C -std=c++2b (test for excess errors)
FAIL: g++.dg/modules/xtreme-header-5_b.C -std=c++2b (internal compiler error: tree check: expected class 'type', have 'declaration' (template_decl) in get_originating_module_decl, at cp/module.cc:18649)
FAIL: g++.dg/modules/xtreme-header-5_b.C -std=c++2b (test for excess errors)
FAIL: g++.dg/modules/xtreme-header_b.C -std=c++2b (internal compiler error: tree check: expected class 'type', have 'declaration' (template_decl) in get_originating_module_decl, at cp/module.cc:18649)
FAIL: g++.dg/modules/xtreme-header_b.C -std=c++2b (test for excess errors)

See PR 112580.

(BTW, I can't tell from the archive, whether the
"Linaro-TCWG-CI" tester notified you or just sent its report
to the gcc-regression@ list.)

brgds, H-P

  reply	other threads:[~2023-11-17  4:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16  8:12 Jonathan Wakely
2023-11-17  4:43 ` Hans-Peter Nilsson [this message]
2023-11-17  8:15   ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231117044355.43F5720420@pchp3.se.axis.com \
    --to=hp@axis.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).