From: Arnaud Charlet <charlet@adacore.com>
To: Simon Wright <simon@pushface.org>
Cc: Arnaud Charlet <charlet@adacore.com>,
Iain Sandoe <idsandoe@googlemail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime
Date: Fri, 17 Nov 2023 13:36:10 +0000 [thread overview]
Message-ID: <20231117133610.GA2814215@adacore.com> (raw)
In-Reply-To: <640DEA70-FE25-41CD-A69B-B361DFC463D5@pushface.org>
> Apple’s naming is definitely confusing in this area!
>
> In current SDKs, TARGET_OS_MAC means code is being generated for a Mac OS X variant,
> which covers OSX, IOS, Watch … ; to determine which kind of device, you have to check the
> specific define for that device - OSX corresponds to macOS, i.e. laptops, desktops.
>
> In older SDKs (specifically Xcode 3, for macOS Leopard (darwin 9) as mentioned by Iain)
> TARGET_OS_MAC means code is being generated for "Mac OS", i.e. laptops, desktops as
> above; TARGET_OS_OSX is undefined (as are TARGET_OS_IOS etc).
>
> If we are compiling for macOS, using a current macOS SDK, then TARGET_OS_MAC is
> set to 1 and TARGET_OS_OSX is set to 1.
>
> If we were compiling for iOS, using a current iOS SDK as supplied with current Xcode, then
> TARGET_OS_MAC would be set to 1, TARGET_OS_OSX would be set to 0, and
> TARGET_OS_IOS would be set to 1.
OK so then the following is sufficient for our needs:
#elif defined (__APPLE__)
/* By default, macOS volumes are case-insensitive, iOS
volumes are case-sensitive. */
#if TARGET_OS_IOS
file_names_case_sensitive_cache = 1;
#else
file_names_case_sensitive_cache = 0;
#endif
#else /* Neither Windows nor Apple. */
file_names_case_sensitive_cache = 1;
#endif
We want the default to be 0, and we only care about setting it to 1 on iOS for recent
SDKs, the case of an old SDK and iOS isn't interesting at this stage, so it's fine if we set
the var to 0 in this scenario.
Arno
next prev parent reply other threads:[~2023-11-17 13:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 11:51 Simon Wright
2023-10-31 8:07 ` Iain Sandoe
2023-11-03 8:39 ` Arnaud Charlet
2023-11-04 17:02 ` Simon Wright
2023-11-04 23:28 ` Iain Sandoe
2023-11-06 8:36 ` Arnaud Charlet
2023-11-11 17:47 ` Simon Wright
2023-11-11 18:10 ` Iain Sandoe
2023-11-13 16:03 ` Simon Wright
2023-11-13 16:18 ` Arnaud Charlet
2023-11-16 20:56 ` Simon Wright
2023-11-17 8:37 ` Arnaud Charlet
2023-11-17 9:06 ` Simon Wright
2023-11-17 9:29 ` Arnaud Charlet
2023-11-17 12:53 ` Simon Wright
2023-11-17 13:36 ` Arnaud Charlet [this message]
2023-11-17 13:39 ` Arnaud Charlet
2023-11-17 13:43 ` Simon Wright
2023-11-21 11:22 ` Iain Sandoe
2023-11-21 20:25 ` Simon Wright
2023-11-21 23:13 ` Iain Sandoe
2023-11-22 13:54 ` Simon Wright
2023-11-22 13:55 ` Arnaud Charlet
2023-11-22 14:48 ` Iain Sandoe
2023-11-22 15:03 ` Iain Sandoe
2023-11-22 15:13 ` Simon Wright
2023-11-28 12:16 ` Simon Wright
2023-11-28 13:50 ` Marc Poulhiès
2023-11-28 16:48 ` Marc Poulhiès
2023-11-22 14:41 ` Paul Koning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231117133610.GA2814215@adacore.com \
--to=charlet@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=idsandoe@googlemail.com \
--cc=simon@pushface.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).