From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2065.outbound.protection.outlook.com [40.107.241.65]) by sourceware.org (Postfix) with ESMTPS id ED2073858C54; Mon, 20 Nov 2023 02:13:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED2073858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ED2073858C54 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.241.65 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700446383; cv=pass; b=Wn8qfxecdLX+7RELEPbc27Ut+l26weFxJGrpfml1p7bBCogp8P2r0vMlseTClBqE6ZKcue9llCNM7MO3ZppplFCAVzpHZHrU8fgIXJdUxdsACeueAyoWLJC/zQORlJ96Eb4ZPQGM8ZCNQjDZTpXREmkwswKM/zadXIhkShyXXts= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700446383; c=relaxed/simple; bh=Pzx1qqr8LuAxSqjAns8kngkzT2rdenVRr82rVrnsOrY=; h=DKIM-Signature:From:To:Subject:MIME-Version:Message-ID:Date; b=pPeYEcDS54A6LpdoPSWaiXx5ZyEcLBHnTVz63dgDAgF+vQcjdmsitqMQ7RzcEOUhxK8dNrdsoI9MgID5BoM6eK8Yz3kTFWGbQ+R52E44OKrNx5S5wc3Q+LZ+/q0+0v3syBNbyWGU98Xrw7WHZyskl9WBrbGvjjc81g4F3KR2okw= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=caNF4hGs6N2s6ZGeQ+lhOFGDYJBS5SbDm+AeiMLR7ZYsjJW7XB2O6HNrKFio6451IeFDuwoeOjtnIa1wWJ2mM6fq4iIE3rRIdTrRmab+tYytOGiVe35vWdpYRd78t+Q/8TRl/nNedASuTAdLw7EWKSIUVupQI/snlCakXNlkLTqVrgD23BVO+M7+YJt0hhp74g0edXpwTeDP1ZOs1qTHwSthJQB3EoWeJXdE0jLiiO36FZLQd2k+F1OtPa/ww2gSj6sS+eg3M/yVvdZYzrEBEqPcG1V8C/YdpMWBp15koLqSq7JVQtpVvml/kvgN68D04aNcrsCjwjPfUqm/SDhVEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HiNMPeek6Ef5QgkKktx/UXP4UddjWsBxFig25f0CGSU=; b=e5gZ8VVtf0SJE9fHISaTEDG9fZwfkJHVE5Iq3ULchK7sydViY0x27zzm/P4K7P1h4nDgXvzUDiC2Mo64T0xuAVS1CKwli1viM8qls7jeK/QKMXDjIF6h5EylcyEYgEvTG9maLNVx0fUg9qXKLGKY7Yomyr3e63L6I8fu/z3dXnsouhDCd6Av4UWT23EjlyvqbYyE8bbx4qmp73ADpI4t6179BQf4aNgrpHETZyByD5uc/4QrVzyCcdKHPPaxh6uxgZ7aSsXFF5GY6YWlNfW4ITdqNizm7vphup3Lb5Pk1KrpCkHmuNdzRRW5wHYdfG5Z2N29QKMcu3U6aZBpj+0DuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 195.60.68.100) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=axis.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=axis.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HiNMPeek6Ef5QgkKktx/UXP4UddjWsBxFig25f0CGSU=; b=p5NYVjcdNgQKOmDIruxdArDhdASp2eWkAIgQeuRrqYJLOQPYwN+/QzViOMEHsLiBs7ZHyUVkydyWGeicdXJj/rNudXa01XUCCUN6UUknrZiq9a4vOAr2FsA9NqGbJRhXL74uXQV4gi5swB8Vg09LbcMr910KJVG8D7NI42qsuTA= Received: from DU2PR04CA0240.eurprd04.prod.outlook.com (2603:10a6:10:2b1::35) by DB9PR02MB9828.eurprd02.prod.outlook.com (2603:10a6:10:456::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.26; Mon, 20 Nov 2023 02:12:58 +0000 Received: from DB5PEPF00014B97.eurprd02.prod.outlook.com (2603:10a6:10:2b1:cafe::d9) by DU2PR04CA0240.outlook.office365.com (2603:10a6:10:2b1::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.27 via Frontend Transport; Mon, 20 Nov 2023 02:12:58 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 195.60.68.100) smtp.mailfrom=axis.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=axis.com; Received-SPF: Fail (protection.outlook.com: domain of axis.com does not designate 195.60.68.100 as permitted sender) receiver=protection.outlook.com; client-ip=195.60.68.100; helo=mail.axis.com; Received: from mail.axis.com (195.60.68.100) by DB5PEPF00014B97.mail.protection.outlook.com (10.167.8.235) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7025.12 via Frontend Transport; Mon, 20 Nov 2023 02:12:58 +0000 Received: from SE-MAILARCH01W.axis.com (10.20.40.15) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 20 Nov 2023 03:12:57 +0100 Received: from se-mail01w.axis.com (10.20.40.7) by SE-MAILARCH01W.axis.com (10.20.40.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 20 Nov 2023 03:12:57 +0100 Received: from se-intmail01x.se.axis.com (10.0.5.60) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 20 Nov 2023 03:12:57 +0100 Received: from pchp3.se.axis.com (pchp3.se.axis.com [10.88.21.53]) by se-intmail01x.se.axis.com (Postfix) with ESMTP id 41599CB5D; Mon, 20 Nov 2023 03:12:57 +0100 (CET) Received: by pchp3.se.axis.com (Postfix, from userid 171) id 630B72041D; Mon, 20 Nov 2023 03:12:57 +0100 (CET) From: Hans-Peter Nilsson To: Jonathan Wakely CC: , In-Reply-To: <20231116172021.1344351-1-jwakely@redhat.com> (message from Jonathan Wakely on Thu, 16 Nov 2023 17:20:09 +0000) Subject: Re: [committed] libstdc++: Fix aligned formatting of stacktrace_entry and thread::id [PR112564] MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <20231116172021.1344351-1-jwakely@redhat.com> Message-ID: <20231120021257.630B72041D@pchp3.se.axis.com> Date: Mon, 20 Nov 2023 03:12:57 +0100 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB5PEPF00014B97:EE_|DB9PR02MB9828:EE_ X-MS-Office365-Filtering-Correlation-Id: a28bca9a-0351-4c5d-f4f3-08dbe96e3710 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t6C/ikKm1DZQsSHiQHYyYnoY75m4dNO4wHTXdf7nqQmdMwFzBfzZJzKhzox90Pm7wdsiR7jxZakhS6e/kwr4OiMHC5XAzqhS05DV8XXeHUrMp1n3vH11iZ6oGe4NHfaLxp/MhdK3jpDrhvkbIcgaMeMGZwGrJEaFH/H49KY2U1+WTYs7hy+6Dc9JsX090KMs5wFmtPcvD7Kn3LkA4zbw06C9S9qkEsI+76e3oI8o+ZwuSRLoSTQSTVYDGA6+feY2x1gnJ/KV/YsMZQhtJisBgpML15VefnYSv8Bx258kOiV2D9UZXER4xzs4hH4xZYGnQIjMhI4+XBV/mvsLezJEJB6BrCCWCbPz8Y8HCaOAE7Hgu02jCQ2RiduGZZdLNSV0hSrjGj/0Wnix+dG8SMEJ618fm27yt0xmht3zdragsgpM3dlTipBeLCyWmD241hzlWgyTaUDocAqANaE93w6IuzptFlHE+pu3YliECMlEbYq+vkttEgMcOuQMqURMpNALDEpD03RRVHdJCdXv/NhBVscccC8HXy3vtgJKf59JkhqFgRkeFDb5AwtVWCqC1UHDD8xfq1fRwEE51c4Km3D4EW2xLuZg9vY9yYndOEcIj8kE/vsYTu0JcH5XmULZ6TKTPWda7BichFU9npO4bxcRJX/liD4Z6Ctz2h7bvhnSLFUHESzOEmkMP13QDxBroy+N4XovbsPmZi2ctkO8L9UZopw3Nr/yCAbSPmHRQLO0C+LryiJsRaiNjrOssYJOJ+yboyzqkixhMHecwcUtaMevKA== X-Forefront-Antispam-Report: CIP:195.60.68.100;CTRY:SE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.axis.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(376002)(346002)(39850400004)(136003)(396003)(230922051799003)(451199024)(186009)(82310400011)(64100799003)(1800799012)(36840700001)(40470700004)(46966006)(40460700003)(336012)(26005)(426003)(6266002)(1076003)(83380400001)(36860700001)(5660300002)(4326008)(8676002)(8936002)(41300700001)(2906002)(47076005)(478600001)(316002)(6916009)(42186006)(54906003)(70206006)(70586007)(33656002)(82740400003)(356005)(81166007)(40480700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: axis.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 02:12:58.1808 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a28bca9a-0351-4c5d-f4f3-08dbe96e3710 X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=78703d3c-b907-432f-b066-88f7af9ca3af;Ip=[195.60.68.100];Helo=[mail.axis.com] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B97.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR02MB9828 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Jonathan Wakely > Date: Thu, 16 Nov 2023 17:20:09 +0000 > PR libstdc++/112564 > * include/std/stacktrace (formatter::format): Format according > to format-spec. > * include/std/thread (formatter::format): Use _Align_right as > default. > * testsuite/19_diagnostics/stacktrace/output.cc: Check > fill-and-align handling. Change compile test to run. > * testsuite/30_threads/thread/id/output.cc: Check fill-and-align > handling. You already know this, so JFTR: this introduced a regression for some targets, logged as PR112630. Was this change deliberate: > --- a/libstdc++-v3/testsuite/19_diagnostics/stacktrace/output.cc > +++ b/libstdc++-v3/testsuite/19_diagnostics/stacktrace/output.cc > @@ -1,4 +1,5 @@ > -// { dg-do compile { target c++23 } } > +// { dg-options "-lstdc++exp" } > +// { dg-do run { target c++23 } } > // { dg-require-effective-target stacktrace } > // { dg-add-options no_pch } i.e. changing from dg-compile to dg-run? I'm guessing so. Though the changelog entry and post isn't explicit, the use of VERIFY is rather clear and most tests in 19_diagnostics/stacktrace are dg-run. If so, can the "dg-run-ness" of the test please move to a separate test and let 19_diagnostics/stacktrace/output.cc be just dg-compile? This particular test may not warrant the consideration, but more so a pattern to follow for other tests. brgds, H-P PS. Sorry, I have no idea why regarding the underlying multi-target problem