From: Andrew Pinski <quic_apinski@quicinc.com>
To: <gcc-patches@gcc.gnu.org>
Subject: [PATCH 2/2] Fix gcc.target/aarch64/simd/vmulxd_{f64,f32}_2.c after after IPA-VRP improvement for return values
Date: Sat, 25 Nov 2023 18:58:00 -0800 [thread overview]
Message-ID: <20231126025800.1381015-2-quic_apinski@quicinc.com> (raw)
In-Reply-To: <20231126025800.1381015-1-quic_apinski@quicinc.com>
Just like the patch against gcc.target/aarch64/movk.c, the issue here
is the two functions, foo32 and foo64 needed to mark as noipa so that
IPA-VRP cannot propagate the return value.
gcc/testsuite/ChangeLog:
* gcc.target/aarch64/simd/vmulx.x (foo32): Mark as noipa rather
than noinline.
(foo4): Likewise.
---
gcc/testsuite/gcc.target/aarch64/simd/vmulx.x | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.target/aarch64/simd/vmulx.x b/gcc/testsuite/gcc.target/aarch64/simd/vmulx.x
index 8968a64a95c..869e7485646 100644
--- a/gcc/testsuite/gcc.target/aarch64/simd/vmulx.x
+++ b/gcc/testsuite/gcc.target/aarch64/simd/vmulx.x
@@ -33,13 +33,13 @@
while (0) \
/* Functions used to return values that won't be optimised away. */
-float32_t __attribute__ ((noinline))
+float32_t __attribute__ ((noipa))
foo32 ()
{
return 1.0;
}
-float64_t __attribute__ ((noinline))
+float64_t __attribute__ ((noipa))
foo64 ()
{
return 1.0;
--
2.34.1
next prev parent reply other threads:[~2023-11-26 2:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 2:57 [PATCH 1/2] Fix contracts-tmpl-spec2.C on targets where plain char is unsigned by default Andrew Pinski
2023-11-26 2:58 ` Andrew Pinski [this message]
2024-02-07 16:23 ` Torbjorn SVENSSON
2024-02-07 17:13 ` Andrew Pinski (QUIC)
2024-02-07 17:36 ` Torbjorn SVENSSON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231126025800.1381015-2-quic_apinski@quicinc.com \
--to=quic_apinski@quicinc.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).