From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id EBE883857B9C for ; Tue, 28 Nov 2023 07:39:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EBE883857B9C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EBE883857B9C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701157149; cv=none; b=ksJ1ltUW7BEcPEzUyTTpTM1iw/Gp50dVRye2ua6DaqwDnRSOpZi0NpBrbzZy9OcN8zF3lQrC54vzy3BRrti+rHeknNdjkaXrc2EUns/XOqEm7u3iIYGjMPCITZaH8tCLJFbkACQuNFDaFw+Wsmtw7G8/WFz8FbrSV1xQ+hKM/ek= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701157149; c=relaxed/simple; bh=Df0QMT11FKo8UxlvkhbYdgW5fMdlY7j44HBMaSShERA=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=i+IJG4eKxPOWaS8UtST4OKdCIbBwATtpp64JJ1/EIir6AYbR2bh4FU3ACWVUTxTM0jIJrxGe+JiTmyqxoEB1JRual+8sZOSJIx740nvFwFxxNN7lF0q+VugOwSNql0d6gHm2pfE/XkKZlwliapCQ4JaSedmtS2iEh9aKg1nE3u4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.2.6.5]) by gateway (Coremail) with SMTP id _____8DxxPAYmWVlBFk9AA--.57640S3; Tue, 28 Nov 2023 15:39:04 +0800 (CST) Received: from 5.5.5 (unknown [10.2.6.5]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxiuQWmWVlao9OAA--.44106S4; Tue, 28 Nov 2023 15:39:02 +0800 (CST) From: Li Wei To: gcc-patches@gcc.gnu.org Cc: xry111@xry111.site, i@xen0n.name, xuchenghua@loongson.cn, chenglulu@loongson.cn, Li Wei Subject: [PATCH v1 2/2] LoongArch: Optimize vector constant extract-{even/odd} permutation. Date: Tue, 28 Nov 2023 15:39:00 +0800 Message-Id: <20231128073900.2452086-1-liwei@loongson.cn> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:AQAAf8DxiuQWmWVlao9OAA--.44106S4 X-CM-SenderInfo: 5olzvxo6or00hjvr0hdfq/ X-Coremail-Antispam: 1Uk129KBj93XoWxZr48Wr17GFy5tr1ktr1DArc_yoWrAw18pa y7ArnxKF48JFs3Gw48J3y5XrnxKrWxWr1avFnxKw1Sk347WryqqF1rtr9F9F1Uta1rWrn2 qw1Fk3WY9F42y3cCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUkYb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x 0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E 7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcV C0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF 04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7 CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU1QVy3UUUUU== X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: For vector constant extract-{even/odd} permutation replace the default [x]vshuf instruction combination with [x]vilv{l/h} instruction, which can reduce instructions and improves performance. gcc/ChangeLog: * config/loongarch/loongarch.cc (loongarch_is_odd_extraction): Supplementary function prototype. (loongarch_is_even_extraction): Adjust. (loongarch_try_expand_lsx_vshuf_const): Adjust. (loongarch_is_extraction_permutation): Adjust. (loongarch_expand_vec_perm_const_2): Adjust. gcc/testsuite/ChangeLog: * gcc.target/loongarch/lasx-extract-even_odd-opt.c: New test. --- gcc/config/loongarch/loongarch.cc | 33 +++++++++++- .../loongarch/lasx-extract-even_odd-opt.c | 54 +++++++++++++++++++ 2 files changed, 85 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.target/loongarch/lasx-extract-even_odd-opt.c diff --git a/gcc/config/loongarch/loongarch.cc b/gcc/config/loongarch/loongarch.cc index d3896d72bc2..f89c346815d 100644 --- a/gcc/config/loongarch/loongarch.cc +++ b/gcc/config/loongarch/loongarch.cc @@ -8672,6 +8672,12 @@ loongarch_expand_vec_perm (rtx target, rtx op0, rtx op1, rtx sel) } } +static bool +loongarch_is_odd_extraction (struct expand_vec_perm_d *); + +static bool +loongarch_is_even_extraction (struct expand_vec_perm_d *); + static bool loongarch_try_expand_lsx_vshuf_const (struct expand_vec_perm_d *d) { @@ -8694,6 +8700,24 @@ loongarch_try_expand_lsx_vshuf_const (struct expand_vec_perm_d *d) if (d->testing_p) return true; + /* If match extract-even and extract-odd permutations pattern, use + * vselect much better than vshuf. */ + if (loongarch_is_odd_extraction (d) + || loongarch_is_even_extraction (d)) + { + if (loongarch_expand_vselect_vconcat (d->target, d->op0, d->op1, + d->perm, d->nelt)) + return true; + + unsigned char perm2[MAX_VECT_LEN]; + for (i = 0; i < d->nelt; ++i) + perm2[i] = (d->perm[i] + d->nelt) & (2 * d->nelt - 1); + + if (loongarch_expand_vselect_vconcat (d->target, d->op1, d->op0, + perm2, d->nelt)) + return true; + } + for (i = 0; i < d->nelt; i += 1) { rperm[i] = GEN_INT (d->perm[i]); @@ -8878,7 +8902,7 @@ loongarch_is_even_extraction (struct expand_vec_perm_d *d) result = false; break; } - buf += 1; + buf += 2; } return result; @@ -8900,7 +8924,7 @@ loongarch_is_extraction_permutation (struct expand_vec_perm_d *d) result = false; break; } - buf += 2; + buf += 1; } return result; @@ -9377,6 +9401,11 @@ loongarch_expand_vec_perm_const_2 (struct expand_vec_perm_d *d) Selector after: { 1, 3, 1, 3 }. Even extraction selector sample: E_V4DImode, { 0, 2, 4, 6 } Selector after: { 0, 2, 0, 2 }. */ + + /* Better implement of extract-even and extract-odd permutations. */ + if (loongarch_expand_vec_perm_even_odd (d)) + return true; + for (i = 0; i < d->nelt / 2; i += 1) { idx = d->perm[i]; diff --git a/gcc/testsuite/gcc.target/loongarch/lasx-extract-even_odd-opt.c b/gcc/testsuite/gcc.target/loongarch/lasx-extract-even_odd-opt.c new file mode 100644 index 00000000000..515f0c8621a --- /dev/null +++ b/gcc/testsuite/gcc.target/loongarch/lasx-extract-even_odd-opt.c @@ -0,0 +1,54 @@ +/* { dg-do compile } */ +/* { dg-options "-O3 -mlasx" } */ +/* { dg-final { scan-assembler "xvilvl.d" } } */ +/* { dg-final { scan-assembler "xvilvh.d" } } */ + +#define CMUL(a, b, c) \ + { \ + (c).ai = (a).ai * (b).ai - (a).bi * (b).bi; \ + (c).bi = (a).ai * (b).bi + (a).bi * (b).ai; \ + (c).ci = (a).ci * (b).ci - (a).di * (b).di; \ + (c).di = (a).ci * (b).di + (a).di * (b).ci; \ + } +#define CSUM(a, b) \ + { \ + (a).ai += (b).ai; \ + (a).bi += (b).bi; \ + (a).ci += (b).ci; \ + (a).di += (b).di; \ + } + +typedef struct +{ + double ai; + double bi; + double ci; + double di; +} complex; + +typedef struct +{ + complex e[6][6]; +} matrix; + +typedef struct +{ + complex c[6]; +} vector; + +void +mult_adj_mat_vec (matrix *a, vector *b, vector *c) +{ + register int i, j; + register complex x, y; + for (i = 0; i < 6; i++) + { + x.ai = x.bi = x.ci = x.di = 0.0; + for (j = 0; j < 6; j++) + { + CMUL (a->e[j][i], b->c[j], y); + CSUM (x, y); + } + c->c[i] = x; + } +} -- 2.31.1