From: Patrick Palka <ppalka@redhat.com>
To: gcc-patches@gcc.gnu.org
Cc: jason@redhat.com, Patrick Palka <ppalka@redhat.com>
Subject: [PATCH 2/2] c++: guard more against undiagnosed error_mark_node [PR112658]
Date: Tue, 28 Nov 2023 11:51:12 -0500 [thread overview]
Message-ID: <20231128165112.2571430-2-ppalka@redhat.com> (raw)
In-Reply-To: <20231128165112.2571430-1-ppalka@redhat.com>
This adds a sanity check to cp_parser_expression_statement similar to
the one in finish_expr_stmt added by r6-6795-g0fd9d4921f7ba2, which
effectively downgrades accepts-invalid/wrong-code bugs like this one
into ice-on-invalid/ice-on-valid ones.
PR c++/112658
gcc/cp/ChangeLog:
* parser.cc (cp_parser_expression_statement): If the statement
is erroneous, make sure we've seen an error.
---
gcc/cp/parser.cc | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc
index 2464d1a0783..743d6517b09 100644
--- a/gcc/cp/parser.cc
+++ b/gcc/cp/parser.cc
@@ -12962,6 +12962,9 @@ cp_parser_expression_statement (cp_parser* parser, tree in_statement_expr)
if (statement == error_mark_node
&& !cp_parser_uncommitted_to_tentative_parse_p (parser))
{
+ /* If we ran into a problem, make sure we complained. */
+ gcc_assert (seen_error ());
+
cp_parser_skip_to_end_of_block_or_statement (parser);
return error_mark_node;
}
--
2.43.0.rc1
next prev parent reply other threads:[~2023-11-28 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 16:51 [PATCH 1/2] c++: casting array prvalue [PR112658, PR94264] Patrick Palka
2023-11-28 16:51 ` Patrick Palka [this message]
2023-11-28 21:33 ` [PATCH 2/2] c++: guard more against undiagnosed error_mark_node [PR112658] Jason Merrill
2023-11-28 21:32 ` [PATCH 1/2] c++: casting array prvalue [PR112658, PR94264] Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128165112.2571430-2-ppalka@redhat.com \
--to=ppalka@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).