From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2083.outbound.protection.outlook.com [40.107.22.83]) by sourceware.org (Postfix) with ESMTPS id 34CDF38582A0 for ; Wed, 29 Nov 2023 18:00:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 34CDF38582A0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 34CDF38582A0 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.83 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701280854; cv=pass; b=bieN2x6biaWzXw5EnUE/7FNSFIcs4Q9KOSP3ZWYvh++w95KZifIlIINdOMtxIyMQAqNXMrM2ZXxl4N70+et8vjz3qQlGqV/XICUm/xAkf6XnG4wf5vv8dr4k8jL7T/jtzOXizJJ95rFC+zXQ8++xY+2uveWW17vUAL7vvAo39f4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701280854; c=relaxed/simple; bh=W6FDJ1m92y4iBPTV4IJwyFTzPr968LJCVLKJrwjr3KQ=; h=DKIM-Signature:From:To:Subject:MIME-Version:Message-ID:Date; b=ueERTMp9DkVBEoBAqa6KJArJgT4/luS7uHRLjZeIbPOpatjOd9ApcvpXs+NSz84lfzM6vNYCUQNhQTs4hVOXDFXlbaFFMoPty5bI88YLJzSz9Gp08O9m0lkD118YL3GQ9Oo1I6dYRYPSAYQT+JBbefUni/i1rW2zMqY+p0EKygk= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i5ky1sUuNj1P71mnIeOBwq3xuqzFUvGq0aZmA2PxYu4MCa3furd7HIXJ3cWq/uEWuDfHz+UL0HMS7Dta4SPk1nlZh+ifSR8ZXXE0jdF4NhCmeLqpU07a0s45190kXJAdFoEYFuMdhsd2QtKnq2wDoOw5xAxMGV9Pkjrvh9+fC2e4slf3bxHdpnmadsDw1o1Els3alw5Bbkd4gZafAQg4ktlE3oridPdVy3WWm4IndjEgM9b1mfyjY4GtVdG17qDNv+DHDs+KgPORF660xC5he01fpP42euegB9TN85VgKKDGygIduWFQ1geGNh5fn0urnDSo0px2d3aq8MOkqCFbbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ycBbHryRNDnIf7CCLfCvJ7iwka1ZxgjYnAqHQKXc/Y0=; b=TZrmeedzOrxt9GpWaKLbPr+w6OxnVjuLc5GnkubHD+TaEelvJZ5bN6jfvJqebKcqrbu7Dtj6beHSvRCqUNba/MQrH/V0Lpa2DAumuMqcrawVTERQPbFE6z4DwTYdjIWcO4pSI+Fxvseq4GVzFMBTau34n1bQcnaX8Gj7DWgf9Iu0cCG4WHgNXYa4kHq2LXE8wnAP9vj5OxFR8xvqkVHpXXbE4KydvqljxpaU0ufaXQEXZra06ZkxltQ9FXC8htNV1E2SOZMQ5Z6xgMqU+PNTp/GoPD4eZKLiDfQSXBRHO3m792uolwCc/m8AIIjQI4VxJvNtNb19TAqvgVqJsT7W1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 195.60.68.100) smtp.rcpttodomain=adacore.com smtp.mailfrom=axis.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=axis.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ycBbHryRNDnIf7CCLfCvJ7iwka1ZxgjYnAqHQKXc/Y0=; b=mPr6pDuobxkn1WBhocOTCWrBeKf+5i5Cw7mAMWKw0ZBUiDXoaFCFHxhmALEWPl97IFoIL2S0ucAahPH+93l2dtEwJf0LNs5uRbd06WGZARB1bl02pIS0lyU9g6ZVgszXnIJJxaA2TcpkFxSqSG6YTtRQBjNVJJhMR7aRLEKB0WQ= Received: from DB3PR06CA0036.eurprd06.prod.outlook.com (2603:10a6:8:1::49) by AS4PR02MB8744.eurprd02.prod.outlook.com (2603:10a6:20b:58d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Wed, 29 Nov 2023 18:00:50 +0000 Received: from DB5PEPF00014B8D.eurprd02.prod.outlook.com (2603:10a6:8:1:cafe::15) by DB3PR06CA0036.outlook.office365.com (2603:10a6:8:1::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27 via Frontend Transport; Wed, 29 Nov 2023 18:00:48 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 195.60.68.100) smtp.mailfrom=axis.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=axis.com; Received-SPF: Fail (protection.outlook.com: domain of axis.com does not designate 195.60.68.100 as permitted sender) receiver=protection.outlook.com; client-ip=195.60.68.100; helo=mail.axis.com; Received: from mail.axis.com (195.60.68.100) by DB5PEPF00014B8D.mail.protection.outlook.com (10.167.8.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7046.17 via Frontend Transport; Wed, 29 Nov 2023 18:00:47 +0000 Received: from SE-MAILARCH01W.axis.com (10.20.40.15) by se-mail02w.axis.com (10.20.40.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 29 Nov 2023 19:00:47 +0100 Received: from se-mail01w.axis.com (10.20.40.7) by SE-MAILARCH01W.axis.com (10.20.40.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 29 Nov 2023 19:00:47 +0100 Received: from se-intmail01x.se.axis.com (10.0.5.60) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 29 Nov 2023 19:00:47 +0100 Received: from pchp3.se.axis.com (pchp3.se.axis.com [10.88.21.53]) by se-intmail01x.se.axis.com (Postfix) with ESMTP id 19085EE86; Wed, 29 Nov 2023 19:00:47 +0100 (CET) Received: by pchp3.se.axis.com (Postfix, from userid 171) id 1334620430; Wed, 29 Nov 2023 19:00:47 +0100 (CET) From: Hans-Peter Nilsson To: CC: , , Rainer Orth , , In-Reply-To: (message from Rainer Orth on Tue, 28 Nov 2023 16:13:35 +0100) Subject: Re: [PATCH] testsuite: scev: expect fail on ilp32 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <6f1516e7-f4be-4e13-b04c-8b5c31cae4f7@gmail.com> Message-ID: <20231129180047.1334620430@pchp3.se.axis.com> Date: Wed, 29 Nov 2023 19:00:47 +0100 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB5PEPF00014B8D:EE_|AS4PR02MB8744:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e2edf45-ae7d-4f12-1c91-08dbf1051dba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Glrmpnsed7ZlRtPEG1WdhW+KsRadvZUgWpGcZft0xh9gPtWmhiW7XaQ2WkcfjaLUYlRtGr5FTDZvadVTkX/Cm0b2NrBEvtlTvngcoLbILIpSIZcHAazQEwl2AlGmzYMalTeE3TH6/FyPPHm4FdY4o7uPg7gDPHciVAfqrYsbkgA3LZDmFiFPMQ4m5Qy4eLHzreGHos3yzDCaNxnBLBbdiGBZZahA0tCxr6nXVSisVzZ+0kbSpT2Z9mZmv/Rda08Ef6E5OTqHtDyaQiODrwFR+UHiGoce0JG3uM2nguVZYhC4WNisVy6h8ZFC2moSl7QVDMF6s3JBdQbCNRH8lzEiGUPdT236kLW6ky420cCmhCCgpySW3rE6WD2irUw55lUQjalW5sB7y/xblF9HtwF8hDhegZGGtrD6txpUNGk/4Oyx1i/B0VsIZD83jCIjFkTV27qNJU/xBXmmUSS/TbE5NBaTLx5C8YtbNFqIQEmFGAvZ9hw8sRsvlwGkFqa6mfZm9Cq9p/qnVDmresryBAoItz1tEjxd2NtikAfuU+8BpWTU4g6G5bVBdHAZ7yF+rJV5aLNhflK4VXkYxYaGzkJL8OGKwO+hbwbfDTp1Gc5Se7ycvd9KjeVsAgO8rJIUKFvBx3wU4Rf1zUrIiKwHSonT5eSFyyoGIyVA5g8+VxWCGnXvGmSBzzPnZg88d11QQMe5Rx1SGClSz7HWs66cWbcEFK/ni5O/hl95QAD9Gx9SQbhirAdYTG39Vmy8FKFLlIec X-Forefront-Antispam-Report: CIP:195.60.68.100;CTRY:SE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.axis.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(346002)(39860400002)(136003)(376002)(396003)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(82310400011)(36840700001)(46966006)(40470700004)(4326008)(8936002)(8676002)(53546011)(6916009)(54906003)(42186006)(316002)(966005)(478600001)(40460700003)(81166007)(47076005)(356005)(40480700001)(41300700001)(36860700001)(1076003)(26005)(70586007)(2906002)(6266002)(82740400003)(426003)(84970400001)(5660300002)(336012)(83380400001)(70206006)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: axis.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2023 18:00:47.8142 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7e2edf45-ae7d-4f12-1c91-08dbf1051dba X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=78703d3c-b907-432f-b066-88f7af9ca3af;Ip=[195.60.68.100];Helo=[mail.axis.com] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B8D.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR02MB8744 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Rainer Orth > Date: Tue, 28 Nov 2023 16:13:35 +0100 > Richard Biener writes: > > > On Sun, 19 Nov 2023, Jeff Law wrote: > > > >> > >> > >> On 11/19/23 00:30, Alexandre Oliva wrote: > >> > > >> > I've recently patched scev-3.c and scev-5.c because it only passed by > >> > accident on ia32. It also fails on some (but not all) arm-eabi > >> > variants. It seems hard to characterize the conditions in which the > >> > optimization is supposed to pass, but expecting them to fail on ilp32 > >> > targets, though probably a little excessive and possibly noisy, is not > >> > quite as alarming as getting a fail in test reports, so I propose > >> > changing the xfail marker from ia32 to ilp32. > >> > > >> > I'm also proposing to add a similar marker to scev-4.c. Though it > >> > doesn't appear to be failing for me, I've got reports that suggest it > >> > still does for others, and it certainly did for us as well. > >> > > >> > Regstrapped on x86_64-linux-gnu, also tested on arm-eabi with default > >> > cpu on trunk, and with tms570 on gcc-13. Ok to install? > >> > > >> > > >> > for gcc/testsuite/ChangeLog > >> > > >> > * gcc.dg/tree-ssa/scev-3.c: xfail on all ilp32 targets, > >> > though some of these do pass. > >> > * gcc.dg/tree-ssa/scev-4.c: Likewise. > >> > * gcc.dg/tree-ssa/scev-5.c: Likewise. > >> OK. Though hopefully someone will figure out what properties actually cause > >> the differences so that we can do the right thing without the noisy XPASS at > >> some point. > > > > The tests all test IVOPTs induction variable selecting results > > (assuming every target would come to the "obvious" conclusion), > > so it's probably not only target but also sub-target (aka -mtune) > > sensitive ... > > > > In the end we might need to move/duplicate the test to some > > gcc.target/* dir and restrict it to a specific tuning. > > FWIW, since Alexandre's patch all three tests XPASS on 32-bit > Solaris/SPARC: > > XPASS: gcc.dg/tree-ssa/scev-3.c scan-tree-dump-times ivopts "&a" 1 > XPASS: gcc.dg/tree-ssa/scev-4.c scan-tree-dump-times ivopts "&a" 1 > XPASS: gcc.dg/tree-ssa/scev-5.c scan-tree-dump-times ivopts "&a" 1 It XPASSes on the ilp32 targets I've tried - except "ia32" (as in i686-elf) and h8300-elf. Notably XPASSing targets includes a *default* configuration of arm-eabi, which in part contradicts your observation above. I see it even XPASSes in H.J.'s x86_64-pc-linux-gnu -mx32 results. Right, that's not ia32, but it's as ilp32ish as ia32 and can be expected to share most "interesting" properties with ia32. Example report at https://gcc.gnu.org/pipermail/gcc-testresults/2023-November/801862.html. Alex, can you share the presumably plural set of targets where you found gcc.dg/tree-ssa/scev-[3-5].c to fail before your patch, besides "ia32"? I see them XPASS for: m68k-unknown-linux-gnu (https://gcc.gnu.org/pipermail/gcc-testresults/2023-November/801839.html) pru-unknown-elf (https://gcc.gnu.org/pipermail/gcc-testresults/2023-November/801732.html) and from my own testing, at r14-5608-g69741355e6dbcf: cris-elf, c6x-elf, epiphany-elf, ft32-elf, hppa-unknown-linux-gnu, lm32-elf, microblaze-linux, m32r-elf, arm-eabi. So, ilp32 is IMO a really bad approximation for the elusive property. Would you please consider changing those "ilp32" to a specific set of targets where these tests failed? I'd prefer not to complicate those expressions by adding the right spelling of "ilp32 except { list }". brgds, H-P