From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2078.outbound.protection.outlook.com [40.107.7.78]) by sourceware.org (Postfix) with ESMTPS id 9E1623858295 for ; Thu, 30 Nov 2023 17:09:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E1623858295 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9E1623858295 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.7.78 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701364155; cv=pass; b=pACY7R1uPi6uqIi/XyJTIBfMjVWYr3IKXIW0ZlweUHR69GlCx3FmrG6gfAYRCTOn8NQV+kHJyBreVoqR+cAMXwCeiwhLOWfoFp7HWgPgDj1QKArelCNbEQhVLj7nykqlj69sMX1HkcGclzzRgw0aLqpWhJFYRu2SvQPasO+7X68= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701364155; c=relaxed/simple; bh=x8BDMhTL4ULAG5jScyqKMRkurFyxy70BZat5CcTwhFM=; h=DKIM-Signature:From:To:Subject:MIME-Version:Message-ID:Date; b=NyZxrITPIboP03XENcFACtJ1S/plq9JCZ5HgIY+k+yX60hH6FLt8G+8Y3s5w44cxUcZ0bmnGg25911kjy7CKRM4WPrL+wp44qg9lFOgBJCeNzD2Lqq+AOEVKG3r6UDQ+dNyDmFJ7Wbhl+qGFA99RAxFDAaaIIvEp769VTHmHSCM= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kiu+XhHn4bP8kgKUbR0YJSMU8Becno/qBHUW6UE0J4aZLwghw64RRaQgHqZ3P3Yvit9qEc3wVbyp63zPrJcSWYEVgxTMZVOhg0nCC9IkyLam2VvSZ1JY8XFT4ln3VxLsKa7RYKze6cKTBlsCWxEXbAeBb/Zv7OZXr0np8/Jv44gBQ7ajZpUTKXFRvgMVLFdIqfDArQDPrKhipFrk2WiNt0JQQ4YbhxjfCkyQiwj45zsFyPMrFH8xSZvinqPt8+NM4XHermoeiZturYHswIZORu6CDLsAmkd9RsBVY37k4r2MC1kJMsaS0sxHpWArK9l8gIDVAImWKpaQKYBDzGGnQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xec6Hm9qYjioFPa6uFAXFIbcIwMeTJAU7Hds8ISVqHU=; b=ZjZDNxYxR9k1vLHhLybAmvUo370ZpEVcQbDzEr3zY6mgymS047swBOtNl7P1A63N/7VIHz+tCq6Vjx6tV0bVpF/zoJooIdv4z0bV5OeUrrky1sARpetcRAd+U9rn17tRyjHqtWUz9EHYBVuydsHEj9SjMfHcDN+V+b+aMWFYJTlRqoOxzXskSzyjwDhGokTevJV3p+NFcUWeR989QsFRYs3Wbdw2mJpMvPxDYuX9bqYultGNXmV4h1p/16L+4gWrJbsvXKJQ8WllscuSwTKmLiVPyiOBHR2HV6tnXGgeWlTMLv06F7WF3rhTOMrgDTQ5rPrDc/l/czwlI6mn6O0MqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 195.60.68.100) smtp.rcpttodomain=adacore.com smtp.mailfrom=axis.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=axis.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xec6Hm9qYjioFPa6uFAXFIbcIwMeTJAU7Hds8ISVqHU=; b=WVimpprQJhy/rFhHQabWmpYdZa7Sqr3ATV+9kxPUSl0D61v9RZW2enV845AKY0Nhtfg1l/P3kjfKOri3mfQbLWLgakR1Kn991dUkpxvRwExFIv/LVX3LENgZk43ii84QB5V7ZwvLLX2b9adG/NZY1pZHkLxys0rRDJSU+hqGW7Y= Received: from AS9PR06CA0165.eurprd06.prod.outlook.com (2603:10a6:20b:45c::12) by AS2PR02MB10101.eurprd02.prod.outlook.com (2603:10a6:20b:649::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.24; Thu, 30 Nov 2023 17:09:11 +0000 Received: from AMS1EPF00000045.eurprd04.prod.outlook.com (2603:10a6:20b:45c:cafe::59) by AS9PR06CA0165.outlook.office365.com (2603:10a6:20b:45c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.23 via Frontend Transport; Thu, 30 Nov 2023 17:09:11 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 195.60.68.100) smtp.mailfrom=axis.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=axis.com; Received-SPF: Fail (protection.outlook.com: domain of axis.com does not designate 195.60.68.100 as permitted sender) receiver=protection.outlook.com; client-ip=195.60.68.100; helo=mail.axis.com; Received: from mail.axis.com (195.60.68.100) by AMS1EPF00000045.mail.protection.outlook.com (10.167.16.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7046.17 via Frontend Transport; Thu, 30 Nov 2023 17:09:10 +0000 Received: from SE-MAILARCH01W.axis.com (10.20.40.15) by se-mail02w.axis.com (10.20.40.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 30 Nov 2023 18:09:10 +0100 Received: from se-mail01w.axis.com (10.20.40.7) by SE-MAILARCH01W.axis.com (10.20.40.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 30 Nov 2023 18:09:10 +0100 Received: from se-intmail01x.se.axis.com (10.0.5.60) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 30 Nov 2023 18:09:10 +0100 Received: from pchp3.se.axis.com (pchp3.se.axis.com [10.88.21.53]) by se-intmail01x.se.axis.com (Postfix) with ESMTP id 616DEEF69; Thu, 30 Nov 2023 18:09:10 +0100 (CET) Received: by pchp3.se.axis.com (Postfix, from userid 171) id 5B7C720442; Thu, 30 Nov 2023 18:09:10 +0100 (CET) From: Hans-Peter Nilsson To: Alexandre Oliva CC: , , , , , In-Reply-To: (message from Alexandre Oliva on Thu, 30 Nov 2023 01:41:55 -0300) Subject: Re: [PATCH] testsuite: scev: expect fail on ilp32 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <6f1516e7-f4be-4e13-b04c-8b5c31cae4f7@gmail.com> <20231129180047.1334620430@pchp3.se.axis.com> Message-ID: <20231130170910.5B7C720442@pchp3.se.axis.com> Date: Thu, 30 Nov 2023 18:09:10 +0100 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF00000045:EE_|AS2PR02MB10101:EE_ X-MS-Office365-Filtering-Correlation-Id: 903f1694-98e7-4b7c-1571-08dbf1c7123d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EDZjUEK/9DwMqCE//E+JZ2njV6kIRs13atr+ZjgudQdgCvJOPD1sT8PyhGsHpMzDOnnnYNJJ18F9HSS/jFE/V//ULasCszqYZWQYs5LOvSWKiOxH+/E8OUfgfJt6SLRNTvbYdDKz1J8wdgEewqidjlF3GFIjZy5mdA4vdcVTStQeDXBKemZ357b9oIEj5UuxZ2WO39Ijb3xmYH5ersYzuc4JeNrAoLZqtuRIh7qSWGeGE+udh2PR3KfDTMeNVUqWog7NdUc24frRMzWMmcbAOJ3PMTg/1PliVeRn5OiNCF0trrNOmYdsHYVBGj0cmGZIQ8Dlk+f+drYqAPt4MskXurUbXKkGh4w0Mz5ltDHF40ojX165Wot/ac7Lp0sqnPvV5dLZrWI+ya//jIflBkzeqojWvZOoLahTXT/4uEp0stFvrr6OxUJrVoUN6l9GFFGiVvfMBM+KwJf2Vbbks8OP7mGAHaNlpZTItXXv4cBowG2PMlGgZ5BvqA3kEPWhUGRSDjBgVXCpET5xBgbzBaZb0Ypl8OrGY0pJKeh7wJMFU+0As8SKMWJA26wa71Clo+kMa3MjPFU7VryzmwwbZq/ywEMBjIvVx4ItseoDevVkCQlrGcr3ruEttakv2i901tATG4c6bDW5Gif5PrFUw6289x5gWw8wJGSAwDFeOTOvzJpkg9BFU0CcKFrkYMkDURMe1PzMsmeiKhAE3+oOOLhf1PP1lHGD7oIzZus1zIdzjSSzsj8pqPLnh0Yp5Tp1DjoJqZOZDhS2+UlDewiKSPiT5g== X-Forefront-Antispam-Report: CIP:195.60.68.100;CTRY:SE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.axis.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(346002)(136003)(396003)(376002)(39860400002)(230922051799003)(64100799003)(186009)(82310400011)(451199024)(1800799012)(36840700001)(40470700004)(46966006)(40480700001)(84970400001)(40460700003)(70206006)(70586007)(54906003)(6916009)(81166007)(82740400003)(356005)(33656002)(36860700001)(47076005)(426003)(1076003)(336012)(26005)(6266002)(2906002)(478600001)(42186006)(316002)(5660300002)(8676002)(41300700001)(4326008)(8936002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: axis.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 17:09:10.9523 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 903f1694-98e7-4b7c-1571-08dbf1c7123d X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=78703d3c-b907-432f-b066-88f7af9ca3af;Ip=[195.60.68.100];Helo=[mail.axis.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF00000045.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR02MB10101 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Alexandre Oliva > Date: Thu, 30 Nov 2023 01:41:55 -0300 > On Nov 29, 2023, Hans-Peter Nilsson wrote: > > >> XPASS: gcc.dg/tree-ssa/scev-3.c scan-tree-dump-times ivopts "&a" 1 > >> XPASS: gcc.dg/tree-ssa/scev-4.c scan-tree-dump-times ivopts "&a" 1 > >> XPASS: gcc.dg/tree-ssa/scev-5.c scan-tree-dump-times ivopts "&a" 1 > > > It XPASSes on the ilp32 targets I've tried - except "ia32" > > (as in i686-elf) and h8300-elf. Notably XPASSing targets > > includes a *default* configuration of arm-eabi, which in > > part contradicts your observation above. > > My arm-eabi testing then targeted tms570 (big-endian cortex-r5). > > I borrowed the ilp32 vs lp64 line from an internal patch by Eric that > we've had in gcc-11 and gcc-12, when I hit this fail while transitioning > the first and then the second of our 32-bit targets to gcc-13. 'k, I interpret that as that ilp32 being mostly a copy-paste of unclear origin, and that there weren't actually any observation of more than two ilp32 targets failing (counting ia32 and one or more non-default armeb). > > So, ilp32 is IMO a really bad approximation for the elusive > > property. > > Yeah. Maybe we should just drop the ilp32, so that it's an unsurprising > fail on any targets? > > > Would you please consider changing those "ilp32" to a > > specific set of targets where these tests failed? > > I'd normally have aimed for that, but the challenge is that arm-eabi is > not uniform in the results for this test, and there doesn't seem to be > much support or knowledge to delineate on which target variants it's > meant to pass or not. That situation suggests to me to *skip* it for arm*-*-*. For other targets, skip or xfail as needed after a quick look. Or as per below. > The test expects the transformation to take > place, as if it ought to, but there's no strong reason to expect that it > should. There's nothing wrong if it doesn't. Going about trying to > match the expectations to the current results may be useful, but > investigating the reasons why we get the current results for each target > is beyond my available resources for a set of tests that used to *seem* > to pass uniformly only because of a bug in the test pattern. > > I don't see much value in these tests as they are, TBH. Richard B. seems to have been the last person doing significant work on those tests (rewriting scev-[3-5].c to gimple tests for ivopts, commit r7-6026-ga23e48df4514c4), so I value his suggestion per below particularly valuable: > > In the end we might need to move/duplicate the test to some > > gcc.target/* dir and restrict it to a specific tuning. I intend to post two alternative patches to get this resolved: 1: Move the tests to gcc.target/i386/scev-[3-5].c 2: gcc.dg/tree-ssa/scev-[3-5].c skipped for arm*, xfailed only on h8300-*-* and ia32. If you can help with e.g. reviewing, thanks in advance. I opened PR112786 to get an ID for the issue. brgds, H-P