From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2074.outbound.protection.outlook.com [40.107.241.74]) by sourceware.org (Postfix) with ESMTPS id 2D85A3858D37 for ; Thu, 30 Nov 2023 17:27:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D85A3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2D85A3858D37 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.241.74 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701365231; cv=pass; b=DtPYWzG2Ef/1JgZ5ypXxhnCGZCgDEGNzANIOL2PhM4+rNivyyeCquP09r+eb39J7Q/vzld7pbIAE+MFuzPGLphfq26OrdrnBk874QTCgCHYUNwvxZ7lOwAKaJtyN16W522+Y+un6hmcxj9jaB/gJw2b2Vs0au2GTl591gguQjvo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701365231; c=relaxed/simple; bh=UJTyi7KzcLpvgIkRBBqsHthl+ZBy58AH4RNZcxmCrhU=; h=DKIM-Signature:From:To:Subject:MIME-Version:Message-ID:Date; b=YfWqvdFZy7YFl3m/4OxqowXai+6L57/2kkirKnfU/LaU7y7rosufXEjjXnM9In3zWdnKP54Ry6eO+3uVi3CA9yQlZyMc46hz7Y/MiB4CN5JRCxNAMYXD6XZuJb5PNJtg0yGTmT2ekFTa+W393AZzXFZsdE2yLvh69iOwOpqmi/I= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HmotUelkpQgQMifTznvmrAeybhWkoK+dJheJvquhiczF75E0tksxUTtkCyW/XY74aihPasQCEiRhcbb7QtC8WaZ7hW3xdBXLxMirSupdkwCs88D3hCznsBBmEeDKprQAw0LPLYNHS2F3S6cVRPi4PpT6BvB6bApZG+oPzdJZeDKA/mvGQ2Db1wzsod2dej10UZUVkvq+tlAWuodAkWEYonNEV+6aD1rsa9xXPXIV1it2vIpWyf0wVmUyKtYP+ATSqOpNtVgHlrmA4Jjji+IAd80Qr9K/k4wurtMybFX/DdNT6POR2AkfjFuaFOBOz07oXb6eh+S3xcEfXkIDYnuyVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h0ltrnMf90ZDV/P3UCAkGKPxN9YgD7HwB0Fi9qIsw2o=; b=KQcecPIzma8V6q/f7qvm9eDzT+oCzF+GFpbqO6dwlXb6uGRusTboDzqe8A2S2D94h2oA7ogbSq2n+Je2oCf6NM3hu5P2nAOKnVnszPBhlvH44G0i7u+c/tvTaDxnO7vL8jrnreGyhjb5UZlVApiiT66+tmmLWay/FOqzmms/kpd/xFj7CxOs4KVZwpHd+A5skL31fmuT6Je+2DD9xmst8aXv9xuzwOtJ3Fm6B2Yi9j2FuuxEnGZJzkFhhgZOTUMgvczRW44PYxUPXTNmzyg6HXWVwj1qTTMzgV+srluyv4pIYwktPClNGml9Op0FX+N+/ZPuaKdcmbYUfj9hI6p5PQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 195.60.68.100) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=axis.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=axis.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h0ltrnMf90ZDV/P3UCAkGKPxN9YgD7HwB0Fi9qIsw2o=; b=oehTPLHadNC8jIXb5X3yCHUbLqZT/lHLsgpdywJZmJkTMiLvkDYDQLIPSxGvan5nujd2xXqS1/TFbuJGR02Qzh8W/dH0K2r+yIwygZz6LudzFLzJYXnb4qNYbyKYz/jWiUWTNDoJAMiuAYppumqnYFuD0ZeWENB1ZMU1uiaeh7w= Received: from AS4P190CA0003.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:5de::8) by DBAPR02MB6488.eurprd02.prod.outlook.com (2603:10a6:10:17d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.24; Thu, 30 Nov 2023 17:27:06 +0000 Received: from AM4PEPF00025F9C.EURPRD83.prod.outlook.com (2603:10a6:20b:5de::4) by AS4P190CA0003.outlook.office365.com (2603:10a6:20b:5de::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.24 via Frontend Transport; Thu, 30 Nov 2023 17:27:06 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 195.60.68.100) smtp.mailfrom=axis.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=axis.com; Received-SPF: Fail (protection.outlook.com: domain of axis.com does not designate 195.60.68.100 as permitted sender) receiver=protection.outlook.com; client-ip=195.60.68.100; helo=mail.axis.com; Received: from mail.axis.com (195.60.68.100) by AM4PEPF00025F9C.mail.protection.outlook.com (10.167.16.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7068.1 via Frontend Transport; Thu, 30 Nov 2023 17:27:06 +0000 Received: from SE-MAILARCH01W.axis.com (10.20.40.15) by se-mail02w.axis.com (10.20.40.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 30 Nov 2023 18:27:05 +0100 Received: from se-mail01w.axis.com (10.20.40.7) by SE-MAILARCH01W.axis.com (10.20.40.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 30 Nov 2023 18:27:05 +0100 Received: from se-intmail01x.se.axis.com (10.0.5.60) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 30 Nov 2023 18:27:05 +0100 Received: from pchp3.se.axis.com (pchp3.se.axis.com [10.88.21.53]) by se-intmail01x.se.axis.com (Postfix) with ESMTP id 7983CEEF3; Thu, 30 Nov 2023 18:27:05 +0100 (CET) Received: by pchp3.se.axis.com (Postfix, from userid 171) id 72B95203CF; Thu, 30 Nov 2023 18:27:05 +0100 (CET) From: Hans-Peter Nilsson To: CC: , Martin Uecker , In-Reply-To: <8f1e8fc04828bb659c6a06fc756a03076f2c43ea.camel@tugraz.at> (message from Martin Uecker on Mon, 27 Nov 2023 16:54:13 +0100) Subject: Re: Ping: [PATCH] Fix PR112419 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <20231107035835.7BC31203F2@pchp3.se.axis.com> <1e832537-f6e7-4599-8b35-6710f79b2a46@gmail.com> <20231116042406.B834320432@pchp3.se.axis.com> <20231123170511.04C0720427@pchp3.se.axis.com> <38d42164-10ef-42a1-9175-62c37c7c5f8e@gmail.com> <8f1e8fc04828bb659c6a06fc756a03076f2c43ea.camel@tugraz.at> Message-ID: <20231130172705.72B95203CF@pchp3.se.axis.com> Date: Thu, 30 Nov 2023 18:27:05 +0100 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM4PEPF00025F9C:EE_|DBAPR02MB6488:EE_ X-MS-Office365-Filtering-Correlation-Id: 109285ff-054b-49b6-2374-08dbf1c9931e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nd3L7GHkSAlAM167fSWDfNJHddLC3dhH6dssvrbxckxmzFPUgOAt1oWqugrb4cqjxNcfC13j1P+AQ3g9gkLy5ZAGyyUB2P+sGD8ac2fHj31tt1PtsfBRB+y0GyHUc/iNY+tL1QFHKPYR3WS8IoZgRaalBOb567PSlX+uEgY6dVoagct0ulQ3HQxY4kDxKO+ych5+vh+L23DYZKIjgb5jviIvioovSKjsYpFZ8Xv/xWZ/+CE1z0ZbcSAzrItPpLESySSCIaarGpHs2I5hPojszaZXPzPn6DfcpVHY+Yh5olY8iJmakdKTAQWSi9eRWUz6B+WUGS56bW4B3z6NlvmFSJ8Af1c4nARTQSqP/qfGccpkwMtzNPlm1UeZXqBVH/XQ4W6o5pSAB2aVrOuXfSnlnGjbeQ3pfpc15gpajNc3tpQaoaMnT4KLT4iDXYrDiAW0aIlm2j3vbEJ4XHBN1FnxKKVOyqo/7VHhCook4FaHgHsAycty/Fd8WFgkKM57xipCW4JqBKZnNiRASO+iev97MWQKhq8mywLbmNhNO/DjK9ZcyURek+YwrrPHE8QWcZlEzbwTbS3eJsRWB6l5a7Lb43lkhumwX9MLMmvevVGniUNUz+7lt+g5AKvQ6w35YsgN2Fc8TWz3Butx1aHm0DntjL+e9x2vgzsdQjE5hMNCx2KalUzF2CO51ocms+qjv66ad2Ur7nW1fg4P7KrexZyzYxglH2ue2giXBrm9KsAcMe2QeiOfyOyFGYbK7YHdrk8NlB+Iupy2hZCb+RyenH+vTCK6GW4mNLJ3br4/eJhJ0CPsvbWSJHtM95f4DTfNsfHB X-Forefront-Antispam-Report: CIP:195.60.68.100;CTRY:SE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.axis.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(346002)(396003)(39850400004)(376002)(136003)(230273577357003)(230173577357003)(230922051799003)(451199024)(1800799012)(186009)(82310400011)(64100799003)(40470700004)(36840700001)(46966006)(40460700003)(70206006)(4326008)(8676002)(6916009)(54906003)(8936002)(316002)(42186006)(41300700001)(478600001)(70586007)(2906002)(5660300002)(36860700001)(82740400003)(33656002)(356005)(47076005)(81166007)(1076003)(83380400001)(53546011)(336012)(6266002)(426003)(26005)(84970400001)(40480700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: axis.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 17:27:06.1691 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 109285ff-054b-49b6-2374-08dbf1c9931e X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=78703d3c-b907-432f-b066-88f7af9ca3af;Ip=[195.60.68.100];Helo=[mail.axis.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00025F9C.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR02MB6488 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Martin Uecker > Cc: richard.guenther@gmail.com > Am Montag, dem 27.11.2023 um 08:36 -0700 schrieb Jeff Law: > > > > On 11/23/23 10:05, Hans-Peter Nilsson wrote: > > > > From: Hans-Peter Nilsson > > > > Date: Thu, 16 Nov 2023 05:24:06 +0100 > > > > > > > > > From: Martin Uecker > > > > > Date: Tue, 07 Nov 2023 06:56:25 +0100 > > > > > > > > > Am Montag, dem 06.11.2023 um 21:01 -0700 schrieb Jeff Law: > > > > > > > > > > > > On 11/6/23 20:58, Hans-Peter Nilsson wrote: > > > > > > > This patch caused a testsuite regression: there's now an > > > > > > > "excess error" failure for gcc.dg/Wnonnull-4.c for 32-bit > > > > > > > targets (and 64-bit targets testing with a "-m32" option) > > > > > > > after your r14-5115-g6e9ee44d96e5. It's logged as PR112419. > > > > > > It caused failures for just about every target ;( Presumably it worked > > > > > > on x86_64... > > > > > > > > > > I do not think this is a true regression > > > > > just a problem with the test on 32-bit which somehow surfaced > > > > > due to the change. > > > > > > > > > > The excess error is: > > > > > > > > > > FAIL: gcc.dg/Wnonnull-4.c (test for excess errors) > > > > > Excess errors: > > > > > /home/tcwg-buildslave/workspace/tcwg_gnu_6/abe/snapshots/gcc.git~master/gcc/testsuite/gcc.dg/Wnonnull-4.c:144:3: warning: 'fda_n_5' specified size 4294967256 exceeds maximum object size > > > > > 2147483647 [-Wstringop-overflow=] > > > > > > > > > > I think the warning was suppressed before due to the other (nonnull) > > > > > warning which I removed in this case. > > > > > > > > > > I think the simple fix might be to to turn off -Wstringop-overflow. > > > > > > > > No, that trigs many of the dg-warnings that are tested. > > > > > > > > (I didn't pay attention to the actual warning messages and > > > > tried to pursue that at first.) > > > > > > > > Maybe think it's best to actually expect the warning, like > > > > so. > > > > > > > > Maintainers of 16-bit targets will have to address their > > > > concerns separately. For example, they may choose to not > > > > run the test at all. > > > > > > > > Ok to commit? > > > > > > > > Subject: [PATCH] gcc.dg/Wnonnull-4.c: Handle new overflow warning for 32-bit targets [PR112419] > > > > > > > > PR testsuite/112419 > > > > * gcc.dg/Wnonnull-4.c (test_fda_n_5): Expect warning for exceeding > > > > maximum object size for 32-bit targets. > > > > --- > > > > gcc/testsuite/gcc.dg/Wnonnull-4.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/gcc/testsuite/gcc.dg/Wnonnull-4.c b/gcc/testsuite/gcc.dg/Wnonnull-4.c > > > > index 1f14fbba45df..d63e76da70a2 100644 > > > > --- a/gcc/testsuite/gcc.dg/Wnonnull-4.c > > > > +++ b/gcc/testsuite/gcc.dg/Wnonnull-4.c > > > > @@ -142,6 +142,7 @@ void test_fda_n_5 (int r_m1) > > > > T ( 1); // { dg-bogus "argument 2 of variable length array 'double\\\[n]\\\[5]' is null but the corresponding bound argument 1 value is 1" } > > > > T ( 9); // { dg-bogus "argument 2 of variable length array 'double\\\[n]\\\[5]' is null but the corresponding bound argument 1 value is 9" } > > > > T (max); // { dg-bogus "argument 2 of variable length array 'double\\\[n]\\\[5]' is null but the corresponding bound argument 1 value is \\d+" } > > > > +// { dg-warning "size 4294967256 exceeds maximum object size" "" { target ilp32 } .-1 } > > > > } > > Unfortunately I think we need to go back to the original issue that > > Martin (I think) dismissed. > > > > Specifically, this is a regression. It's very clear that prior to the > > patch in question there was no diagnostic about the size of the > > requested memory allocation and after the patch in question we get the > > "exceeds maximum object size" diagnostic. > > > > Now one explanation could be that the diagnostic is warranted and it was > > a bug that the diagnostic hadn't been emitted prior to Martin's patch. > > In this case some kind of dg-blah is warranted, but I don't think anyone > > has made this argument. > > > I believe the warning is correct but was suppressed before. > > > My plan was to split up the test case in one which is for > -Wstringop-overflow and one which is for -Wnonnull and then > one could turn off the -Wstringop-overflow for the tests > which are actually for -Wnonnull. But adding the dg-blah > would certainly be simpler. Sort-of-mid-week ping (only because status quo isn't clear): Jeff, are you content with Martin U:s reply (i.e. patch ok) or are you waiting for a follow-up? Perhaps it's already in your overflowing queue, then please ignore this, I'll just ping in a week. ;-) IMHO, after looking at the test-case I'd expect *more* warnings for ilp32 targets; i.e. it was a bug that it didn't show up before. brgds, H-P