From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 515753858415 for ; Fri, 1 Dec 2023 15:42:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 515753858415 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 515753858415 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701445343; cv=none; b=mENA9E79W3yVt/sBMOYMpSgTf2yuo7MJr2EN9+8An/FHLe+eiXESHnV+WwkpQPC6hMIlMCmcSywXDiNbFfBegx5gBPr3ztUuZSLyCzduCVF0tHwgDxRtL1Q44JwJAXskInOWfl9dX8RVxcFrVSME9dkRFg1yKB2SevT4eCefGFM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701445343; c=relaxed/simple; bh=/1kCKgfTrgfJFvFBvTzE8f3OTml9TdR0jomYCi3zOug=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Ch/7DWy/Mz52qAkkkePDs68lCjknVjFElT5Wycwxcd1XBT5XwZ5FM+QYdJgq/Md/MsDixB5O6L2C+DnpF6LfFXDkh4vFwmS4ReErHsuYEV9nF7L/gSlZAoe6kgnO3uSeBkX4TbDLVv6Y9OtNuRrQMEiFCMQmdedeag1h8u3fBv8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-54c64316a22so766116a12.0 for ; Fri, 01 Dec 2023 07:42:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701445340; x=1702050140; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=In04tz5Kn9VWxAiKxE1LDsD5AJp5hW0YEv8LQfZGVyg=; b=aTbZD60aAxZJzu49oHvc808MTnmgi/a0OHxJqiBjckZ9sOh5i8eQ5txg3wgxoYtpJq qZDlNvGZFH/+J16oomJUxruoq9xrsH4rswcEla666vbk8tmrMRl/fFvhHFu5tKyEzR31 busONTsYAmLvoe2z7rIjMa3m0xlX4YZe8lsXAQ4q9jEmHF/q0FnzqIFg//Fnw42k65Py boKP5sIgX7loFKerMJEBhbq+VwxFeeZEZlgPMUcK60CcAHA9HOMTG39gM9U10Rlsjtdi 6CvMPs2QdQGLxOW0OEfSN+Rc6phSTPxPUFy4mEaJO2G3y7JaBz/PDZzQMv1+JRYttYFs MDsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701445340; x=1702050140; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=In04tz5Kn9VWxAiKxE1LDsD5AJp5hW0YEv8LQfZGVyg=; b=soJ200tSSBISO8GW8SqqqlmfQomEuzPfeR74d2O4Nx6iL8bn6pfE7l6ZtbdxvlajyR ArMVVPlpK+jecoRcYMlEF2ZHHRkLp0EaUZiG80HLO/p7CKJ4/lciG/dX0lAbZYoQN9D3 P1RjfJY4LSUAsNdoXVyKqjMiXa1fuuqXcM72fWO4cvJqp8NVba1y7py3NCgRvxvd2v+9 o2AkIL+xTwIN+Bxcn1QaUSLFFi2qkECJrmgU9NnzlN/8vh94Vvc0I3O0ozr5X9iHRJ6D SWd8yBHIJ1zzHk3uLdbeY5DPFPxFoPPT0md6dHAirvBNAzf2B6Xbpt5egYe+iTRxyZAy deGQ== X-Gm-Message-State: AOJu0Yzq/po87rhNUfjJpFWxE/g37ZBF5l5s3TTU4s5aWnLJLefxGiMb xKVV2AkA3EyY5PmGWzFEGSlHV/Weow0= X-Google-Smtp-Source: AGHT+IFv1kA5mU4QEM1UlgkU21V2gziSMKPMlCTNi0rs1stPl+e457LQoXEEVo2ACkgL7H8aiGsOeg== X-Received: by 2002:a50:9e2f:0:b0:54b:f6f7:9c4d with SMTP id z44-20020a509e2f000000b0054bf6f79c4dmr985149ede.38.1701445339673; Fri, 01 Dec 2023 07:42:19 -0800 (PST) Received: from nbbrfq.loc (80-110-214-113.static.upcbusiness.at. [80.110.214.113]) by smtp.gmail.com with ESMTPSA id t25-20020a05640203d900b0054b9c1f1b91sm1726190edw.25.2023.12.01.07.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 07:42:19 -0800 (PST) Date: Fri, 1 Dec 2023 16:42:15 +0100 From: Bernhard Reutner-Fischer To: jeffreyalaw@gmail.com Cc: rep.dot.nop@gmail.com, Roger Sayle , gcc-patches@gcc.gnu.org, 'Uros Bizjak' Subject: PING^3 Re: [i386 PATCH] A minor code clean-up: Use NULL_RTX instead of nullptr Message-ID: <20231201164215.01205662@nbbrfq.loc> In-Reply-To: <34A2CDCF-1427-4773-8269-E1D06FEE51E5@gmail.com> References: <07ac01d98e68$bced1fa0$36c75ee0$@nextmovesoftware.com> <20230525185804.7af6ea5e@nbbrfq.loc> <20230526103151.3a7f65d0@nbbrfq.loc> <34A2CDCF-1427-4773-8269-E1D06FEE51E5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 14 Jun 2023 21:14:02 +0200 Bernhard Reutner-Fischer wrote: > plonk. ping^3 patch at https://inbox.sourceware.org/gcc-patches/20230526103151.3a7f65d0@nbbrfq.loc/ I would regenerate it for rtx and/or tree, though, whatever you deem desirable? thanks > > On 26 May 2023 10:31:51 CEST, Bernhard Reutner-Fischer wrote: > >On Thu, 25 May 2023 18:58:04 +0200 > >Bernhard Reutner-Fischer wrote: > > > >> On Wed, 24 May 2023 18:54:06 +0100 > >> "Roger Sayle" wrote: > >> > >> > My understanding is that GCC's preferred null value for rtx is NULL_RTX > >> > (and for tree is NULL_TREE), and by being typed allows strict type checking, > >> > and use with function polymorphism and template instantiation. > >> > C++'s nullptr is preferred over NULL and 0 for pointer types that don't > >> > have a defined null of the correct type. > >> > > >> > This minor clean-up uses NULL_RTX consistently in i386-expand.cc. > >> > >> Oh. Well, i can't resist cleanups :) > > > >> (and handle nullptr too, and the same game for tree) > > > > so like the attached. And > > sed -e 's/RTX/TREE/g' -e 's/rtx/tree/g' \ > > < ~/coccinelle/gcc-rtx-null.0.cocci \ > > > ~/coccinelle/gcc-tree-null.0.cocci > > > > I do not know if we want to shorten explicit NULL comparisons. > > foo == NULL => !foo and foo != NULL => foo > > Left them alone in the form they were written. > > > > See the attached result of the rtx hunks, someone would have to build > > I've bootstrapped and regtested the hunks for rtx as cited up-thread without regressions (as expected). > > I know everybody is busy, but I'd like to know if I should swap these out completely, > or postpone this until start of stage3 or next stage 1 or something. > I can easily keep these local to my personal pre-configure stage for my own amusement. > > thanks, > > >it and hack git-commit-mklog.py --changelog 'Use NULL_RTX.' > >to print("{}.".format(random.choice(['Ditto', 'Same', 'Likewise']))) ;) > > > >> > >> Just a thought.. > > > >cheers, >