From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by sourceware.org (Postfix) with ESMTPS id CC0BD3858438 for ; Sat, 2 Dec 2023 06:37:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC0BD3858438 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CC0BD3858438 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701499063; cv=none; b=VqdzbXjWVolL0C1ZstWbg2NUiOTIgGowgFfj6NnXtHSfgKVt4OaW1m/I54GHzxVDtJcYO6tQ6p0BcdxBc5Vt0CFYBV05jnv753SJZ7mUiRSB+uAxLa5hHzONuSalwwUFFjCbZf9Hv9CCxJbVXFGqdVRvjEVdfHvYBTwp9yefTTI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701499063; c=relaxed/simple; bh=VOjpen+VWcrI2wRvRmh9vRe9ZXeZejnWRMOrbkKTXks=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kLdTGiz6T28/zD58GleXBxt3XozP92rICehOMMEdlgoLkc9WCD0sOCstv2Bv0LWoSvrLI9SMFIc35ct+ZjW0+AIT+LYbjtsj/0cuonaPgA3AXTfDyPvLI5MZTiYBhmPKKsA61UlY2VoUSgA2wHuWfdCqujQq3SVBnLv0//PG+wE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B26QtVX009545 for ; Sat, 2 Dec 2023 06:37:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=PoScawZgWxZHJwLV9dfNVh17XhS6ftuw30Y3VCee/Yo=; b=gS5m0tNBhET+AlMIzRJeCYv5Tn2g8OGONPVB/8CNPUd3gHu+LRGBdGiNz7EtjtAwnAoW FoJtM/etWjeYELyDdu3pNHhOa4peywp/ddYsWjmnqDftMDQcVtEQ2K8nMF613n8pfd0n Ut3JrCb8mydwCRyAqWmbSO8LizwHpNo9nuHtnYtD2xsdXjLkeoVPoqrjvg71MEmuWRqP OQMv8QxW5Nfa0EgyQr6mYTCWvHcTHhOZp9vKizOH5YMzlyUrd/Pa2s1oPaxv7CJPFGbN 7+v/K9JX4TUdSK8i2aaoOLrbzDWexVPB2uXGQqX6OtJ7lyFsCzflZHpxtC/Z6k34ORTl QQ== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3uqsxw0erw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 02 Dec 2023 06:37:42 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3B26bfNO021080 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 2 Dec 2023 06:37:41 GMT Received: from hu-apinski-lv.qualcomm.com (10.49.16.6) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 1 Dec 2023 22:37:40 -0800 From: Andrew Pinski To: Subject: [PATCH 2/3] Remove check of unsigned_char in maybe_undo_optimize_bit_field_compare. Date: Fri, 1 Dec 2023 22:37:24 -0800 Message-ID: <20231202063725.3405094-3-quic_apinski@quicinc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231202063725.3405094-1-quic_apinski@quicinc.com> References: <20231202063725.3405094-1-quic_apinski@quicinc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: FJYv7g8MDA2qx0CdGnJWMlFGatAmYjl4 X-Proofpoint-GUID: FJYv7g8MDA2qx0CdGnJWMlFGatAmYjl4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-02_04,2023-11-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 mlxscore=0 bulkscore=0 spamscore=0 clxscore=1015 priorityscore=1501 mlxlogscore=697 malwarescore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2312020047 X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Andrew Pinski The check for the type seems unnecessary and gets in the way sometimes. Also with a patch I am working on for match.pd, it causes a failure to happen. Before my patch the IR was: _1 = BIT_FIELD_REF ; _2 = _1 & 1; _3 = _2 != 0; _4 = (int) _3; __analyzer_eval (_4); Where _2 was an unsigned char type. And After my patch we have: _1 = BIT_FIELD_REF ; _2 = (int) _1; _3 = _2 & 1; __analyzer_eval (_3); But in this case, the BIT_AND_EXPR is in an int type. OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. gcc/analyzer/ChangeLog: * region-model-manager.cc (maybe_undo_optimize_bit_field_compare): Remove the check for type being unsigned_char_type_node. --- gcc/analyzer/region-model-manager.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/gcc/analyzer/region-model-manager.cc b/gcc/analyzer/region-model-manager.cc index 921edc55868..9a17b9d2878 100644 --- a/gcc/analyzer/region-model-manager.cc +++ b/gcc/analyzer/region-model-manager.cc @@ -586,9 +586,6 @@ maybe_undo_optimize_bit_field_compare (tree type, tree cst, const svalue *arg1) { - if (type != unsigned_char_type_node) - return NULL; - const binding_map &map = compound_sval->get_map (); unsigned HOST_WIDE_INT mask = TREE_INT_CST_LOW (cst); /* If "mask" is a contiguous range of set bits, see if the -- 2.39.3