From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 36CCF3858C5E for ; Mon, 4 Dec 2023 10:35:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 36CCF3858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 36CCF3858C5E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701686142; cv=none; b=UgAoKW0Ruv8K/ZwWg0XkfrOzpAY/aj+KtGY+ICBPjPHwoWSJq/mMcbjUFbT87YtCTwU6a/OP8aRwDluYSljTDtrJxhArQHzcZvreWDQ05e1R8zgxB2sgvDdZixrY+YFTOHihml9/1X0zLE80HE34q43te9wFu5PdNiL9vA6Dwao= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701686142; c=relaxed/simple; bh=9YzEkfShr2ML8FMrGFl9J99Ewa51o19AzXNBz4M+zcQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=v3URStP0wkCvI5kgFNlVYGelEFEMCPcpvMFAi0PTRmqkXuLOCLfKGnFh5eJYoyUGyjaZBhW86canSuyNLxFxZcrYMbqV8PTVKko7axnvuEuFTgwzKBlVT+NOYEROP28/40joe9gDdSrfexLbm/WICqs+Zy+yBUiNmGxZdG4GTPA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40b27726369so43740845e9.0 for ; Mon, 04 Dec 2023 02:35:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1701686130; x=1702290930; darn=gcc.gnu.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WmCbqRMtrWXsWUugYCS6Z601u9wN1HyZY5TfkYQHg8k=; b=IpaqC7m1EUtUszy2/ETnmrN6v0+7ZqZ7trXnBZdULUyLrE/9fZ6Ky0wDknkOTepbA1 j7BV7eTgr8fb2Cze4soSPp/hkUackO9NzUjlye6rQ8u6otg2KP3Cln0z6yvTKBae58a0 OFYbwwQ3TtaMEPBQcu2imdAC4zeTqWu/wgf8WFUn/VNLYEVsqB+Sy02xgklyIXFN46lL MEpWklX3WZlbb9R4ct35QnknjZXyl5g5DiYZDAf+fazUJTS7EczrWFnQcNEPfkgp2pdq i0BQqM1QU+aEeV7DVI94kNrjtxnizLUqkBXJAZBLu4Fkuqxqxfmhtv2q+1Ts2dk2C5Ev TuBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701686130; x=1702290930; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WmCbqRMtrWXsWUugYCS6Z601u9wN1HyZY5TfkYQHg8k=; b=LtFyuIverGXWUgkkpaifXM0ddsIenyd/QR1qRy/ipOTpcwmevijyfh4tLW1wfiY1aE FssP4EsGQddcgsNJRofiL/MNFwTeDmlJ1HYimV/lKcg2y66/bAYiAz9ZXB2zApokzKqz U08wRGC4LWK1VbBgMDws8FqwT09LjfJyOlhEtz/qCUeP6NiyXTXaERUbqPLQKDJRraLb HjcM2kAaVVd04UkXtL9+IxOJ2gC+t9HsTs3uI6PM8DC5Ylr6FKHnxmyFMu7ASDxlvhxD oZ0zxk1AJnoBJ49D6+47IR8TqN2EM7VQLiG0dFqnl0awtSOoHFWNtw2eqUr88qaCYmrU VjDw== X-Gm-Message-State: AOJu0Yw/+m4vKo4nBNvqx1YuuHRK13Sl++KyK/QTpsH27xpwSfdvR8pv gvc4UWWBQW+efVLYYcpG/2/huUsD8pxrYLPxkL7IcA== X-Google-Smtp-Source: AGHT+IHeLCLuI5HtCL0vLrQAnYgLDc2n4devmq3iDjSetMqSur2dqWWzxF+sZJAipMuHYmQt2oQ0cg== X-Received: by 2002:a05:600c:44c9:b0:40b:5e59:daa0 with SMTP id f9-20020a05600c44c900b0040b5e59daa0mr2315072wmo.179.1701686130593; Mon, 04 Dec 2023 02:35:30 -0800 (PST) Received: from localhost ([45.147.211.82]) by smtp.gmail.com with ESMTPSA id bg36-20020a05600c3ca400b003fe1fe56202sm14715429wmb.33.2023.12.04.02.35.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 02:35:30 -0800 (PST) Date: Mon, 4 Dec 2023 10:35:30 +0000 From: Arnaud Charlet To: Rainer Orth Cc: gcc-patches@gcc.gnu.org, Arnaud Charlet , Marc Poulhi??s Subject: Re: [PATCH] ada: Fix Ada bootstrap on Solaris Message-ID: <20231204103530.GA33733@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > The recent warning patches broke Ada bootstrap on Solaris: > > adaint.c: In function '__gnat_kill': > adaint.c:3597:3: error: implicit declaration of function 'kill' [-Wimplicit-function-declaration] > 3597 | kill (pid, sig); > | ^~~~ > > expect.c: In function '__gnat_expect_poll': > expect.c:409:5: error: implicit declaration of function 'memset' [-Wimplicit-function-declaration] > 409 | FD_ZERO (&rset); > | ^~~~~~~ > expect.c:55:1: note: include '' or provide a declaration of 'memset' > 54 | #include > +++ |+#include > 55 | #endif > > I'm now including the necessary headers: for kill and > for memset. However, I found the GNAT C sources to be an > incredible and hard to untangle maze: instead of using autoconf, they > are generously sprinkled with deeply nested platform macros, so I may > well have included the headers in an inappropriate place. > > Bootstrapped without regressions on i386-pc-solaris2.11, > sparc-sun-solaris2.11, x86_64-pc-linux-gnu, and > x86_64-apple-darwin23.1.0. > > Ok for trunk? OK, thanks.