From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2055.outbound.protection.outlook.com [40.107.22.55]) by sourceware.org (Postfix) with ESMTPS id 36EE73858282 for ; Thu, 7 Dec 2023 16:33:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 36EE73858282 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 36EE73858282 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.55 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701966838; cv=pass; b=VewXZvAnh2/Q8CLRrEcb368f98e03ujmYVHQbOvZz5lBkMXEWk///45/8LCoLT9Y7jFuXm5vN3HQz4FDuZcKKjjOKk8mJEkeY8Be5mf/6Gc9FMJPWT2sLCB+4ljCyP+R/KL3a3ZtbMVacWHOy7udVGnDWB5jJJCnpVaR2LceVB8= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701966838; c=relaxed/simple; bh=RwMO094YCVUX5QJlTjk5zf6UFhqK+n+jpcWk+/+s/SY=; h=DKIM-Signature:From:To:Subject:MIME-Version:Message-ID:Date; b=v2LWTXgLAVfPSGIYh2Fo/sZqvFm033se2CSpp9r+K1vT+bxUYoUy25AofdnCYrKGQvcxD4HaF4Z4ogJDfexILpUSvzbvIsnjGL4gNQFfaJhuKDzl/J9owiZkvzYxO4APfQkeSlw3uD+a6FoJAdP/vWwpylXFMcvGra0BhCfsn6Y= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LzHF4hNUYdZ5Dvxr+EBZT30vOK/S2ZkRl9vK4xgB3r7kmSGkmOXXCHe4mHA/HzFXPbFXn6q83IWkk1jAmWB1WdnGYxjWAuCZ1Gru1p7qQGgJkeQnyKJhyPLuqr/ZQW5n0LsvvciB/epSf9O4bnKurjJyqmDmEGlQhmkm5lC9APNr7PrDvmQvJIxHX4G2u28reCeSlm8T8EQyS7UXdoK9gk41joVNwpIzFmgiNck70BgctOzlJLRVWHuZODIPHLfXQnjfY5HPUIdNWXVyhI8dQnZQAYDjaXvqegmZU0mUT+G6fwQ+ck1j90UpUjEMZneL0y9zdpDfpfHVW3d0+8/s1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VKrzceexFOnELqV6Tge2bP7EP2ghRpt6ONKoKDTZNQY=; b=Pg6qNPJZv2pEwUZAlFbsUd17dsKlY3tDJ98LFN/2JKhYvo/lnpkKckgUh8aEAH1VseOzhYrNVMAuv0lCHiFz74friqJ7l9Eisq50IZW6gU9olbENJNWP1GynGGTswRLFh9D8MR65jmt9VnI1+EDA9eS2uoTNNbBDrDQYiubdfUZcUvqbDx37r67n0cB34PCtkT4dZ1nHVMbqxoW6E7ugYNRa47SKRJTY+lTTtOKuR24n+jyPBIz91iCuwv8eHPvVavOREN/cJHMlofmLxFK9I7zpWgRDsq7hVIJZEcPrCgMRW563C1YdMxR/+SD5lT4HUzB85jheMipKU0Y+3wTdvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 195.60.68.100) smtp.rcpttodomain=adacore.com smtp.mailfrom=axis.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=axis.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VKrzceexFOnELqV6Tge2bP7EP2ghRpt6ONKoKDTZNQY=; b=AwhaQtRHcog8CU7fWD9RR93dMG1QXku+qiA7e3rJDaiWhWTmgLWgoTFJwl0V4XIhmBVqzZYaceEgVSGV11hOPFFFY+gO/CZ0zOSJHfH3TFC4nECuBW2VYWkF5kq1aVRSXwIv3X7hG19KwITS0P9tl82PXQ5BnHUwwrxy6nYwvX4= Received: from AM0PR02CA0109.eurprd02.prod.outlook.com (2603:10a6:20b:28c::6) by PA6PR02MB10540.eurprd02.prod.outlook.com (2603:10a6:102:3d2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Thu, 7 Dec 2023 16:33:45 +0000 Received: from AM3PEPF0000A796.eurprd04.prod.outlook.com (2603:10a6:20b:28c:cafe::6c) by AM0PR02CA0109.outlook.office365.com (2603:10a6:20b:28c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.25 via Frontend Transport; Thu, 7 Dec 2023 16:33:45 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 195.60.68.100) smtp.mailfrom=axis.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=axis.com; Received-SPF: Fail (protection.outlook.com: domain of axis.com does not designate 195.60.68.100 as permitted sender) receiver=protection.outlook.com; client-ip=195.60.68.100; helo=mail.axis.com; Received: from mail.axis.com (195.60.68.100) by AM3PEPF0000A796.mail.protection.outlook.com (10.167.16.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7068.20 via Frontend Transport; Thu, 7 Dec 2023 16:33:45 +0000 Received: from se-mail01w.axis.com (10.20.40.7) by se-mail02w.axis.com (10.20.40.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 7 Dec 2023 17:33:45 +0100 Received: from se-intmail01x.se.axis.com (10.0.5.60) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 7 Dec 2023 17:33:45 +0100 Received: from pchp3.se.axis.com (pchp3.se.axis.com [10.88.21.53]) by se-intmail01x.se.axis.com (Postfix) with ESMTP id 1EA87F72C; Thu, 7 Dec 2023 17:33:45 +0100 (CET) Received: by pchp3.se.axis.com (Postfix, from userid 171) id 1A90A2041E; Thu, 7 Dec 2023 17:33:45 +0100 (CET) From: Hans-Peter Nilsson To: Richard Biener CC: , , , , , In-Reply-To: <198q96q6-9os5-o2ro-9559-5875n86495r2@fhfr.qr> (message from Richard Biener on Mon, 4 Dec 2023 12:58:03 +0100 (CET)) Subject: Re: [PATCH] testsuite: scev: expect fail on ilp32 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <6f1516e7-f4be-4e13-b04c-8b5c31cae4f7@gmail.com> <20231129180047.1334620430@pchp3.se.axis.com> <20231130170910.5B7C720442@pchp3.se.axis.com> <20231201033538.87F472042C@pchp3.se.axis.com> <5ro82896-4qq5-po26-12p5-97rnnoo31p37@fhfr.qr> <20231201231831.4238420424@pchp3.se.axis.com> <198q96q6-9os5-o2ro-9559-5875n86495r2@fhfr.qr> Message-ID: <20231207163345.1A90A2041E@pchp3.se.axis.com> Date: Thu, 7 Dec 2023 17:33:45 +0100 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM3PEPF0000A796:EE_|PA6PR02MB10540:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ee93836-7b8b-488a-3a1c-08dbf742484a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J3aR1UNuxyZOKpALbo4A74OXGUGG8SAoxyS/MnKUFYE0jBG7RLb/il1C4ihUgpwthepUc/CLMOTfpF1vsCBnz/5Q3Z6gZcYgxNUiYkCuAsQP/3sc6m9Ue7IY//70i08ZrpblLlZTGjIN7X458yi30VF4RIFXEQxn8um5rMI9fEoOTKbG4JBRFHN86DYIwrvdePizEKf94WEDy6frWf7JTC9okdnynpYkDUjdf8p8ZeA294mUWnYPZf4IKfPitfgIYRSnhXAKjTG7yx0Ywuyn2iF24x9PL3/F4WZryRzRESlSxiw5D2ekEwq3nwT8ViWcb8EKBAe/ZAPTiLQ5qRmEga+HDxGoDSX+hajgfsSXcc1raJ+2sXzSz5EM3O6U/G1yN5LbCSb+o2w7GabCG+OFjOQ6fmXz8ishu5uN4rdR6D+z2pMzoJM2pfC93hFTjfFMQxl2ESWVnUxLw2Ix+RxbFDDJffwXPAAsuS+8dy0YhHkBh1Vegacfu2RPXyNlvvgtqRklV5jVx/ioA4zgWDV/1tPQHSDesOOI4BMX/ctTEl89bch8irPUE7K5kxkVcyKRWffWr9AwUhnjGinVD4Ow/Wvj/BE3+7i5Foak8DtO/NWSXBuP+KBdscffLFFVxy5zQseRXthVJTkeM+zbMbtVL5I+PCtG5+syWP++ZENX4YOcfTqYmKtTNY+8b1LUMqRwgcWqNxGWBMAWFQR0dfXNISGeOz/7K4UyU7B5eRKAP0k4ZOYSR0wSasxbPXOAWWEgrfcZDd/ng/T/lORqKAnXkA== X-Forefront-Antispam-Report: CIP:195.60.68.100;CTRY:SE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.axis.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(136003)(376002)(396003)(39860400002)(346002)(230922051799003)(451199024)(186009)(1800799012)(64100799003)(82310400011)(40470700004)(46966006)(36840700001)(40460700003)(54906003)(8676002)(316002)(6916009)(42186006)(8936002)(4326008)(478600001)(70206006)(70586007)(83380400001)(5660300002)(2906002)(33656002)(81166007)(356005)(47076005)(26005)(41300700001)(1076003)(82740400003)(36860700001)(426003)(6266002)(336012)(84970400001)(40480700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: axis.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 16:33:45.5470 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ee93836-7b8b-488a-3a1c-08dbf742484a X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=78703d3c-b907-432f-b066-88f7af9ca3af;Ip=[195.60.68.100];Helo=[mail.axis.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A796.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR02MB10540 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Mon, 4 Dec 2023 12:58:03 +0100 (CET) > From: Richard Biener > On Sat, 2 Dec 2023, Hans-Peter Nilsson wrote: > > > Date: Fri, 1 Dec 2023 08:07:14 +0100 (CET) > > > From: Richard Biener > > > I read from your messages that the testcases pass on arm*-*-*? > > Yes: they pass (currently XPASS) on arm-eabi and > > arm-unknown-linux-gnueabi, default configurations. But, > > scev-3 and -5 fail with for example -mcpu=cortex-r5 > > I see. As said, the testcases test for "cost" things, so that we > "regressed" might mean we really "regressed" here. Even the x86 -m32 > result is questionable. > > Of course whether using a single IV makes sense for all archs is > unknown. > > Btw, if we turn the testcases into ones that are (sub-)target > specific then we want to again use C code as input. > > I think at this point we've lost track and I'm juggling between > removing the testcases or moving them to a place they succeed > (with some specific -mcpu=?) > > Richard. So to not drop the ball(s) on this, here's a patch with your first alternative: remove them. Ok? -- >8 -- Subject: [PATCH] testsuite: Remove gcc.dg/tree-ssa/scev-3.c -4.c and 5.c These tests were recently xfailed on ilp32 targets though passing on almost all ilp32 targets (known exceptions: ia32 and some arm subtargets). They've been changed around too much to remain useful. PR testsuite/112786 * gcc.dg/tree-ssa/scev-3.c, gcc.dg/tree-ssa/scev-4.c, gcc.dg/tree-ssa/scev-5.c: Remove. --- gcc/testsuite/gcc.dg/tree-ssa/scev-3.c | 44 ----------------------- gcc/testsuite/gcc.dg/tree-ssa/scev-4.c | 49 -------------------------- gcc/testsuite/gcc.dg/tree-ssa/scev-5.c | 44 ----------------------- 3 files changed, 137 deletions(-) delete mode 100644 gcc/testsuite/gcc.dg/tree-ssa/scev-3.c delete mode 100644 gcc/testsuite/gcc.dg/tree-ssa/scev-4.c delete mode 100644 gcc/testsuite/gcc.dg/tree-ssa/scev-5.c diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c deleted file mode 100644 index beea9aed9fe9..000000000000 --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c +++ /dev/null @@ -1,44 +0,0 @@ -/* { dg-do compile } */ -/* { dg-options "-O2 -fgimple -fdump-tree-ivopts" } */ - -int *a_p; -int a[1000]; - -void __GIMPLE (ssa,startwith ("loop")) -f (int k) -{ - int i; - int * _1; - -__BB(2): - i_5 = k_4(D); - if (i_5 <= 999) - goto __BB4; - else - goto __BB3; - -__BB(3): - return; - -__BB(4): - goto __BB5; - -__BB(5): - i_12 = __PHI (__BB6: i_9, __BB4: i_5); - _1 = &a[i_12]; - a_p = _1; - __MEM ((int *)&a)[i_12] = 100; - i_9 = i_5 + i_12; - if (i_9 <= 999) - goto __BB6; - else - goto __BB3; - -__BB(6): - ; - goto __BB5; - -} - -/* Not all 32-bit systems fail this, but several do. */ -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c deleted file mode 100644 index a97f75f81f65..000000000000 --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c +++ /dev/null @@ -1,49 +0,0 @@ -/* { dg-do compile } */ -/* { dg-options "-O2 -fgimple -fdump-tree-ivopts" } */ - -typedef struct { - int x; - int y; -} S; - -int *a_p; -S a[1000]; - -void __GIMPLE (ssa, startwith ("loop")) -f (int k) -{ - int i; - int * _1; - -__BB(2): - i_5 = k_4(D); - if (i_5 <= 999) - goto __BB4; - else - goto __BB3; - -__BB(3): - return; - -__BB(4): - goto __BB5; - -__BB(5): - i_12 = __PHI (__BB6: i_9, __BB4: i_5); - _1 = &a[i_12].y; - a_p = _1; - __MEM ((int *)&a)[i_12].y = 100; - i_9 = i_5 + i_12; - if (i_9 <= 999) - goto __BB6; - else - goto __BB3; - -__BB(6): - ; - goto __BB5; - -} - -/* Not all 32-bit systems fail this, but several do. */ -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c deleted file mode 100644 index 08f4260403c4..000000000000 --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c +++ /dev/null @@ -1,44 +0,0 @@ -/* { dg-do compile } */ -/* { dg-options "-O2 -fgimple -fdump-tree-ivopts" } */ - -int *a_p; -int a[1000]; - -void __GIMPLE (ssa,startwith ("loop")) -f (int k) -{ - long long int i; - int * _1; - -__BB(2): - i_5 = (long long int) k_4(D); - if (i_5 <= 999ll) - goto __BB4; - else - goto __BB3; - -__BB(3): - return; - -__BB(4): - goto __BB5; - -__BB(5): - i_12 = __PHI (__BB6: i_9, __BB4: i_5); - _1 = &a[i_12]; - a_p = _1; - __MEM ((int *)&a)[i_12] = 100; - i_9 = i_5 + i_12; - if (i_9 <= 999ll) - goto __BB6; - else - goto __BB3; - -__BB(6): - ; - goto __BB5; - -} - -/* Not all 32-bit systems fail this, but several do. */ -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */ -- 2.30.2