From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) by sourceware.org (Postfix) with ESMTPS id C41653858415 for ; Tue, 12 Dec 2023 12:08:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C41653858415 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=iscas.ac.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C41653858415 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702382917; cv=none; b=J7IMWQIIpPSdOWTL8y2JSQW9wV3yIACO0aQt73OkUzv75pujfi8vdGr+KivmZCgZpMtJ5h/HMyqemggokiY4VMUXiBgUEsPlyx2+otYbv5i1XYZPGvhFosj1AZ5uOFhk/2KXiVxtZJVUb+pC5jT/Opw5SbDfPj8ggtkPVpfKVNo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702382917; c=relaxed/simple; bh=1A/DVVZhDbvq5ztwbHQahw59YF+9bOuBtKyB2XeHOFc=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=q5/mDL9IyemMNiiqu0g/7f0yaXmjFUb/vP7+NmslYPz9zrWgS259cv9nyeG0neiu7o2VVt8rLr+1elIkktcPxqbJGcgeU0T5lSKoxv5JU42HObsreYOtQrdTVbBS4oKG5EO53rzxgbsufVhaT6GR8tGGQtrUXQrkOtPRP7pUQjM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from localhost.localdomain (unknown [47.113.87.88]) by APP-03 (Coremail) with SMTP id rQCowAA3r8Q3TXhlulW2AA--.46494S2; Tue, 12 Dec 2023 20:08:24 +0800 (CST) From: Jiawei To: gcc-patches@gcc.gnu.org Cc: kito.cheng@sifive.com, palmer@dabbelt.com, jeffreyalaw@gmail.com, christoph.muellner@vrull.eu, Jiawei Subject: [PATCH v2] RISC-V: Supports RISC-V Profiles in '-march' option. Date: Tue, 12 Dec 2023 20:08:09 +0800 Message-Id: <20231212120809.13996-1-jiawei@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:rQCowAA3r8Q3TXhlulW2AA--.46494S2 X-Coremail-Antispam: 1UD129KBjvJXoW3Gr4UJFy8AFWkZF1kGr1xKrg_yoW3AFykpF W5Aws0krZ5JFZ7Wrn3KFy7Ww43KrsIgrWYvwn29ry7A39xJrWYq3WkKw1SkF15JF48ur12 9F4j9ryFvw4UX3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUyv14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r1j6r1xM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCF04k20xvY0x0EwIxG rwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4 vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IY x2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26c xKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAF wI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7VUbrMaUUUUUU== X-Originating-IP: [47.113.87.88] X-CM-SenderInfo: 5mld4v3l6l2u1dvotugofq/1tbiCgcDAGV4H6SMggABsn X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Supports RISC-V profiles[1] in -march option. Default input set the profile is before other formal extensions. V2: Fixes some format errors and adds code comments for parse function Thanks for Jeff Law's review and comments. [1]https://github.com/riscv/riscv-profiles/blob/main/profiles.adoc gcc/ChangeLog: * common/config/riscv/riscv-common.cc (struct riscv_profiles): New struct. (riscv_subset_list::parse_profiles): New function. (riscv_subset_list::parse): New table. * config/riscv/riscv-subset.h: New protype. gcc/testsuite/ChangeLog: * gcc.target/riscv/arch-31.c: New test. * gcc.target/riscv/arch-32.c: New test. * gcc.target/riscv/arch-33.c: New test. * gcc.target/riscv/arch-34.c: New test. --- gcc/common/config/riscv/riscv-common.cc | 83 +++++++++++++++++++++++- gcc/config/riscv/riscv-subset.h | 2 + gcc/testsuite/gcc.target/riscv/arch-31.c | 5 ++ gcc/testsuite/gcc.target/riscv/arch-32.c | 5 ++ gcc/testsuite/gcc.target/riscv/arch-33.c | 5 ++ gcc/testsuite/gcc.target/riscv/arch-34.c | 7 ++ 6 files changed, 106 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/riscv/arch-31.c create mode 100644 gcc/testsuite/gcc.target/riscv/arch-32.c create mode 100644 gcc/testsuite/gcc.target/riscv/arch-33.c create mode 100644 gcc/testsuite/gcc.target/riscv/arch-34.c diff --git a/gcc/common/config/riscv/riscv-common.cc b/gcc/common/config/riscv/riscv-common.cc index 4d5a2f874a2..8b674a4a280 100644 --- a/gcc/common/config/riscv/riscv-common.cc +++ b/gcc/common/config/riscv/riscv-common.cc @@ -195,6 +195,12 @@ struct riscv_ext_version int minor_version; }; +struct riscv_profiles +{ + const char *profile_name; + const char *profile_string; +}; + /* All standard extensions defined in all supported ISA spec. */ static const struct riscv_ext_version riscv_ext_version_table[] = { @@ -379,6 +385,42 @@ static const struct riscv_ext_version riscv_combine_info[] = {NULL, ISA_SPEC_CLASS_NONE, 0, 0} }; +/* This table records the mapping form RISC-V Profiles into march string. */ +static const riscv_profiles riscv_profiles_table[] = +{ + /* RVI20U only contains the base extesnion 'i' as mandatory extension. */ + {"RVI20U64", "rv64i"}, + {"RVI20U32", "rv32i"}, + + /* RVA20U contains the 'i,m,a,f,d,c,zicsr' as mandatory extensions. + Currently we don't have zicntr,ziccif,ziccrse,ziccamoa, + zicclsm,za128rs yet. */ + {"RVA20U64", "rv64imafdc_zicsr"}, + + /* RVA20S64 mandatory include all the extensions in RVA20U64 and + additonal 'zifencei' as mandatory extensions. + Notes that ss1p11, svbare, sv39, svade, sscptr, ssvecd, sstvala should + control by binutils. */ + {"RVA20S64", "rv64imafdc_zicsr_zifencei"}, + + /* RVA22U contains the 'i,m,a,f,d,c,zicsr,zihintpause,zba,zbb,zbs, + zicbom,zicbop,zicboz,zfhmin,zkt' as mandatory extensions. + Currently we don't have zicntr,zihpm,ziccif,ziccrse,ziccamoa, + zicclsm,zic64b,za64rs yet. */ + {"RVA22U64", "rv64imafdc_zicsr_zihintpause_zba_zbb_zbs" \ + "_zicbom_zicbop_zicboz_zfhmin_zkt"}, + + /* RVA22S64 mandatory include all the extensions in RVA22U64 and + additonal 'zifencei,svpbmt,svinval' as mandatory extensions. + Notes that ss1p12, svbare, sv39, svade, sscptr, ssvecd, sstvala, + scounterenw extentions should control by binutils. */ + {"RVA22S64","rv64imafdc_zicsr_zifencei_zihintpause" \ + "_zba_zbb_zbs_zicbom_zicbop_zicboz_zfhmin_zkt_svpbmt_svinval"}, + + /* Terminate the list. */ + {NULL, NULL} +}; + static const riscv_cpu_info riscv_cpu_tables[] = { #define RISCV_CORE(CORE_NAME, ARCH, TUNE) \ @@ -958,6 +1000,42 @@ riscv_subset_list::parsing_subset_version (const char *ext, return p; } +/* Parsing RISC-V Profiles in -march string. + Return string with mandatory extensions of Profiles. */ +const char * +riscv_subset_list::parse_profiles (const char * p){ + /* Checking if input string contains a Profiles. + There are two cases use Proifles in -march option + + 1. Only use Proifles as -march input + 2. Mixed Profiles with other extensions + + use '+' to split Profiles and other extension. */ + for (int i = 0; riscv_profiles_table[i].profile_name != NULL; ++i) { + const char* match = strstr(p, riscv_profiles_table[i].profile_name); + const char* plus_ext = strchr(p, '+'); + /* Find profile at the begin. */ + if (match != NULL && match == p) { + /* If there's no '+' sign, return the profile_string directly. */ + if(!plus_ext) + return riscv_profiles_table[i].profile_string; + /* If there's a '+' sign, need to add profiles with other ext. */ + else { + size_t arch_len = strlen(riscv_profiles_table[i].profile_string)+ + strlen(plus_ext); + /* Reset the input string with Profiles mandatory extensions, + end with '_' to connect other additional extensions. */ + static char* result = new char[arch_len + 2]; + strcpy(result, riscv_profiles_table[i].profile_string); + strcat(result, "_"); + strcat(result, plus_ext + 1); /* skip the '+'. */ + return result; + } + } + } + return p; +} + /* Parsing function for standard extensions. Return Value: @@ -1486,7 +1564,10 @@ riscv_subset_list::parse (const char *arch, location_t loc) riscv_subset_list *subset_list = new riscv_subset_list (arch, loc); riscv_subset_t *itr; + const char *p = arch; + p = subset_list->parse_profiles(p); + if (startswith (p, "rv32")) { subset_list->m_xlen = 32; @@ -1499,7 +1580,7 @@ riscv_subset_list::parse (const char *arch, location_t loc) } else { - error_at (loc, "%<-march=%s%>: ISA string must begin with rv32 or rv64", + error_at (loc, "%<-march=%s%>: ISA string must begin with rv32, rv64 or a profile", arch); goto fail; } diff --git a/gcc/config/riscv/riscv-subset.h b/gcc/config/riscv/riscv-subset.h index ad1cab2aa24..ba991f67014 100644 --- a/gcc/config/riscv/riscv-subset.h +++ b/gcc/config/riscv/riscv-subset.h @@ -76,6 +76,8 @@ private: const char *parse_single_multiletter_ext (const char *, const char *, const char *); + const char *parse_profiles (const char*); + void handle_implied_ext (const char *); bool check_implied_ext (); void handle_combine_ext (); diff --git a/gcc/testsuite/gcc.target/riscv/arch-31.c b/gcc/testsuite/gcc.target/riscv/arch-31.c new file mode 100644 index 00000000000..eb24abe4153 --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/arch-31.c @@ -0,0 +1,5 @@ +/* { dg-do compile } */ +/* { dg-options "-march=RVI20U64 -mabi=lp64" } */ +int foo() +{ +} diff --git a/gcc/testsuite/gcc.target/riscv/arch-32.c b/gcc/testsuite/gcc.target/riscv/arch-32.c new file mode 100644 index 00000000000..bc556a3e717 --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/arch-32.c @@ -0,0 +1,5 @@ +/* { dg-do compile } */ +/* { dg-options "-march=RVI20U64+mafdc -mabi=lp64d" } */ +int foo() +{ +} diff --git a/gcc/testsuite/gcc.target/riscv/arch-33.c b/gcc/testsuite/gcc.target/riscv/arch-33.c new file mode 100644 index 00000000000..a7b80a5ad43 --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/arch-33.c @@ -0,0 +1,5 @@ +/* { dg-do compile } */ +/* { dg-options "-march=RVA22S64 -mabi=lp64d" } */ +int foo() +{ +} diff --git a/gcc/testsuite/gcc.target/riscv/arch-34.c b/gcc/testsuite/gcc.target/riscv/arch-34.c new file mode 100644 index 00000000000..d077aba4fc2 --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/arch-34.c @@ -0,0 +1,7 @@ +/* { dg-do compile } */ +/* { dg-options "-march=rv64gcRVA22S64 -mabi=lp64d" } */ +int foo() +{ +} + +/* { dg-error "ISA string must begin with rv32, rv64 or a profile" "" { target *-*-* } 0 } */ -- 2.25.1