From: Edwin Lu <ewlu@rivosinc.com>
To: gcc-patches@gcc.gnu.org
Cc: gnu-toolchain@rivosinc.com, kito.cheng@gmail.com,
jeffreyalaw@gmail.com, Edwin Lu <ewlu@rivosinc.com>
Subject: [PATCH 0/3][RFC] RISC-V: Associate typed insns to dfa reservation
Date: Fri, 15 Dec 2023 10:53:25 -0800 [thread overview]
Message-ID: <20231215185328.794425-1-ewlu@rivosinc.com> (raw)
This series is a prototype for adding all typed instructions to a dfa
scheduling pipeline.
I've been working on adding insn reservations for all typed instructions
to ensure all instructions are part of a dfa pipeline. I don't have a good
understanding of vector instruction latency, so I have been struggling
with what I should do for those.
As of right now, I have copied the insn reservations from generic-ooo.md
for vector instructions into the generic.md and sifive-7.md files. This
prevents ICEs from enabling the assert but introduces numerous scan
dump failures (when tested in linux rv64gcv and rv64gc_zba_zbb_zbc_zbs).
Currently, only patch 1/3 RISC-V: Add non-vector types to pipelines does
not introduce regressions (when tested against linux rv32/64 gc/gcv
on rocket). I hope that the locations I added the insn types make sense.
Please let me know if they should change.
The final patch enables the assert for insn_has_dfa_reservation.
I tested the full patch series on both rocket and sifive-7-series. The
series does introduce additional scan dump failures compared to their
respective baselines, however, I'm not sure how many failures were
due to the patch vs incorrect modeling assumptions. I created
PR113035 which has the full testsuite failures I saw (without the patches
applied).
Edwin Lu (3):
RISC-V: Add non-vector types to pipelines
RISC-V: Add vector related reservations
RISC-V: Enable assert for insn_has_dfa_reservation
gcc/config/riscv/generic-ooo.md | 31 ++++----
gcc/config/riscv/generic.md | 131 +++++++++++++++++++++++++++++++-
gcc/config/riscv/riscv.cc | 2 -
gcc/config/riscv/sifive-7.md | 130 ++++++++++++++++++++++++++++++-
4 files changed, 271 insertions(+), 23 deletions(-)
--
2.34.1
next reply other threads:[~2023-12-15 18:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 18:53 Edwin Lu [this message]
2023-12-15 18:53 ` [PATCH 1/3][RFC] RISC-V: Add non-vector types to pipelines Edwin Lu
2023-12-20 18:50 ` Jeff Law
2023-12-20 22:11 ` Edwin Lu
2023-12-20 22:11 ` Edwin Lu
2023-12-21 6:59 ` Jeff Law
2023-12-15 18:53 ` [PATCH 2/3][RFC] RISC-V: Add vector related reservations Edwin Lu
2023-12-20 18:57 ` Jeff Law
2023-12-20 22:55 ` Edwin Lu
2023-12-20 22:55 ` Edwin Lu
2023-12-26 21:21 ` Edwin Lu
2023-12-15 18:53 ` [PATCH 3/3][RFC] RISC-V: Enable assert for insn_has_dfa_reservation Edwin Lu
2023-12-20 18:57 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231215185328.794425-1-ewlu@rivosinc.com \
--to=ewlu@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
--cc=jeffreyalaw@gmail.com \
--cc=kito.cheng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).