From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id 19A1A3858D39 for ; Thu, 28 Dec 2023 20:31:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 19A1A3858D39 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 19A1A3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=116.202.254.214 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703795512; cv=none; b=BKn9HOVBbf1cuKdCDCr2HbIMrCcrFBQCLG+ctHGTiM739L6xEE+yMAAF9+WLB7gBs3F8JGr7HiER+6n6gIw0JyFvnVG1tL13gkPfpvqN7mIljrcV6m18bS81HNFPOiHuowaZIiwO2rUyGb4Xn9rRoSIm3M9wTS/3Gbd4PiQ/nPo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703795512; c=relaxed/simple; bh=XXOEEGXgZdbrIRLluVrDroDhkMHhqJdCma/32O5f0IU=; h=To:From:Subject:Date:Message-ID:Mime-Version; b=kRG3jHHEdDo9Vye66vUI7Q6abkpHTtl+zy02FAZdbbT+KvX7D7OH48qtshfTbPuT+nlidYP32MFrohNRE4gEEd1UVvuh/s6//1cZhQ6aFOHCmw/dVEVM17gpODUwnWFoL0+7HB9rAPx144MxOqJi8HZVjXtJMbZajr498cmuyEM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rIx2j-0003BP-AV for gcc-patches@gcc.gnu.org; Thu, 28 Dec 2023 21:31:49 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Harald Anlauf Subject: Re: Fortran: Use non conflicting file extensions for intermediates [PR81615] Date: Thu, 28 Dec 2023 21:31:42 +0100 Message-ID: References: <295e0172-68b9-4b05-bded-95c418b690fa@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla Thunderbird Content-Language: en-US In-Reply-To: Cc: fortran@gcc.gnu.org X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20231228203142.eJDf90mpdodtdo0RpmWCoh0R7sMJW_LTxctLPEJpmTM@z> Hi Rimvydas! Am 28.12.23 um 08:09 schrieb Rimvydas Jasinskas: > On Wed, Dec 27, 2023 at 10:34 PM Harald Anlauf wrote: >> The patch is almost fine, except for a strange wording here: >> >> +@smallexample >> +gfortran -save-temps -c foo.F90 >> +@end smallexample >> + >> +preprocesses to in @file{foo.fii}, compiles to an intermediate >> +@file{foo.s}, and then assembles to the (implied) output file >> +@file{foo.o}, whereas: >> >> I understand the formulation is copied from gcc/doc/invoke.texi, >> where it does not fully make sense to me either. >> >> How about: >> >> "preprocesses input file @file{foo.F90} to @file{foo.fii}, ..." >> >> Furthermore, >> >> +@smallexample >> +gfortran -save-temps -S foo.F >> +@end smallexample >> + >> +saves the (no longer) temporary preprocessed file in @file{foo.fi}, and >> +then compiles to the (implied) output file @file{foo.s}. >> >> Even if this is copied from the gcc texinfo file, how about: >> >> "saves the preprocessor output in @file{foo.fi}, ..." >> >> which I find easier to read. >> >> Can you also add a reference to the PR number in the commit message? > I agree, wording sounds a lot better, included in v2 together with PR number. Yes, this is OK. Pushed: https://gcc.gnu.org/g:2cb93e6686e4af5725d8c919cf19f535a7f3aa33 Thanks for the patch! >>> Is there a specific reason thy -fc-prototypes (Interoperability >>> Options section) is excluded from manpage? >> >> Can you be more specific? I get here (since gcc-9): >> >> % man /opt/gcc/14/share/man/man1/gfortran.1 |grep -A 1 "Interoperability >> Options" >> Interoperability Options >> -fc-prototypes -fc-prototypes-external >> >> although no detailed explanation (-> gfortran.info). > The https://gcc.gnu.org/onlinedocs/gfortran/Invoking-GNU-Fortran.html > does contain a working link to > https://gcc.gnu.org/onlinedocs/gfortran/Interoperability-Options.html > However the manpage has Interoperability section explicitly disabled > with "@c man end" ... "@c man begin ENVIRONMENT". > After digging into git log it seems that Interoperability section was > unintentionally added after this comment mark in > https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=e655a6cc43 Yes, that might have been unintentional. Can you open a PR, and if you have a fix, attach it there? Thanks, Harald > Best regards, > Rimvydas