From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id DC58C3858D32 for ; Thu, 4 Jan 2024 04:48:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DC58C3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DC58C3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.129.153 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704343731; cv=none; b=Ca2qt4hYqEo9ZnUtKcn18jQ7TY/bl8w+2KMRZvIBlgVO9plSsNagQTCpibe3EcGciP7f/l00bo/jFqd+FCMD3pv3YwmG4eozo3sDmxGqF9Ub475cCRvwoVUnKe2PPE8GlkhRtOA1JLDsvc17Yhc7Sc8yvaKU2fDaKuGZ9KHKiEQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704343731; c=relaxed/simple; bh=Gq9Iog9YcvBmgwksb1MMODXSXdYl+Kp14GFNw51tYf8=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=QkBisrrp3kbN3mkHjnv6yOi4l7PnRP06Z9Svo4b2z8+4/XeWFmG4g0Ra+nYkZVob7yoPFvLLNASfec48eQEMM3UGuk/7q1x5W8HPu+FX9Os3ObzVd26roduEqBxwBd0PXgySG2XoIxeDlvchZzjAtxTdPOgI2UJxkwd3OhtfjeY= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: S50Fyp9+Sj+acFvxrrHD2Q== X-CSE-MsgGUID: u+EKQ5VZT3CSZ+ucuZaP/Q== X-IronPort-AV: E=Sophos;i="6.04,329,1695715200"; d="scan'208";a="30450814" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 03 Jan 2024 20:48:48 -0800 IronPort-SDR: d34I9wNnyVuoeTDpHG21z8nRlfDX+p1+llSitXqonRn81VZxZgIK8AIQ0GrgtrF+oC8QpvP7wy tBIpTIC8s0YSSQcbFn6YVGBXYK5ZZuvU2sn21BSVXfg0zGMihQTgHlY/mXEQ8wwq1EEeqziUOx msWIN88Ulo0L5RmeB/3e1FSrAfw18UBNmVv+mct8nSIvoATDFTqQQJm6CFmeXnddjJIZnhL4ax mUHVMQBfu9s3BHylqm++hftlMtNZ5NjYByUroVSZoxjjFx3DMmlzBHqBYFsgZAI2dHT4qm1XxX S7c= From: Sandra Loosemore To: Subject: [committed, obvious] OpenMP: trivial cleanups to omp-general.cc Date: Wed, 3 Jan 2024 21:48:35 -0700 Message-ID: <20240104044835.1088123-1-sandra@codesourcery.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: svr-orw-mbx-11.mgc.mentorg.com (147.34.90.211) To svr-orw-mbx-13.mgc.mentorg.com (147.34.90.213) X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: gcc/ChangeLog * omp-general.cc: Fix comment typos and misplaced/confusing comments. Delete redundant include of omp-general.h. --- gcc/omp-general.cc | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/gcc/omp-general.cc b/gcc/omp-general.cc index 264fbc01b78..bd4648f196f 100644 --- a/gcc/omp-general.cc +++ b/gcc/omp-general.cc @@ -1,5 +1,5 @@ -/* General types and functions that are uselful for processing of OpenMP, - OpenACC and similar directivers at various stages of compilation. +/* General types and functions that are useful for processing of OpenMP, + OpenACC and similar directives at various stages of compilation. Copyright (C) 2005-2024 Free Software Foundation, Inc. @@ -19,8 +19,6 @@ You should have received a copy of the GNU General Public License along with GCC; see the file COPYING3. If not see . */ -/* Find an OMP clause of type KIND within CLAUSES. */ - #include "config.h" #include "system.h" #include "coretypes.h" @@ -45,11 +43,11 @@ along with GCC; see the file COPYING3. If not see #include "data-streamer.h" #include "streamer-hooks.h" #include "opts.h" -#include "omp-general.h" #include "tree-pretty-print.h" enum omp_requires omp_requires_mask; +/* Find an OMP clause of type KIND within CLAUSES. */ tree omp_find_clause (tree clauses, enum omp_clause_code kind) { @@ -2874,9 +2872,8 @@ oacc_launch_pack (unsigned code, tree device, unsigned op) return res; } -/* FIXME: What is the following comment for? */ -/* Look for compute grid dimension clauses and convert to an attribute - attached to FN. This permits the target-side code to (a) massage +/* Openacc compute grid dimension clauses are converted to an attribute + attached to the function. This permits the target-side code to (a) massage the dimensions, (b) emit that data and (c) optimize. Non-constant dimensions are pushed onto ARGS. @@ -2890,9 +2887,8 @@ oacc_launch_pack (unsigned code, tree device, unsigned op) dimensions, keyed by the device type. The first entry will be the default. Well, that's the plan. */ -/* Replace any existing oacc fn attribute with updated dimensions. */ - -/* Variant working on a list of attributes. */ +/* Replace any existing oacc fn attribute in ATTRIBS with updated + dimensions. */ tree oacc_replace_fn_attrib_attr (tree attribs, tree dims) @@ -2905,7 +2901,8 @@ oacc_replace_fn_attrib_attr (tree attribs, tree dims) return tree_cons (ident, dims, attribs); } -/* Variant working on a function decl. */ +/* Replace any existing oacc fn attribute on FN with updated + dimensions. */ void oacc_replace_fn_attrib (tree fn, tree dims) -- 2.31.1