From: Mikael Pettersson <mikpelinux@gmail.com>
To: gcc-patches@gcc.gnu.org
Cc: Mikael Pettersson <mikpelinux@gmail.com>
Subject: [PATCH] Avoid ICE with m68k-elf -malign-int and libcalls
Date: Thu, 4 Jan 2024 10:23:53 +0100 [thread overview]
Message-ID: <20240104092425.1844-2-mikpelinux@gmail.com> (raw)
emit_library_call_value_1 calls emit_push_insn with NULL_TREE
for TYPE. Sometimes emit_push_insn needs to assign a temp with
that TYPE, which causes a segfault.
Fixed by computing the TYPE from MODE when needed.
Original patch by Thorsten Otto.
gcc/
2024-01-03 Thorsten Otto <admin@tho-otto.de>
Mikael Pettersson <mikpelinux@gmail.com>
PR target/82420
PR target/111279
* expr.cc (emit_push_insn): If TYPE is NULL compute it
from MODE before calling assign_temp.
gcc/teststuite/
2024-01-03 Mikael Pettersson <mikpelinux@gmail.com>
PR target/82420
* gcc.target/m68k/pr82420.c: New test.
---
gcc/expr.cc | 6 +++++-
gcc/testsuite/gcc.target/m68k/pr82420.c | 9 +++++++++
2 files changed, 14 insertions(+), 1 deletion(-)
create mode 100644 gcc/testsuite/gcc.target/m68k/pr82420.c
diff --git a/gcc/expr.cc b/gcc/expr.cc
index 9fef2bf6585..7ab80ef176c 100644
--- a/gcc/expr.cc
+++ b/gcc/expr.cc
@@ -5304,7 +5304,11 @@ emit_push_insn (rtx x, machine_mode mode, tree type, rtx size,
size = gen_int_mode (GET_MODE_SIZE (mode), Pmode);
if (!MEM_P (xinner))
{
- temp = assign_temp (type, 1, 1);
+ tree atype = type;
+
+ if (atype == NULL_TREE)
+ atype = lang_hooks.types.type_for_mode (mode, 0);
+ temp = assign_temp (atype, 1, 1);
emit_move_insn (temp, xinner);
xinner = temp;
}
diff --git a/gcc/testsuite/gcc.target/m68k/pr82420.c b/gcc/testsuite/gcc.target/m68k/pr82420.c
new file mode 100644
index 00000000000..5c84f292103
--- /dev/null
+++ b/gcc/testsuite/gcc.target/m68k/pr82420.c
@@ -0,0 +1,9 @@
+/* { do-do compile } */
+/* { dg-options "-march=68000 -malign-int" } */
+
+int a;
+
+void f(void)
+{
+ a /= 3;
+}
--
2.43.0
next reply other threads:[~2024-01-04 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 9:23 Mikael Pettersson [this message]
2024-01-04 21:39 ` Jeff Law
2024-01-16 16:55 ` Mikael Pettersson
2024-01-16 16:55 ` Mikael Pettersson
2024-01-21 23:00 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240104092425.1844-2-mikpelinux@gmail.com \
--to=mikpelinux@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).