From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id EDD45385802F for ; Thu, 4 Jan 2024 09:27:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EDD45385802F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EDD45385802F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::229 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704360425; cv=none; b=k4uWPaI7eJxrUKf/bBEGLiDkTy5FroIolyvw6MpDDQxIbBrxrwWnMwNAJOgdOM/jHJBuWtWi9i6cpjqF95YURczfhwU8831avi3ChXoD0CoIVOdoZMC6wP8/lGQQ10Xuq/P501C68gxvXqwnQcAtppblWbg45FDzzu+7amypNHI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704360425; c=relaxed/simple; bh=lGHjmeXN+bbHkEgJhp7ZPgnzi1xTZruGS9YZ29E7POA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=w1AaXHb9gO9iNzKwysgw/wkJUbHo08io9TH/CchARYvZjOuvZN/XSFIZ2oP32hPpLFMb9kwRW3GSMwyhEETo+THs3c6yTnrIDtelSQ5NzgwiMVNoTg6rVejEgxOWsMUof3Nhq699pAeX87ZAhc8A4bx+zSCORX6aph1zHGJWhdQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2cd1919f0acso4108331fa.0 for ; Thu, 04 Jan 2024 01:27:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704360421; x=1704965221; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lgob9upgCp2qTCDht5SoUueXRSb98IaJd0El4RAxLmU=; b=cpk4Trawe2hSWn3s+9zBFCrRqVUA0rhzcVJdbRxvk8SPlnPV9rnIBnyaH53qtm5XuU gClbb9F4vV3YbuV1tpCRMcuCoxkAwl1eeM4U1NQzWR7xqTUkOOdsLt+g47w69MuU9/IR 8HowhwUG+vpb6FbSNwXt/bYv/0eOwBt9cOhjGSuN4g4k3oIqHSkLG4qb8gyHdEdySOUL l9wyh5o/f9DC1RGAOD95aROhBKAi98Qn11FKRq3PokABCpPZjd95EAUfwkVqSjwyY4Il 99xTtTnGl0C9YtX/+em4QLnTwUKcZ4Uwe83WBge+EoLrSuCXYZ7GG2isKquecqNolLiS rjYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704360421; x=1704965221; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lgob9upgCp2qTCDht5SoUueXRSb98IaJd0El4RAxLmU=; b=O8+LDoiurkqXUWfuP5A2Ll0ySXAb4n7A7vBVfAJ4u/gZ7mWJ1Cl+u4FMUc8HVvPKMS vmyDdW74LCk4iy4ZPjwqxh2WnefucTNBiQIpPzYrq2/Vzz+nXeWetAmO3c+RSewXiWz8 1/dSNU8W7Sl2bLXPJfVqX+Uszhz3zJOhoO6iGB/RjrJbZ0QgdxN/9E06NM2qEiaUlQt/ anYTZh3pPtjhn2gC3pTm+03+9p8E6yxQeGJwksoLou26vgrNDc7gNRrzXCk8fnHUDDV7 1aJifxO2GBejW7oMva4Xvbs2VvUBBXMOq3GLQSqHtIQ6orSCFDriNbPPxy2Bl8EP/QIW 4eDA== X-Gm-Message-State: AOJu0Yxvkr+vC5DaRuFIcL2sKPhKdMLBB6v2y8kG4DgCpcIW5E4QRGoo v/4DcXohzIISfkyfu2FONtPGIl5wGpk= X-Google-Smtp-Source: AGHT+IG/dtFXQX6qEfjWQUghuoYTk+XcNvpbcWitMX+BzqaU1D2+HbrCISalMEVyjiQzPeyFE9Ujiw== X-Received: by 2002:a05:6512:398f:b0:50e:a8c7:b2df with SMTP id j15-20020a056512398f00b0050ea8c7b2dfmr234947lfu.36.1704360420761; Thu, 04 Jan 2024 01:27:00 -0800 (PST) Received: from hallertau.. (ip006.net-192-176-117.koping.net. [192.176.117.6]) by smtp.gmail.com with ESMTPSA id s21-20020a195e15000000b0050e64a74eedsm4026661lfb.188.2024.01.04.01.27.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 01:27:00 -0800 (PST) From: Mikael Pettersson To: gcc-patches@gcc.gnu.org Cc: Mikael Pettersson Subject: [PATCH] Avoid ICE with m68k-elf -malign-int and libcalls Date: Thu, 4 Jan 2024 10:23:53 +0100 Message-ID: <20240104092425.1844-2-mikpelinux@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: emit_library_call_value_1 calls emit_push_insn with NULL_TREE for TYPE. Sometimes emit_push_insn needs to assign a temp with that TYPE, which causes a segfault. Fixed by computing the TYPE from MODE when needed. Original patch by Thorsten Otto. gcc/ 2024-01-03 Thorsten Otto Mikael Pettersson PR target/82420 PR target/111279 * expr.cc (emit_push_insn): If TYPE is NULL compute it from MODE before calling assign_temp. gcc/teststuite/ 2024-01-03 Mikael Pettersson PR target/82420 * gcc.target/m68k/pr82420.c: New test. --- gcc/expr.cc | 6 +++++- gcc/testsuite/gcc.target/m68k/pr82420.c | 9 +++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/m68k/pr82420.c diff --git a/gcc/expr.cc b/gcc/expr.cc index 9fef2bf6585..7ab80ef176c 100644 --- a/gcc/expr.cc +++ b/gcc/expr.cc @@ -5304,7 +5304,11 @@ emit_push_insn (rtx x, machine_mode mode, tree type, rtx size, size = gen_int_mode (GET_MODE_SIZE (mode), Pmode); if (!MEM_P (xinner)) { - temp = assign_temp (type, 1, 1); + tree atype = type; + + if (atype == NULL_TREE) + atype = lang_hooks.types.type_for_mode (mode, 0); + temp = assign_temp (atype, 1, 1); emit_move_insn (temp, xinner); xinner = temp; } diff --git a/gcc/testsuite/gcc.target/m68k/pr82420.c b/gcc/testsuite/gcc.target/m68k/pr82420.c new file mode 100644 index 00000000000..5c84f292103 --- /dev/null +++ b/gcc/testsuite/gcc.target/m68k/pr82420.c @@ -0,0 +1,9 @@ +/* { do-do compile } */ +/* { dg-options "-march=68000 -malign-int" } */ + +int a; + +void f(void) +{ + a /= 3; +} -- 2.43.0