From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out3.simply.com (smtp-out3.simply.com [94.231.106.210]) by sourceware.org (Postfix) with ESMTPS id 5CFFE38582AD for ; Fri, 5 Jan 2024 07:19:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5CFFE38582AD Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=gaisler.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gaisler.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5CFFE38582AD Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=94.231.106.210 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704439180; cv=none; b=vwEl6FFwqGUJwSJKfuHD2nB8LCSIq6xkaDVwqdFOdbd5zj4VvH2T8mkgqHoqnfvQOs1MSfDQvnQ/qFsxOLSNkExj4hACYbTES1JLz64R/s9x1KnzWFLidzdFG333gozxf/hS9ppY0d9VjtalitjbevMDgfDzD83YUZGrLYS/u64= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704439180; c=relaxed/simple; bh=wXvYYdym/XD6DTcHd5aI2s6Qn9jc8FEQfnPPj0Mx3ew=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=d343dzn5bFmeBh7WRngncakullQRDLYWxq09o2TAwtSzqxOyRqCtS1HIWiSgEvIt5m8Ae+zW2nA/xAjNPrOgCXT4BM5XfnTDxWwsN0HNRYIipF4pnrQNnXdtCZfxI2wiVq+vITI2lvOwvnqPh5Tec9kUBt6jOIos+bgboLATCJQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from localhost (localhost [127.0.0.1]) by smtp.simply.com (Simply.com) with ESMTP id 4T5vwT2G1Bz67wm; Fri, 5 Jan 2024 08:19:37 +0100 (CET) Received: from cederman.got.gaisler.com (h-98-128-223-123.NA.cust.bahnhof.se [98.128.223.123]) by smtp.simply.com (Simply.com) with ESMTPA id 4T5vwT0dcTz67wG; Fri, 5 Jan 2024 08:19:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gaisler.com; s=unoeuro; t=1704439177; bh=vKGPyRUo9nnaFl1GbQH6l+xhJgOAzvuHc73v+8vywpA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=UFSAo4WLq3OztHa1ZlleTdLyKd/kzYPHQyo56pKMhrqeKQlQ58NU9IW8yIOTWOMyX 8JdyoRx3bCEFkhZanwLKhz+ifGLEpNpabnDxuilxY30nBCshLyPss5fnALpNrssqwX yh2/lh+xnLfVS7rYM++Ld3Il38OshtPtdEnQ+vp8= From: Daniel Cederman To: gcc-patches@gcc.gnu.org Cc: ebotcazou@libertysurf.fr, daniel@gaisler.com, Andreas Larsson Subject: [PATCH 1/2] sparc: Revert membar optimization that is not suitable for LEON5 Date: Fri, 5 Jan 2024 08:19:11 +0100 Message-Id: <20240105071913.593978-2-cederman@gaisler.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240105071913.593978-1-cederman@gaisler.com> References: <20240105071913.593978-1-cederman@gaisler.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-15.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Andreas Larsson LEON5 has a deeper write-buffer and hence stb is not enough to flush a write out. For compatibility, use the default V8 approach for both LEON3 and LEON5. This reverts commit 49cc765db35a5a21cab2aece27a44983fa70b94b, "sync.md (*membar_storeload_leon3): New insn." gcc/ChangeLog: * config/sparc/sync.md (*membar_storeload_leon3): Remove (*membar_storeload): Enable for LEON --- gcc/config/sparc/sync.md | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/gcc/config/sparc/sync.md b/gcc/config/sparc/sync.md index 8808ed5bc14e..ac291420b8b9 100644 --- a/gcc/config/sparc/sync.md +++ b/gcc/config/sparc/sync.md @@ -64,19 +64,11 @@ "stbar" [(set_attr "type" "multi")]) -;; For LEON3, STB has the effect of membar #StoreLoad. -(define_insn "*membar_storeload_leon3" - [(set (match_operand:BLK 0 "" "") - (unspec:BLK [(match_dup 0) (const_int 2)] UNSPEC_MEMBAR))] - "TARGET_LEON3" - "stb\t%%g0, [%%sp-1]" - [(set_attr "type" "store")]) - ;; For V8, LDSTUB has the effect of membar #StoreLoad. (define_insn "*membar_storeload" [(set (match_operand:BLK 0 "" "") (unspec:BLK [(match_dup 0) (const_int 2)] UNSPEC_MEMBAR))] - "TARGET_V8 && !TARGET_LEON3" + "TARGET_V8" "ldstub\t[%%sp-1], %%g0" [(set_attr "type" "multi")]) -- 2.40.1