From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 6A8A23858C60 for ; Fri, 19 Jan 2024 07:05:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6A8A23858C60 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6A8A23858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705647949; cv=none; b=OpvLgPeVzCUfe29gkB1maZJNglk77d5WeDdPNbCgPNtxDzKC93gh/ukJGa0+KQxfh31h8+wnRro7AiNL31GFt/GyT8EfABY0UI0jMx0Hm7d85VA2ZeyfOtP8Sd9uXa7ducyGrRUYHDA9rz3lzHJNwPES60fSfK2Ct531C0tRdqU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705647949; c=relaxed/simple; bh=atVcXbwb2icsSkAXfazlO7Jsd6pcSLVDZe8pYpBkuGE=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=DhgQmSVjcZE0PN5PY3jPJCWe+fD0gHAosIIHVZJi3k/RREHWo/s1Kk/+R8RTrUw4C8xU0KT15/E9yJ3eCaGPMpYDxDais7B0fky1Vk6A222s0CJ13pfZQQC2inE67NgE3Ab80zlpiRHmWBETvicNI7Z3Ux2Bo6Ij1D95rbuSjIc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-6d98ce84e18so496438b3a.3 for ; Thu, 18 Jan 2024 23:05:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1705647946; x=1706252746; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eMTCEWojC1UUJ/ftd3gByulD7KKofsPsAi//0keQCJQ=; b=ID9XJ0nqj6IA/JFOUPxLJK9oNOqK21qziAZDIRrtR01kQmijiQYGx7iNN97dwydhvM xKVFBJLgPNRMtcqMdL9YD5atJZZ86c2Fs6nEJ+lGY/RSa92wJ6ZPbiu1S2b4DIYIPY4B YGP0U1TMpllZQn1qWMMFGyhKAh6U5WT8fKZsMELHi7CLEQLU7N2QhPuEsT1LVzkgZrl4 rFewoDdrmULi8sBwlUgWXgA0pOEXQAX7+1DFXItDdQadHhpWFL+HPmKx0b+9jZwGwbjm UqLuKFfUqCWH1pS/ATasH4FnDNGmRx3eTer1yeXi9bL7BD6kaTPaWFxcSTccU+2J/SQC ArSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705647946; x=1706252746; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eMTCEWojC1UUJ/ftd3gByulD7KKofsPsAi//0keQCJQ=; b=m9P44BS7npmeJLm+UXEEvUajxwcwPCeKB7bWUYIAXJhXYE/Bl6S/ejArMc7yMlDEMn pq15f3Ct5g2CgNUWEkVE39mVBMzBTzZpMgF/2Jj7IcIU8jeTQN/qg+PGckWZYEoYP30e B9VkNTK8BXqvnQTgwnT6icXDlJdXfHOEu9Jq07n7ph06z+ybeZyVtYoULxRnc7uYTq1F dZfNwDpWP+pOvOEIjpXZ1Hfqw5QQKBrqALTnp7B8Farh5B2zTl3QNGXA+ktnOlhShQdk I2karGIr2Mk86eNZDq+/4rCHDLdJ02zedz/1OPWA/fAJI3slrPfwoc+NiJNT5KHzJUEh Lbig== X-Gm-Message-State: AOJu0YxceUplDwEki0aU9oka5LXek8DT5cBdhRMLrgPuh6Oj8S4tavnM AJNuYkOLqBXix+KqYcZTPsZxXCoydjbt7Y1p+vuFEteWdCctaw/qjRNCQNEIIHUlwIJvmcRNoZg i7h+6LBBTYoOPl70ncO5X+lZCacuDj56d2VAGbaF6N8/J81/VPzTnuetFmcRhO7TiwkesefhLce KJwrxU2iAQ4Sr9qcvYUdVFzOn7Zdq02VVUuHa3Q/ZHJiqm X-Google-Smtp-Source: AGHT+IH605A+fM2sRvPMPIKBf7eK2jnRwyhSXFC2RKguYW8B5Ga6JQgtg6JfmgjaOVONQLbjjr4Rcw== X-Received: by 2002:a05:6a00:3999:b0:6d9:a96f:9865 with SMTP id fi25-20020a056a00399900b006d9a96f9865mr2623058pfb.47.1705647945910; Thu, 18 Jan 2024 23:05:45 -0800 (PST) Received: from hsinchu02.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id k82-20020a628455000000b006d9a0059a9asm4697144pfd.172.2024.01.18.23.05.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 23:05:45 -0800 (PST) From: Monk Chiang To: gcc-patches@gcc.gnu.org, rguenther@suse.de, apinski@marvell.com, jeffreyalaw@gmail.com, kito.cheng@sifive.com Cc: Monk Chiang Subject: [PATCH] RISC-V: Add split pattern to generate SFB instructions. [PR113095] Date: Fri, 19 Jan 2024 15:05:40 +0800 Message-Id: <20240119070540.95115-1-monk.chiang@sifive.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Since the match.pd transforms (zero_one == 0) ? y : z y, into ((typeof(y))zero_one * z) y. Add splitters to recongize this expression to generate SFB instructions. gcc/ChangeLog: PR target/113095 * config/riscv/sfb.md: New splitters to rewrite single bit sign extension as the condition to SFB instructions. gcc/testsuite/ChangeLog: * gcc.target/riscv/sfb.c: New test. --- gcc/config/riscv/sfb.md | 32 ++++++++++++++++++++++++++++ gcc/testsuite/gcc.target/riscv/sfb.c | 24 +++++++++++++++++++++ 2 files changed, 56 insertions(+) create mode 100644 gcc/testsuite/gcc.target/riscv/sfb.c diff --git a/gcc/config/riscv/sfb.md b/gcc/config/riscv/sfb.md index 8ab747142c8..520b12c22f9 100644 --- a/gcc/config/riscv/sfb.md +++ b/gcc/config/riscv/sfb.md @@ -35,3 +35,35 @@ [(set_attr "length" "8") (set_attr "type" "sfb_alu") (set_attr "mode" "")]) + +;; Combine creates this form ((typeof(y))zero_one * z) y +;; for SiFive short forward branches. + +(define_split + [(set (match_operand:X 0 "register_operand") + (and:X (sign_extract:X (match_operand:X 1 "register_operand") + (const_int 1) + (match_operand 2 "immediate_operand")) + (match_operand:X 3 "register_operand"))) + (clobber (match_operand:X 4 "register_operand"))] + "TARGET_SFB_ALU" + [(set (match_dup 4) (zero_extract:X (match_dup 1) (const_int 1) (match_dup 2))) + (set (match_dup 0) (if_then_else:X (ne:X (match_dup 4) (const_int 0)) + (match_dup 3) + (const_int 0)))]) + +(define_split + [(set (match_operand:X 0 "register_operand") + (and:X (sign_extract:X (match_operand:X 1 "register_operand") + (const_int 1) + (match_operand 2 "immediate_operand")) + (match_operand:X 3 "register_operand"))) + (clobber (match_operand:X 4 "register_operand"))] + "TARGET_SFB_ALU && (UINTVAL (operands[2]) < 11)" + [(set (match_dup 4) (and:X (match_dup 1) (match_dup 2))) + (set (match_dup 0) (if_then_else:X (ne:X (match_dup 4) (const_int 0)) + (match_dup 3) + (const_int 0)))] +{ + operands[2] = GEN_INT (1 << UINTVAL(operands[2])); +}) diff --git a/gcc/testsuite/gcc.target/riscv/sfb.c b/gcc/testsuite/gcc.target/riscv/sfb.c new file mode 100644 index 00000000000..22f164051f4 --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/sfb.c @@ -0,0 +1,24 @@ +//* { dg-do compile } */ +/* { dg-options "-O2 -march=rv32gc -mabi=ilp32d -mtune=sifive-7-series" } */ + +int f1(unsigned int x, unsigned int y, unsigned int z) +{ + return ((x & 1) == 0) ? y : z ^ y; +} + +int f2(unsigned int x, unsigned int y, unsigned int z) +{ + return ((x & 1) != 0) ? z ^ y : y; +} + +int f3(unsigned int x, unsigned int y, unsigned int z) +{ + return ((x & 1) == 0) ? y : z | y; +} + +int f4(unsigned int x, unsigned int y, unsigned int z) +{ + return ((x & 1) != 0) ? z | y : y; +} +/* { dg-final { scan-assembler-times "bne" 4 } } */ +/* { dg-final { scan-assembler-times "movcc" 4 } } */ -- 2.40.1