public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@axis.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: <hubicka@ucw.cz>, <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] c/c++: Tweak warning for 'always_inline function might not be inlinable'
Date: Mon, 22 Jan 2024 15:27:16 +0100	[thread overview]
Message-ID: <20240122142716.66B042041E@pchp3.se.axis.com> (raw)
In-Reply-To: <CAFiYyc0DTbXy9bFX_ouuBsN2Qd2NW-7BVgkr7Y=_ugHG13kJCA@mail.gmail.com> (message from Richard Biener on Mon, 22 Jan 2024 08:33:47 +0100)

> From: Richard Biener <richard.guenther@gmail.com>
> Date: Mon, 22 Jan 2024 08:33:47 +0100

> > -                   "%<always_inline%> function might not be inlinable");
> > +                   "%<always_inline%> function is not always inlined"
> > +                   " unless also declared %<inline%>");
> 
> I don't like the "is not always inlined", maybe simply reword to
> 
>   "%<always_inline%> function might not be inlinable"
>   " unless also declared %<inline%>"
> 
> ?

Sure.  Though it's a small nuance to which I don't actually
agree, I'll go along with almost anything as long as the
"<unless>...declared inline" augmentation is there :-)

Also, I can see that keeping closer to the original wording
as you suggest can be preferable to some.

I assume by your reply that the patch is ok with that change
but will wait another 72 hours for "native speakers" to have
a say.

Thanks!

brgds, H-P

  reply	other threads:[~2024-01-22 14:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-21 13:32 Hans-Peter Nilsson
2024-01-22  7:33 ` Richard Biener
2024-01-22 14:27   ` Hans-Peter Nilsson [this message]
2024-01-23  7:26     ` Richard Biener
2024-01-23 20:36     ` [PATCH v2] " Hans-Peter Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240122142716.66B042041E@pchp3.se.axis.com \
    --to=hp@axis.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).