From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 701FD3858428 for ; Wed, 24 Jan 2024 09:19:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 701FD3858428 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 701FD3858428 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706087977; cv=none; b=wFPbeaJpZoSjqq0XcxUKc68SokY65/C31ZB91gUHMm0AgsZVPeI0PYx9xkIOlpg4yDSmh05BwSEd0eOMk3KErUi4lJwHKSn9kwNmOv4uTg9PCfe4ke5flHh8sWNf8v3sKwou+eHEFSiWv4HVTVju1j7Teww8PnVvOXe0zZd19f8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706087977; c=relaxed/simple; bh=TnH5b4GbVN/Gz3MOp89eHK7AkS97Ss2Ep3oGcpOrK5k=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=G8CUkAwXWXozB6anccaszRYY1foH95pGUVN03rQ5qNw+qGUgRjQJq5Zm8ke6btqwt32QJKjv4/VrInZVfKWvG9VYlrpOrfdlRGuEBinCGPZvW2O0I6TrDDRuz9gOMPazyHjPDPckiKdtTSmgSPQ/hphpSqpU1XNlNJHCKXiig58= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSZPu-00025d-0m for gcc-patches@gcc.gnu.org; Wed, 24 Jan 2024 04:19:32 -0500 Received: from loongson.cn (unknown [10.10.130.252]) by gateway (Coremail) with SMTP id _____8DxdfEX1rBluqoEAA--.18835S3; Wed, 24 Jan 2024 17:19:20 +0800 (CST) Received: from slurm-master.loongson.cn (unknown [10.10.130.252]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Ax3c4W1rBllI8WAA--.34383S4; Wed, 24 Jan 2024 17:19:18 +0800 (CST) From: Jiahao Xu To: gcc-patches@gcc.gnu.org Cc: xry111@xry111.site, i@xen0n.name, chenglulu@loongson.cn, xuchenghua@loongson.cn, Jiahao Xu Subject: [PATCH] Loongarch: Remove vec_concatz pattern Date: Wed, 24 Jan 2024 17:19:13 +0800 Message-Id: <20240124091913.38156-1-xujiahao@loongson.cn> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:AQAAf8Ax3c4W1rBllI8WAA--.34383S4 X-CM-SenderInfo: 50xmxthkdrqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBj93XoW7ZrW8Jry5Cr15Jw1xZw47Awc_yoW8KF4rpa 98uwnayr4kXrZIg3WkJayxXwsxJFyxGa12vF13trn7Cw4UW348Zr1Skr9IvFn0qw4rury7 X3WSka1Y9a1UGrcCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUkFb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2 Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s02 6x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0x vE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE 42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6x kF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07jUsqXUUUUU= Received-SPF: pass client-ip=114.242.206.163; envelope-from=xujiahao@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9,SPF_HELO_NONE=0.001,SPF_PASS=-0.001,T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_FAIL,SPF_HELO_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: It is incorrect to use vld/vori to implement the vec_concatz because when the LSX instruction is used to update the value of the vector register, the upper 128 bits of the vector register will not be zeroed. gcc/ChangeLog: * config/loongarch/lasx.md (@vec_concatz): Remove this define_insn pattern. * config/loongarch/loongarch.cc (loongarch_expand_vector_group_init): Use vec_concat. diff --git a/gcc/config/loongarch/lasx.md b/gcc/config/loongarch/lasx.md index 90f66ee4d24..e2115ffb884 100644 --- a/gcc/config/loongarch/lasx.md +++ b/gcc/config/loongarch/lasx.md @@ -582,21 +582,6 @@ (define_insn "lasx_xvinsgr2vr_" [(set_attr "type" "simd_insert") (set_attr "mode" "")]) -(define_insn "@vec_concatz" - [(set (match_operand:LASX 0 "register_operand" "=f") - (vec_concat:LASX - (match_operand: 1 "nonimmediate_operand") - (match_operand: 2 "const_0_operand")))] - "ISA_HAS_LASX" -{ - if (MEM_P (operands[1])) - return "vld\t%w0,%1"; - else - return "vori.b\t%w0,%w1,0"; -} - [(set_attr "type" "simd_splat") - (set_attr "mode" "")]) - (define_insn "vec_concat" [(set (match_operand:LASX 0 "register_operand" "=f") (vec_concat:LASX diff --git a/gcc/config/loongarch/loongarch.cc b/gcc/config/loongarch/loongarch.cc index 072c68d97e3..cd335827570 100644 --- a/gcc/config/loongarch/loongarch.cc +++ b/gcc/config/loongarch/loongarch.cc @@ -9917,17 +9917,12 @@ loongarch_expand_vector_group_init (rtx target, rtx vals) gcc_unreachable (); } - if (high == CONST0_RTX (half_mode)) - emit_insn (gen_vec_concatz (vmode, target, low, high)); - else - { - if (!register_operand (low, half_mode)) - low = force_reg (half_mode, low); - if (!register_operand (high, half_mode)) - high = force_reg (half_mode, high); - emit_insn (gen_rtx_SET (target, - gen_rtx_VEC_CONCAT (vmode, low, high))); - } + if (!register_operand (low, half_mode)) + low = force_reg (half_mode, low); + if (!register_operand (high, half_mode)) + high = force_reg (half_mode, high); + emit_insn (gen_rtx_SET (target, + gen_rtx_VEC_CONCAT (vmode, low, high))); } /* Expand initialization of a vector which has all same elements. */ -- 2.20.1