From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id D578A3858D37 for ; Thu, 1 Feb 2024 01:50:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D578A3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D578A3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=116.202.254.214 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706752206; cv=none; b=V9lBxHPKsru80RTeSVQyjNhrAgA7A1ndXOkwM3YMH4V7wbXMhBYQEGPV3bA/LKmAqzWS1TuPz+myzHytSUtqqV5TRbxRFC/V4ANlU2v5GcyWqTC8812RPGg32fF4oRHHDqzQyekeQJ42AsILux2DrZI5Tkf+eVQaiSZ0f/xirI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706752206; c=relaxed/simple; bh=PV66CgArhCh1cwrVB8W7+S4/vuE1eC6loN2vhqU+FTA=; h=To:From:Subject:Date:Message-ID:Mime-Version; b=sDz35IoBASaMA2+KJ2FYmgom9W0ZjwCco9HMLEzTFm8IWMUCY70a/7Y2mD1uqHdybcCBh93r+eSVy/EiTNxnKeNPbfAZy4PVmqLMcEsKwpcSdmJq5B2fsAunLR/Wo7CZ4U1qDaiY4v6PInnUOyXoBTHuGfSsSs3B9fRLdZWfy+U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rVMDK-0009K5-FB for gcc-patches@gcc.gnu.org; Thu, 01 Feb 2024 02:50:02 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Edwin Lu Subject: Re: [COMMITTED V3 3/4] RISC-V: Use default cost model for insn scheduling Date: Wed, 31 Jan 2024 17:41:43 -0800 Message-ID: <4df01fb3-6b59-4eed-aae9-e21d1dc64389@rivosinc.com> References: <20240112180844.2005246-1-ewlu@rivosinc.com> <20240112180844.2005246-4-ewlu@rivosinc.com> <12d205cd-3177-48ea-a54e-c2052fddec2e@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla Thunderbird Content-Language: en-US In-Reply-To: <12d205cd-3177-48ea-a54e-c2052fddec2e@gmail.com> X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20240201014143.MKs3hq6LtOhOspzLIRuY44ksZ0ljV9A07lcnZLYqzAg@z> On 1/25/2024 9:06 AM, Robin Dapp wrote: >> Use default cost model scheduling on these test cases. All these tests >> introduce scan dump failures with -mtune generic-ooo. Since the vector >> cost models are the same across all three tunes, some of the tests >> in PR113249 will be fixed with this patch series. > > This is OK, thanks. > >> 39 additional unique testsuite failures (scan dumps) will still be present. >> I don't know how optimal the new output is compared to the old. Should I update >> the testcase expected output to match the new scan dumps? > > Currently, without vector op latency, the output should come close > to what's normally considered "good" (i.e. minimal number of vsetvls > and so on). Therefore I'd suggest not to change the scan dumps to > much except when there is a real problem. If you have a specific > example that you're unsure about we can discuss this on or off list. > > Regards > Robin > > Committed! Edwin