From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id 3751E3858015 for ; Thu, 1 Feb 2024 01:45:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3751E3858015 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3751E3858015 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=116.202.254.214 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706751907; cv=none; b=ob9Y4ZXJJMytc8bGTwn/YbMrp3j41aL4DgL5e3I6vuM/lpWilAK9LjRNReBZho9JCiFI2FLdpcVq9MRNk2eKU3/VHPpPou00m69cBp8dkuDryB9PnocTN39PA/gfUs4BHTnAqSk4IrRE7qK49BaMzgAKuRLMAfNfTAnJRkl8SZg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706751907; c=relaxed/simple; bh=tgg+C4zt+D471SkSi2UlewmiDvIgqlmxOjn1a7Su3XM=; h=To:From:Subject:Date:Message-ID:Mime-Version; b=VgbC2r/caaOkeX7NvwNRfDWLK3NcceYa9Onfklvg1SK2+BZgEYxvovcLKlXOnXCjVaO2g2MY9h55Ay3CmBykbjjUIuou14cKX0pem+FB0QkwAW8Xk5ypkM9QAgtjuh9CQZDNYBIUcFHMpJ3JNhfAiwroGZZvlVSZzHIdP93jqOM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rVM8T-0002fF-Th for gcc-patches@gcc.gnu.org; Thu, 01 Feb 2024 02:45:01 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Edwin Lu Subject: Re: [COMMITTED V3 4/4] RISC-V: Enable assert for insn_has_dfa_reservation Date: Wed, 31 Jan 2024 17:42:41 -0800 Message-ID: <825e841c-b715-44cd-8cdd-b722865b4f7f@rivosinc.com> References: <20240112180844.2005246-1-ewlu@rivosinc.com> <20240112180844.2005246-5-ewlu@rivosinc.com> <30de6dd9-7d97-43b6-9874-c197f5c31659@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla Thunderbird Cc: gnu-toolchain@rivosinc.com Content-Language: en-US In-Reply-To: <30de6dd9-7d97-43b6-9874-c197f5c31659@gmail.com> X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20240201014241.1b8rAOE_cXijSiFhODHQK3UhBMdrVq2sSwqtMAqbjI4@z> On 1/25/2024 9:06 AM, Robin Dapp wrote: >> /* If we ever encounter an insn without an insn reservation, trip >> an assert so we can find and fix this problem. */ >> -#if 0 >> + if (! insn_has_dfa_reservation_p (insn)) { >> + print_rtl(stderr, insn); >> + fprintf(stderr, "%d", get_attr_type (insn)); >> + } >> gcc_assert (insn_has_dfa_reservation_p (insn)); >> -#endif >> >> return more - 1; >> } > > I was thinking about make the gcc_assert a gcc_checking_assert so, > in case we accidentally forget something at any point, it would > only gracefully degrade in a release build. As we already have > a hard assert for the type the patch (and not many test with > enable checking anyway) this is OK IMHO. > > I suppose you tested with all available -mtune options? > > Regards > Robin > > Committed without the debugging stuff! Edwin