From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 1AF44385801D; Fri, 2 Feb 2024 10:53:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1AF44385801D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1AF44385801D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706871219; cv=none; b=sa6KhCtCuyP2YSgvWWxxxqIp49HByaANvXdpTs8jtlXWlA06X5uZ6/Rw5yN5qbFkNWu9NBGMBIRWibX5DJVi7m81JYGbUtWuAHH1+/LzV2WI253qplz5cgrt1b22PR9N2T5Sakxnq+2a8ibHmVnrymMAD/tgC1ucPIdlyI+HXoc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706871219; c=relaxed/simple; bh=vQ0rdtA9DYrzrHCZgX4j3yKSNhtrww8T7ibaieh7P/M=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=r0zX2sbWCjYtfKDPwoQRRYOjae869nR0OMfeOyHld6hSticMvASrDorgg9bPL0yLcwuaYPtWifRAaN3oZYM/Uzawisn9AAjGN5zIXSI/LQVDQGf432efaqpPpzm/9HbIkMJIxrvb/RENq6qKgGvZ7EIxDdnpt449zTiya/ZFsQA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a370e63835cso49807466b.1; Fri, 02 Feb 2024 02:53:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706871216; x=1707476016; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jrpsDx2rP9vsJfkqq9SBV3lKeImYJ6dcFj4mHeoboBY=; b=NHrgnGixddflmvQ6wzRNmP8qNIFTcu5f5mqGWr4+zUXIUeWQ4vl92xdqNkkNgOEV7w xHUDTazMKQlswdjBegsrc1ovWa6q0GhQHXCHm/s6AQzwJ4p2fCSCEm+bIcWF/jZ5F1Y+ fpgtJnwSv+aIjlNS+6bMXGYfPQbKAboG14O7DBrgXebjYb+syZYM9fEW/ziTB5RzEMjN BwIESWQKy+8fqYkr3Pprrz8WCyV90NEX8JWSLKIZAVCYY47UknGdHazNYoOKNvmhsOsT u67CjUE/ko5K3QPmZz/NZjLWw/KMTNBDnEo8Wo0b0v7wgog02It9kdR1M8BDKEPSLl7S dBZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706871216; x=1707476016; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jrpsDx2rP9vsJfkqq9SBV3lKeImYJ6dcFj4mHeoboBY=; b=ULjfNcIlaEjkLMKfFbschz6z4I789s5xhh6pxCjMFPo8FwqjwgNDgO4meMoQ33vcZx 9sGImEfwhClANbBtBIKOeSt4FhuKtqpuGiCU6vMa1YmvboQtZj1mIn44lb6Ga48rfTJ9 8WoiirEEyZVZjJl8bA5igT1H/Vpasobb203WvVHGquxbJ6LauH4on9SSyznEoYW9eN7i tVZa2jMfswwYjBH4+eRfNoHHwsKJFcBL6fYMWipKTwpucIwvNP8Q7XFNgF44dHZiKNW+ KCQQAcpFDZoTo6dYZD4K0OKrIGij57S3iOfb/f0W2X3l1HgPnNuELdHKHXK5CO6MZamD Dhiw== X-Gm-Message-State: AOJu0Yyaw1J6Pq1KdMaU/ybu9q73dt6WdGTMyXUDDFgwKSN5A9hK++s4 uCX41IVr0Gey0KQEH7ZSDzxK0r0Di2xq00+IxbHzrcMXOvqycAkG X-Google-Smtp-Source: AGHT+IE0KcXQYM+eUuQjfMZL82FXRs+Mi2EwnXnmY3BR95kUsWCV7g2IMngu+XAH2ya8eAW2/vQqXA== X-Received: by 2002:a17:906:f107:b0:a2d:52dc:1841 with SMTP id gv7-20020a170906f10700b00a2d52dc1841mr3483265ejb.18.1706871215638; Fri, 02 Feb 2024 02:53:35 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXPPUd/TOvylqU4ncoAfWz9eBP1MjJfI0SgQO3SWtTzO45MzA32raYA4N/rBkCzS6AXKWa7de5wK5HfEPxlzS+6gdQcx5LU6LV4EZGsjV3X4gwbSvf67nFALx4oLAQ0b0rXn9q5cKWayVxJia4o9FUEWnFSyDpoNlaOwTAMpK6C/46Q3/mCdCD+GN25u6MiDUA= Received: from nbbrfq.loc (80-110-214-113.static.upcbusiness.at. [80.110.214.113]) by smtp.gmail.com with ESMTPSA id fj10-20020a1709069c8a00b00a36a94ecf9dsm763251ejc.175.2024.02.02.02.53.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 02:53:35 -0800 (PST) Date: Fri, 2 Feb 2024 11:53:31 +0100 From: Bernhard Reutner-Fischer To: Joseph Myers Cc: rep.dot.nop@gmail.com, gcc@gcc.gnu.org, ubizjak@gmail.com, hubicka@ucw.cz, hjl.tools@gmail.com, gcc-patches@gcc.gnu.org Subject: Re: [Patch, stage-1, RFC]: i386: attribute regparm/stdcall and vaargs Message-ID: <20240202115331.37b4a158@nbbrfq.loc> In-Reply-To: <2a473ec9-950-a775-4e48-6c893202653@redhat.com> References: <20240130001434.35b2b856@nbbrfq.loc> <2a473ec9-950-a775-4e48-6c893202653@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Joseph! On Tue, 30 Jan 2024 14:54:49 +0000 (UTC) Joseph Myers wrote: > On Tue, 30 Jan 2024, Bernhard Reutner-Fischer via Gcc wrote: > > > * builtin-attrs.def (ATTR_TM_NOTHROW_RT_LIST): Use ATTR_NOTHROW_LIST > > instead of ATTR_TM_NOTHROW_LIST, thus removing ATTR_TM_REGPARM. > > That doesn't make sense. ATTR_TM_NOTHROW_RT_LIST is specifically a > transactional memory attribute list, but you're removing all transactional > memory attributes from it. A list without the "*tm regparm" internal > attribute would have a different name. > AFAICS there is no pre-existing attr list with just returns_twice and nothrow. Would ATTR_NOTHROW_RT_LIST be more appropriate as name, and should i move this up to before the format attribute lists, before DEF_FORMAT_ATTRIBUTE? Alternatively, there is an existing ATTR_RT_NOTHROW_LEAF_LIST used by setjmp. But that would add leaf to _ITM_beginTransaction where it was not marked leaf before. Would it be appropriate to use this for _ITM_beginTransaction too, which behaves setjmp()ish AFAICS? thanks