From: Edwin Lu <ewlu@rivosinc.com>
To: gcc-patches@gcc.gnu.org
Cc: Robin Dapp <rdapp.gcc@gmail.com>,
"kito.cheng" <kito.cheng@gmail.com>,
jeffreyalaw <jeffreyalaw@gmail.com>, palmer <palmer@rivosinc.com>,
vineetg <vineetg@rivosinc.com>,
Patrick O'Neill <patrick@rivosinc.com>
Subject: Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines
Date: Fri, 2 Feb 2024 16:29:17 -0800 [thread overview]
Message-ID: <5613b194-1af3-4a18-9079-4a9baec0b6e1@rivosinc.com> (raw)
Message-ID: <20240203002917.A6JZNRVME2H7jdBi7DLXZOwUDzGXncfMvApTOW-Z6Lc@z> (raw)
In-Reply-To: <MW5PR11MB59085A597C7E1967A6B9E61DA9422@MW5PR11MB5908.namprd11.prod.outlook.com>
On 2/1/2024 8:28 PM, Li, Pan2 wrote:
> Hi Edwin,
>
> Just rerun the newlib and there is no ICE but still 160 dump failures as below.
>
> Pan
>
Hi Pan,
Thanks for confirming! Having dump failures is expected. There are
around 7 more unique failures than I expected
(https://github.com/patrick-rivos/gcc-postcommit-ci/issues/473 <--
postcommit found 46 while I expected 39
https://inbox.sourceware.org/gcc-patches/12d205cd-3177-48ea-a54e-c2052fddec2e@gmail.com/
https://github.com/ewlu/gcc-precommit-ci/issues/1178#issuecomment-1889782987)
I included the 7 failed tests below and what was found instead.
I believe the only problematic failures are the 5 vls calling convention
ones where only 24 ld\\s+a[0-1],\\s*[0-9]+\\(sp\\) are found.
FAIL: gcc.target/riscv/rvv/autovec/vls/calling-convention-1.c -O3
-ftree-vectorize --param riscv-autovec-preference=scalable
scan-assembler-times ld\\s+a[0-1],\\s*[0-9]+\\(sp\\) 35
FAIL: gcc.target/riscv/rvv/autovec/vls/calling-convention-2.c -O3
-ftree-vectorize --param riscv-autovec-preference=scalable
scan-assembler-times ld\\s+a[0-1],\\s*[0-9]+\\(sp\\) 33
FAIL: gcc.target/riscv/rvv/autovec/vls/calling-convention-3.c -O3
-ftree-vectorize --param riscv-autovec-preference=scalable
scan-assembler-times ld\\s+a[0-1],\\s*[0-9]+\\(sp\\) 31
FAIL: gcc.target/riscv/rvv/autovec/vls/calling-convention-4.c -O3
-ftree-vectorize --param riscv-autovec-preference=scalable
scan-assembler-times ld\\s+a[0-1],\\s*[0-9]+\\(sp\\) 29
FAIL: gcc.target/riscv/rvv/autovec/vls/calling-convention-7.c -O3
-ftree-vectorize --param riscv-autovec-preference=scalable
scan-assembler-times ld\\s+a[0-1],\\s*[0-9]+\\(sp\\) 29
This is what I'm getting locally (first instance of wrong match):
v32qi_RET1_ARG8:
.LFB109:
.cfi_startproc
li t1,32
vsetvli zero,t1,e8,mf8,ta,ma
vle8.v v1,0(a1)
vle8.v v4,0(a2)
vle8.v v3,0(a3)
vle8.v v2,0(a4)
vadd.vv v1,v1,v4
vadd.vv v1,v1,v3
vle8.v v3,0(a5)
ld a5,0(sp) <-- used a5 instead of a1
vadd.vv v1,v1,v2
vle8.v v2,0(a6)
vadd.vv v1,v1,v3
vle8.v v3,0(a7)
vadd.vv v1,v1,v2
vle8.v v2,0(a5)
vadd.vv v1,v1,v3
vadd.vv v1,v1,v2
vse8.v v1,0(a0)
ret
.cfi_endproc
If I understand correctly, this is wrong since we aren't returning
anything (nothing gets stored in a[0-1])?
Edwin
next prev parent reply other threads:[~2024-02-03 0:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 2:57 juzhe.zhong
2024-02-01 5:42 ` Edwin Lu
2024-02-01 5:42 ` Edwin Lu
2024-02-01 6:13 ` Edwin Lu
2024-02-01 6:42 ` juzhe.zhong
2024-02-01 6:55 ` juzhe.zhong
2024-02-01 7:05 ` juzhe.zhong
2024-02-01 7:29 ` Li, Pan2
2024-02-01 17:43 ` Edwin Lu
2024-02-01 17:43 ` Edwin Lu
2024-02-02 3:56 ` Li, Pan2
2024-02-02 4:28 ` Li, Pan2
2024-02-03 0:29 ` Edwin Lu [this message]
2024-02-03 0:29 ` Edwin Lu
2024-02-03 7:10 ` Li, Pan2
2024-02-05 18:42 ` Edwin Lu
2024-02-05 18:42 ` Edwin Lu
2024-02-15 9:25 ` Li, Pan2
2024-02-15 17:29 ` Edwin Lu
2024-02-15 17:29 ` Edwin Lu
2024-02-01 17:57 ` Edwin Lu
2024-02-01 17:57 ` Edwin Lu
-- strict thread matches above, loose matches on Subject: below --
2024-01-12 18:08 [PATCH V3 0/4] RISC-V: Associate typed insns to dfa reservation Edwin Lu
2024-01-12 18:08 ` [PATCH V3 1/4] RISC-V: Add non-vector types to dfa pipelines Edwin Lu
2024-01-25 17:06 ` Robin Dapp
2024-02-01 1:41 ` [COMMITTED " Edwin Lu
2024-02-01 1:41 ` Edwin Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5613b194-1af3-4a18-9079-4a9baec0b6e1@rivosinc.com \
--to=ewlu@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=kito.cheng@gmail.com \
--cc=palmer@rivosinc.com \
--cc=patrick@rivosinc.com \
--cc=rdapp.gcc@gmail.com \
--cc=vineetg@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).