From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id DEB5E3858C78 for ; Thu, 8 Feb 2024 18:36:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DEB5E3858C78 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DEB5E3858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=63.228.1.57 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707417370; cv=none; b=HB+kLtIUijtztLPqyUiLjmT9jYONs3cT0iAuBJnAAawDViPTKU/8YDd4FEoXVSqzW6C2yPXSbF8DaRYQmEkJFwEJ7Y+c5XD3UVGdvyPRljiMtfuVBEOrRF4/Jc9HMdRArvnnYUWoZzwh9SOeKHD0tEgM8SkS6vvyPdE3qTJ620A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707417370; c=relaxed/simple; bh=hhjo1JixIXwMUlOdpc0upcgsLoyzp39A1PYcM5/jmjk=; h=Date:From:To:Subject:Message-ID:Mime-Version; b=rRhmo3W9YVXMnNxUnbF0IgdAHyf4EZc6BFHOZ7rAOkTooI0aSrzCSdeYNL2YwfTNcea2i/jXf+JFQs37xYGRpPS2v/Z2icnXVpGaUotFPUuK63mTwJwnPrB61bGQAuyPdva7opabb25TunAePLW4pxYr5w50XKVqp5JgY1QcRlo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 418IZ8dN018340; Thu, 8 Feb 2024 12:35:08 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 418IZ7Wm018339; Thu, 8 Feb 2024 12:35:07 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Thu, 8 Feb 2024 12:35:07 -0600 From: Segher Boessenkool To: Michael Meissner , "Kewen.Lin" , gcc-patches@gcc.gnu.org, David Edelsohn , Peter Bergner Subject: Re: Repost [PATCH 1/6] Add -mcpu=future Message-ID: <20240208183507.GT19790@gate.crashing.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Feb 06, 2024 at 01:01:52AM -0500, Michael Meissner wrote: > > Nit: Named as "ISA_FUTURE_MASKS_SERVER" seems more accurate as it's constituted > > with ISA_3_1_MASKS_**SERVER** ... > > Well the _SERVER stuff was due to the power7 days when we still had to support > the E500 in the main rs6000 tree. But I will change it to be more consistant > in the future patches. "_SERVER" still is a good shortish name for the server systems ;-) > > > @@ -67,7 +67,9 @@ enum processor_type > > > PROCESSOR_MPCCORE, > > > PROCESSOR_CELL, > > > PROCESSOR_PPCA2, > > > - PROCESSOR_TITAN > > > + PROCESSOR_TITAN, > > > + > > > > Nit: unintentional empty line? > > > > > + PROCESSOR_FUTURE > > > }; > > It was more as a separation. The MPCCORE, CELL, PPCA2, and TITAN are rather > old processors. I don't recall why we kept them after the POWER. Please don't add random separations. > Logically we should re-order the list and move MPCCORE, etc. earlier, but I > will delete the blank line in future patches. Don't randomly reorder, either. _FUTURE should be added after POWER11. > > I think we should also update asm_names in driver-rs6000.cc. > > Ok. Though the driver-rs6000.cc stuff won't kick in until we have a real > system that matches "future". Or when during development you have that faked. You did test it, right? :-) Segher