* [PATCH V2] RISC-V: Specify mtune and march for PR113742
@ 2024-02-20 22:03 Edwin Lu
2024-02-21 1:36 ` Kito Cheng
0 siblings, 1 reply; 3+ messages in thread
From: Edwin Lu @ 2024-02-20 22:03 UTC (permalink / raw)
To: gcc-patches; +Cc: gnu-toolchain, rdapp.gcc, monk.chiang, Edwin Lu
The testcase pr113742.c is failing for 32 bit targets due to the following cc1
error:
cc1: error: ABI requries '-march=rv64'
Specify '-march=rv64gc' with '-mtune=sifive-p600-series'
V1: https://gcc.gnu.org/pipermail/gcc-patches/2024-February/645609.html
PR target/113742
gcc/testsuite/ChangeLog:
* gcc.target/riscv/pr113742.c: change mcpu to mtune and add march
Signed-off-by: Edwin Lu <ewlu@rivosinc.com>
---
V1: use require-effective-target
V2: switch to specifying march and mtune
---
gcc/testsuite/gcc.target/riscv/pr113742.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.target/riscv/pr113742.c b/gcc/testsuite/gcc.target/riscv/pr113742.c
index ab8934c2a8a..573afd6f0ad 100644
--- a/gcc/testsuite/gcc.target/riscv/pr113742.c
+++ b/gcc/testsuite/gcc.target/riscv/pr113742.c
@@ -1,4 +1,4 @@
-//* { dg-do compile } */
-/* { dg-options "-O2 -finstrument-functions -mabi=lp64d -mcpu=sifive-p670" } */
+/* { dg-do compile } */
+/* { dg-options "-O2 -finstrument-functions -march=rv64gc -mabi=lp64d -mtune=sifive-p600-series" } */
void foo(void) {}
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH V2] RISC-V: Specify mtune and march for PR113742
2024-02-20 22:03 [PATCH V2] RISC-V: Specify mtune and march for PR113742 Edwin Lu
@ 2024-02-21 1:36 ` Kito Cheng
2024-02-21 17:41 ` [Committed " Edwin Lu
0 siblings, 1 reply; 3+ messages in thread
From: Kito Cheng @ 2024-02-21 1:36 UTC (permalink / raw)
To: Edwin Lu; +Cc: gcc-patches, gnu-toolchain, rdapp.gcc, monk.chiang
LGTM, thanks for fixing that issue :)
On Wed, Feb 21, 2024 at 6:03 AM Edwin Lu <ewlu@rivosinc.com> wrote:
>
> The testcase pr113742.c is failing for 32 bit targets due to the following cc1
> error:
> cc1: error: ABI requries '-march=rv64'
>
> Specify '-march=rv64gc' with '-mtune=sifive-p600-series'
>
> V1: https://gcc.gnu.org/pipermail/gcc-patches/2024-February/645609.html
>
> PR target/113742
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/riscv/pr113742.c: change mcpu to mtune and add march
>
> Signed-off-by: Edwin Lu <ewlu@rivosinc.com>
> ---
> V1: use require-effective-target
> V2: switch to specifying march and mtune
> ---
> gcc/testsuite/gcc.target/riscv/pr113742.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/riscv/pr113742.c b/gcc/testsuite/gcc.target/riscv/pr113742.c
> index ab8934c2a8a..573afd6f0ad 100644
> --- a/gcc/testsuite/gcc.target/riscv/pr113742.c
> +++ b/gcc/testsuite/gcc.target/riscv/pr113742.c
> @@ -1,4 +1,4 @@
> -//* { dg-do compile } */
> -/* { dg-options "-O2 -finstrument-functions -mabi=lp64d -mcpu=sifive-p670" } */
> +/* { dg-do compile } */
> +/* { dg-options "-O2 -finstrument-functions -march=rv64gc -mabi=lp64d -mtune=sifive-p600-series" } */
>
> void foo(void) {}
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Committed V2] RISC-V: Specify mtune and march for PR113742
2024-02-21 1:36 ` Kito Cheng
@ 2024-02-21 17:41 ` Edwin Lu
0 siblings, 0 replies; 3+ messages in thread
From: Edwin Lu @ 2024-02-21 17:41 UTC (permalink / raw)
To: Kito Cheng; +Cc: gcc-patches, gnu-toolchain, rdapp.gcc, monk.chiang
Committed
Edwin
On 2/20/2024 5:36 PM, Kito Cheng wrote:
> LGTM, thanks for fixing that issue :)
>
> On Wed, Feb 21, 2024 at 6:03 AM Edwin Lu <ewlu@rivosinc.com> wrote:
>> The testcase pr113742.c is failing for 32 bit targets due to the following cc1
>> error:
>> cc1: error: ABI requries '-march=rv64'
>>
>> Specify '-march=rv64gc' with '-mtune=sifive-p600-series'
>>
>> V1: https://gcc.gnu.org/pipermail/gcc-patches/2024-February/645609.html
>>
>> PR target/113742
>>
>> gcc/testsuite/ChangeLog:
>>
>> * gcc.target/riscv/pr113742.c: change mcpu to mtune and add march
>>
>> Signed-off-by: Edwin Lu <ewlu@rivosinc.com>
>> ---
>> V1: use require-effective-target
>> V2: switch to specifying march and mtune
>> ---
>> gcc/testsuite/gcc.target/riscv/pr113742.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gcc/testsuite/gcc.target/riscv/pr113742.c b/gcc/testsuite/gcc.target/riscv/pr113742.c
>> index ab8934c2a8a..573afd6f0ad 100644
>> --- a/gcc/testsuite/gcc.target/riscv/pr113742.c
>> +++ b/gcc/testsuite/gcc.target/riscv/pr113742.c
>> @@ -1,4 +1,4 @@
>> -//* { dg-do compile } */
>> -/* { dg-options "-O2 -finstrument-functions -mabi=lp64d -mcpu=sifive-p670" } */
>> +/* { dg-do compile } */
>> +/* { dg-options "-O2 -finstrument-functions -march=rv64gc -mabi=lp64d -mtune=sifive-p600-series" } */
>>
>> void foo(void) {}
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-21 17:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-20 22:03 [PATCH V2] RISC-V: Specify mtune and march for PR113742 Edwin Lu
2024-02-21 1:36 ` Kito Cheng
2024-02-21 17:41 ` [Committed " Edwin Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).