From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CHN02-BJS-obe.outbound.protection.partner.outlook.cn (mail-bjschn02on2116.outbound.protection.partner.outlook.cn [139.219.17.116]) by sourceware.org (Postfix) with ESMTPS id 360713858D35 for ; Thu, 7 Mar 2024 05:54:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 360713858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=starfivetech.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=starfivetech.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 360713858D35 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=139.219.17.116 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1709790858; cv=pass; b=X1LWM3J+sFDiD9GFYhdmfldkgNOGN/h7VNZ/G+cQYT8Dzd/EquOuLNWU5/Yk8N2B/wE8kUYrh/Sna5ejKpBnIfiaZOrxYC7EdFThUD9PzGB5LADCj+ouK64i16Pt53VQR4MBZbM1bvp3X+XsnRsflCB8YnxzVdR+UmmrGRSYmYk= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1709790858; c=relaxed/simple; bh=wpYSPjH5xjrs2wdPmWvCu9PhyjYcRs+wRvEN+xJiD0Y=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=GvMw8zE5RbSy0Meoyl5IPmooN0lHs52Xk80YDydfDJPdzCBypnV34RwSvamviHP1wzWnYumlV4EEXTd99bjIanKedHu1MDe3QYaLf+MN/WEHyb4Ozv7YmbUfw4ChAtUA+eZ2AbJOfd96y2VRLIw5ISOFkV4nHy/q8jI6KKyE2jI= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NGUgEGzFwvmxlsfBc1/jK1ZInhEFsI92mdWz0uBg6Q9TyPnX4Nv69+ndsOME3GxHNGYUOtdEKCzH9yjgPli1td8sNWjPdn+N4O2cTSEMXpx0h/TWAcsS/HXjtN8D2ewegJnI54es6U6GUJzjR6r5ZAgua9OIPbgThKK657eeVHkU2NjJsj5PCxPlyXU+p4Jof3BWFFFrb6TEq+WswGzgNya8ac5jvEB8nJytFc7oxbSb9j+DETMOFAay3S6QyWQo2eBEuUChSaiIP0iahIXnax4dm6lDnhRVw7nCaqDti0TxeRFVbA5IE12BjHYh80cvW7f2ersKz14ow7bIWdUckQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vzZyrgF9cOY52N5kwKO1lYsJChZdsL2s2y0bL1oKabU=; b=WGrZThuLA11T93GDvq47veBoouy892dBWeQ3O0Ahuttnx1/7FXdc00mkNuR3LN5oGYiDAN1kAirUMkFAaD00Inqw77tiXQdMZYOyXY/Ahy/mB8jZWbXRk0EfGVtPa5Oeg/klD/IjEkA1g4WORwht2IM4izLI97Dkml/AwSfBHYKo1YlJrQqz9ESmXYBqkEUH0PNpO52PmfYN0i1HhBGv3TKU3CPDFXp1lqYon1mf31YdFwWTckMSXllNl2wtL3O5DEwogtjqmx8tf9S6LdBhOJifJA/t7CHxqlXtPu80+s7iwGtH6FKmON95+cU8fkmZSPmly0pT6pan1XOmF/rkRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=starfivetech.com; dmarc=pass action=none header.from=starfivetech.com; dkim=pass header.d=starfivetech.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=starfivetech.com; Received: from ZQ0PR01MB1063.CHNPR01.prod.partner.outlook.cn (2406:e500:c550:d::13) by ZQ0PR01MB1078.CHNPR01.prod.partner.outlook.cn (2406:e500:c550:d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.36; Thu, 7 Mar 2024 05:54:11 +0000 Received: from ZQ0PR01MB1063.CHNPR01.prod.partner.outlook.cn ([fe80::a5c8:6d3:34b7:3edc]) by ZQ0PR01MB1063.CHNPR01.prod.partner.outlook.cn ([fe80::a5c8:6d3:34b7:3edc%6]) with mapi id 15.20.7316.046; Thu, 7 Mar 2024 05:54:11 +0000 From: "demin.han" To: gcc-patches@gcc.gnu.org Cc: juzhe.zhong@rivai.ai, kito.cheng@gmail.com, pan2.li@intel.com, jeffreyalaw@gmail.com Subject: [PATCH] RISC-V: Fix ICE in riscv vector costs Date: Thu, 7 Mar 2024 13:54:18 +0800 Message-ID: <20240307055418.317521-1-demin.han@starfivetech.com> X-Mailer: git-send-email 2.44.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: BJSPR01CA0015.CHNPR01.prod.partner.outlook.cn (2406:e500:c211:c::27) To ZQ0PR01MB1063.CHNPR01.prod.partner.outlook.cn (2406:e500:c550:d::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ZQ0PR01MB1063:EE_|ZQ0PR01MB1078:EE_ X-MS-Office365-Filtering-Correlation-Id: 4feb0bbc-83bc-4fd6-11ff-08dc3e6b027b X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YU9D93PX6FQu2RRG0yFed6jUf7OFLFg/fONh3KaltiP7oKIHnL/V8twCWfg0jhA4GozBO54kJyQOdS3+ecBEt7A1hsGIwAkUczEt+kfdh1t8L3JyensX7w05dk2J7enjZFHtfO/TcBPygVFQsVmfKxjozs7fhFTZ1nmMgZ4TSj3pyb+64EfihfpfzaSlmiT59j7J8NFfgjCL+XYWuapOCA1m4h7jwiBpAecZcdZRej6UvycyhT595ljfT3lLouYKIK+CYb689f3Kt2jSOn1hgeJEUzb7q7yEvNYhmx2uSRuQngxzXfPBlnMjAk5hXNhjulfm96tL9UgByqXNntUjei5mUucxtDR3t2cX7C8Uu2CetcFxWyLmPnCGwrVhD0n2LNp8WTRG/DYwATemS33kL51C+E1oIiOzWj2TfDi43zXjAvgsqAzwbIndtJpru6omyTNL7uap9FmKIbWNkSg5L+veV8HUPH8tDmd+4Fv+0WXG4d0WCvTFfwjiVOxl84KWVFAa+QLmRBJE1taufN0zrdQSH4BbwKyeHJlUILaST+E3gBRPcDpBXroHklyakzKWiltQt1y0VfLu1CPbXQtMNLuEWZoofzTg6Ugc63aDvQCste6ikNkguv45zB6q2VQK X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:ZQ0PR01MB1063.CHNPR01.prod.partner.outlook.cn;PTR:;CAT:NONE;SFS:(13230031)(41320700004)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?w5+VQkvaMKRdhzDRSQt88OCd4W84wYI+e3nWuCY+AtKGoyST+uwhdbrAspBx?= =?us-ascii?Q?R8U3azSMxltTplbeEPXTecr34sLqhwOSfcuhgdqQONifNK9ekKxcoYx+8bH0?= =?us-ascii?Q?jrvuQKj+T8ZafSJuzXJDIWLLjB0WTii4RcVWYMe6jJ4N/cMJPMym05Rao3MW?= =?us-ascii?Q?Ybvkf1wA8VDaTfe6d5OKzBQH0K8BRKyXJ1ArYhyzt4fphSvO5f9GBIO82JLI?= =?us-ascii?Q?5mbyGG/H/Lf86COwcgprqsgnoEp/cp64ez7v59e0gGBziIrlyLhw4bukQwrt?= =?us-ascii?Q?AZcW8sT+eDX0kUvJN3NwgGyzWJCtjw5GkLSJUalwCyuE1gCJQOKxxHV1y50r?= =?us-ascii?Q?VWdEsjy1Dm+kG//GwiOVe6MKpgwhQiTq4C/QvbDljmOW0S3cq9f2VJ0nMYqy?= =?us-ascii?Q?le/FTAuPLRlf3HtaMlni17eRCo31oKpXgA0XDKkRGwQgVIPoL+jKNTTVsPrZ?= =?us-ascii?Q?B+UWLyDJy/vZg6A8GHEQr9UuKqYUNYqr4B7ssBFyyL4N5leVvGkuB+YGG9Z1?= =?us-ascii?Q?Xi0gToHC85vrMRoQ6N92FWqJ76wzrtPTS5XERySxC3knFuBaKp5f5Y237Lbb?= =?us-ascii?Q?i+Mt7yCRiO/fapU/v76M4oEXiVZHXW1s2Lgfc7ZSox6+t6KLf+Off+WoTydq?= =?us-ascii?Q?nlhQR/WaPtF4yd6x+RB9be30Svf8H/vZ8URbBsEUv/dh7cF9E8bB6DpSBRuv?= =?us-ascii?Q?W55lxyWbMZbNuT+jn2j8xFQB73sOruGXC6jGe5oRf2jYpz2iWewYzJGHZ17+?= =?us-ascii?Q?JBAs5ptPMaupS6xNkFNYQAgJEt2yFyodrYkLSjNF4909S8iI4jrDYj1N+ONy?= =?us-ascii?Q?zbpN8NxFHvpYY6EhYyuioRp1urimNbEFiVwxXa/959rxRfECr5KrDb9uSdV9?= =?us-ascii?Q?wSdwe9FI1RKdAVUTdYkum5I1G+OVFKu8IS2t2lpNkvVOLA4Qxx17xjRMHSxS?= =?us-ascii?Q?Jpbyl/hpYrNGhbE4DeXNvWwXAjgLV5/kwJpop13Yo34Rr+Jz7dKpiL29G9fI?= =?us-ascii?Q?WxhirLWXs+u08C5d2XKIt/JUKnLGMdb8/dHEDXIYpb3fngm7xILWI7czsqnF?= =?us-ascii?Q?l/za9BnsZqMjy0p+i/Ni2HS8kNGo5Kd0SpGDXaZTVep/J0v+gvmFiuGMYHXe?= =?us-ascii?Q?DpTQPeJ6+SGV1QcqZjWNF6m8Vyn9HZQ2map+OWZ7tee6A8fzr1Q8zr1zaRep?= =?us-ascii?Q?EruO0JClk+3VE7nFw3aESksy73WlUBSXGy/RCJGi8sULnZbP7c6nRt5c+V6C?= =?us-ascii?Q?O0yNRk7fk+XX3q3CZZkP0i7xPk6GyQ8po7qP4wZyYnoGxI/Q8BxEfqXVZ7OB?= =?us-ascii?Q?iyt2ucIQPqDHgz8Pe+wpPfKlPLGczG7VkYCDhk9uUmmJopJwRyErdfg6LEtc?= =?us-ascii?Q?Z6RC/Ol+zbg3gS1x7W5pw8UyZZ0LTrqKCHvnQ07/aLhf6nZA9edf0EptBRfp?= =?us-ascii?Q?LRcfVC4tDdm3cgwdUMtqt74Eywn31Yapzi+2mD+6wW2MvkQzRcSZ0QalJbJs?= =?us-ascii?Q?F+KUOOXjh2nunYCNdM0KLUMsS7+yiJQy94wb8dXT2sw87dSUphB2MNkrM2Ul?= =?us-ascii?Q?fUBYLU7vc/zt55+vZ1OTiL48iLDR2ZgYYB92fwhghtRzv7tL8az1MqGNdfSv?= =?us-ascii?Q?3A=3D=3D?= X-OriginatorOrg: starfivetech.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4feb0bbc-83bc-4fd6-11ff-08dc3e6b027b X-MS-Exchange-CrossTenant-AuthSource: ZQ0PR01MB1063.CHNPR01.prod.partner.outlook.cn X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 05:54:10.9420 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 06fe3fa3-1221-43d3-861b-5a4ee687a85c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wU4d7/w1qs1V7IUM+UmbKU7vGQP3clDCzn/uGGmtmfiknITUDapqWgBo2Y3PO/PPFGSLeTlZUDtHnOGhd9R9Zz9GHL20ldN48Bi6q/La9Po= X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZQ0PR01MB1078 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The following code can result in ICE: -march=rv64gcv_zba_zbb --param riscv-autovec-lmul=dynamic -O3 char *jpeg_difference7_input_buf; void jpeg_difference7(int *diff_buf) { unsigned width; int samp, Rb; while (--width) { Rb = samp = *jpeg_difference7_input_buf; *diff_buf++ = -(int)(samp + (long)Rb >> 1); } } One biggest_mode update missed in one branch and trigger assertion fail. gcc_assert (biggest_size >= mode_size); Tested On RV64 and no regression. gcc/ChangeLog: * config/riscv/riscv-vector-costs.cc: Fix ICE Signed-off-by: demin.han --- gcc/config/riscv/riscv-vector-costs.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/config/riscv/riscv-vector-costs.cc b/gcc/config/riscv/riscv-vector-costs.cc index 7c9840df4e9..f13a1296b31 100644 --- a/gcc/config/riscv/riscv-vector-costs.cc +++ b/gcc/config/riscv/riscv-vector-costs.cc @@ -413,6 +413,8 @@ compute_local_live_ranges ( auto *r = get_live_range (live_ranges, arg); gcc_assert (r); (*r).second = MAX (point, (*r).second); + biggest_mode = get_biggest_mode ( + biggest_mode, TYPE_MODE (TREE_TYPE (arg))); } } else -- 2.44.0