From: Segher Boessenkool <segher@kernel.crashing.org>
To: Richard Biener <rguenther@suse.de>
Cc: Jakub Jelinek <jakub@redhat.com>, Uros Bizjak <ubizjak@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Jeff Law <jeffreyalaw@gmail.com>
Subject: Re: [PATCH v2] combine: Fix ICE in try_combine on pr112494.c [PR112560]
Date: Thu, 7 Mar 2024 11:49:13 -0600 [thread overview]
Message-ID: <20240307174913.GJ19790@gate.crashing.org> (raw)
In-Reply-To: <p26147s2-9017-8733-n456-19o50s1862o6@fhfr.qr>
On Thu, Mar 07, 2024 at 11:45:45AM +0100, Richard Biener wrote:
> The question is, whether a NULL cc_use_loc (find_single_use returning
> NULL) means "there is no use" or it can mean "huh, don't know, maybe
> more than one, maybe I was too stupid to indentify the single use".
> The implementation suggests it's all broken ;)
It specifically means there is not a *single* use (or it could not find
what it was, perhaps). It does not mean there is no use. There is not
much in combine that cares about dead code anyway, earier passes should
have taken care of that ;-)
All as documented.
Segher
next prev parent reply other threads:[~2024-03-07 17:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 9:16 Uros Bizjak
2024-03-07 9:55 ` Richard Biener
2024-03-07 10:11 ` Uros Bizjak
2024-03-07 10:22 ` Richard Biener
2024-03-07 17:44 ` Segher Boessenkool
2024-03-07 10:37 ` Jakub Jelinek
2024-03-07 10:45 ` Richard Biener
2024-03-07 11:22 ` Uros Bizjak
2024-03-07 17:51 ` Segher Boessenkool
2024-03-07 17:49 ` Segher Boessenkool [this message]
2024-03-07 10:57 ` Uros Bizjak
2024-03-07 17:36 ` Segher Boessenkool
2024-03-07 21:04 ` Uros Bizjak
2024-03-07 21:08 ` Uros Bizjak
2024-03-07 21:35 ` Segher Boessenkool
2024-03-07 22:07 ` Uros Bizjak
2024-03-07 22:27 ` Segher Boessenkool
2024-03-07 22:46 ` Uros Bizjak
2024-03-18 14:49 ` Segher Boessenkool
2024-03-18 15:44 ` Uros Bizjak
2024-03-07 22:27 ` Uros Bizjak
2024-03-18 14:44 ` Segher Boessenkool
2024-03-18 15:29 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307174913.GJ19790@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jeffreyalaw@gmail.com \
--cc=rguenther@suse.de \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).