From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id C9D753858C36 for ; Thu, 7 Mar 2024 17:50:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C9D753858C36 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C9D753858C36 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=63.228.1.57 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709833816; cv=none; b=KPh3eRJ4cW8RH69JyNsLBkfPwfNFMnOgAxq7toy1WAcSlQkuwcCRosp/ADzQ7qMSO9c/9+dSFJ6CmkXW0ceE0eHv9yxp/a4a9NoDvB/RkTGvb/WiYi1T2XEHLDhrMt+UWL/jMk5OESWksOfwOVGtAkwSbL4VCtYgNjkvqrOYV3M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709833816; c=relaxed/simple; bh=8nnDaJLsrSUnFLmzuV/rPjsmCBf9DSvQYKz+7U773Ps=; h=Date:From:To:Subject:Message-ID:Mime-Version; b=H53jp/eSgBw79Ba3XEwI15mKhe69xxI06jtrEJHeOUOe0WuMuyjoEq9h6Bo/vxOgGrQT4XJg+e8Irk9WDpd4wHgfb7qVDPTtPFxig8H6A4OHvHcYP3sNYU2nNhCHWLs7Map8O9nL9vG0g74OiQ2EBddO338wHBYUrUq+iprfwqg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 427HnE97006796; Thu, 7 Mar 2024 11:49:14 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 427HnDGu006795; Thu, 7 Mar 2024 11:49:13 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Thu, 7 Mar 2024 11:49:13 -0600 From: Segher Boessenkool To: Richard Biener Cc: Jakub Jelinek , Uros Bizjak , "gcc-patches@gcc.gnu.org" , Jeff Law Subject: Re: [PATCH v2] combine: Fix ICE in try_combine on pr112494.c [PR112560] Message-ID: <20240307174913.GJ19790@gate.crashing.org> References: <2737spr1-459p-3oon-n852-qn034s55p66r@fhfr.qr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Mar 07, 2024 at 11:45:45AM +0100, Richard Biener wrote: > The question is, whether a NULL cc_use_loc (find_single_use returning > NULL) means "there is no use" or it can mean "huh, don't know, maybe > more than one, maybe I was too stupid to indentify the single use". > The implementation suggests it's all broken ;) It specifically means there is not a *single* use (or it could not find what it was, perhaps). It does not mean there is no use. There is not much in combine that cares about dead code anyway, earier passes should have taken care of that ;-) All as documented. Segher