From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 01C6D3857709 for ; Thu, 7 Mar 2024 17:52:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01C6D3857709 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 01C6D3857709 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=63.228.1.57 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709833958; cv=none; b=foWmUJxIe0ZyHGyrL4aHMiiMlKUo0iYyN736jkV/OBEWPmph8Eu5gvsGy9bK3uWerbvW7m6Q77WMAN71wzv2ksv8pKhDk4iG2nCmoAQGQ4Ckv9vFi5u2Ooz3VS3UcewBZl1yLPlT9oqsXB/LUae9jS3+KCC70YckG+yHTX4cr0s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709833958; c=relaxed/simple; bh=2KjPcL26aO8iYSirH/KA0eCEmYLp6bouMNTJM8jhKKk=; h=Date:From:To:Subject:Message-ID:Mime-Version; b=B6d0mtiJGDwQD99zsu9zMMiLvIVYTAb1HdHE8J68YqSdOZRXDg+qshj+K0KQQcy8RPJdH79fPVQnnt2iJHtD0j2HXyff6w3+RFlBNBnB2Fx7X0pc7oGggoiMSrfrVPLpsDUw2yRyMF8yiE2q7aGSgMTImMgz3i+jD/vOSQrbwho= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 427Hpa1l006962; Thu, 7 Mar 2024 11:51:36 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 427HpaRe006961; Thu, 7 Mar 2024 11:51:36 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Thu, 7 Mar 2024 11:51:35 -0600 From: Segher Boessenkool To: Uros Bizjak Cc: Richard Biener , Jakub Jelinek , "gcc-patches@gcc.gnu.org" , Jeff Law Subject: Re: [PATCH v2] combine: Fix ICE in try_combine on pr112494.c [PR112560] Message-ID: <20240307175135.GK19790@gate.crashing.org> References: <2737spr1-459p-3oon-n852-qn034s55p66r@fhfr.qr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Mar 07, 2024 at 12:22:04PM +0100, Uros Bizjak wrote: > As I understood find_single_use, it is returning RTX iff DEST is used > only a single time in an insn sequence following INSN. Connected by a log_link even, yeah. > We can reject the combination without worries of multiple uses. Yup. That is the whole point of find_single_use: if that test fails, combine knows to get its paws off :-) Segher