From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id AE9FE3858CD1 for ; Tue, 12 Mar 2024 01:57:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AE9FE3858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AE9FE3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710208643; cv=none; b=YRAD6JTqOaNQsmjZLpW6TVzlvgM86l/9seQboOEdjSS/Php//gLrCV96VvKGvM3KpdkKRmFE2vsdQ7LVIF1ZzCdLGSLgIT+3d1g8QDaq/a8TE2wmaEjRRHi1j3hNdc7r6AIS2KdcIgYJweE2xgaHJaOVp0gaJB2U70/XTK6Aozo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710208643; c=relaxed/simple; bh=42obIFMAMA63Yma4U3c5/Jrxh3y9a8GOWPbN4j4gFls=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=nZ/a0bahZ7irwWXndptcbV01Hod4RxpJt2NcSDM+9C6E4MahN0Wa2GZTNwErACbBAYCWKm6XDmEH6tSZjUKN/I8RmFnlRTF6iUdu2/uO2Ul97om6xIuOmTW0XZSdj6aPdpFxsRf2ueQYFbftvHqSOxuesKUV8g20+BvGaOGesYQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.2.6.5]) by gateway (Coremail) with SMTP id _____8CxXOl8tu9lRGUXAA--.47681S3; Tue, 12 Mar 2024 09:57:16 +0800 (CST) Received: from 5.5.5 (unknown [10.2.6.5]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxXRN0tu9lDbtWAA--.32157S4; Tue, 12 Mar 2024 09:57:13 +0800 (CST) From: Chenghui Pan To: gcc-patches@gcc.gnu.org Cc: xry111@xry111.site, i@xen0n.name, chenglulu@loongson.cn, xuchenghua@loongson.cn, Chenghui Pan Subject: [PATCH v1] LoongArch: Remove masking process for operand 3 of xvpermi.q. Date: Tue, 12 Mar 2024 09:56:58 +0800 Message-Id: <20240312015658.2400338-1-panchenghui@loongson.cn> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:AQAAf8BxXRN0tu9lDbtWAA--.32157S4 X-CM-SenderInfo: psdquxxhqjx33l6o00pqjv00gofq/1tbiAQANBGXtb2YFFAAGse X-Coremail-Antispam: 1Uk129KBj93XoWxCryxGw1rXrWkCr1UKF1kCrX_yoW5tr4fpw 1UuF1Skw4IkFW8Ka4Dt3yaqr4UArsFka47WF4293srC3ZFgF1jqF1SyrZFy3WDJayYq3W3 XFWrZw10qF1UCwcCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUkYb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x 0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E 7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcV C0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF 04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7 CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU8czVUUUUUU== X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The behavior of non-zero unused bits in xvpermi.q instruction's third operand is undefined on LoongArch, according to our discussion (https://github.com/llvm/llvm-project/pull/83540), we think that keeping original insn operand as unmodified state is better solution. This patch partially reverts 7b158e036a95b1ab40793dd53bed7dbd770ffdaf. gcc/ChangeLog: * config/loongarch/lasx.md: Remove masking of operand 3. gcc/testsuite/ChangeLog: * gcc.target/loongarch/vector/lasx/lasx-xvpermi_q.c: Reposition operand 3's value into instruction's defined accept range. --- gcc/config/loongarch/lasx.md | 5 ----- .../gcc.target/loongarch/vector/lasx/lasx-xvpermi_q.c | 6 +++--- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/gcc/config/loongarch/lasx.md b/gcc/config/loongarch/lasx.md index ac84db7f0ce..3f25c0c1756 100644 --- a/gcc/config/loongarch/lasx.md +++ b/gcc/config/loongarch/lasx.md @@ -640,8 +640,6 @@ (define_insn "lasx_xvpermi_d__1" (set_attr "mode" "")]) ;; xvpermi.q -;; Unused bits in operands[3] need be set to 0 to avoid -;; causing undefined behavior on LA464. (define_insn "lasx_xvpermi_q_" [(set (match_operand:LASX 0 "register_operand" "=f") (unspec:LASX @@ -651,9 +649,6 @@ (define_insn "lasx_xvpermi_q_" UNSPEC_LASX_XVPERMI_Q))] "ISA_HAS_LASX" { - int mask = 0x33; - mask &= INTVAL (operands[3]); - operands[3] = GEN_INT (mask); return "xvpermi.q\t%u0,%u2,%3"; } [(set_attr "type" "simd_splat") diff --git a/gcc/testsuite/gcc.target/loongarch/vector/lasx/lasx-xvpermi_q.c b/gcc/testsuite/gcc.target/loongarch/vector/lasx/lasx-xvpermi_q.c index dbc29d2fb22..f89dfc31120 100644 --- a/gcc/testsuite/gcc.target/loongarch/vector/lasx/lasx-xvpermi_q.c +++ b/gcc/testsuite/gcc.target/loongarch/vector/lasx/lasx-xvpermi_q.c @@ -27,7 +27,7 @@ main () *((unsigned long*)& __m256i_result[2]) = 0x7fff7fff7fff0000; *((unsigned long*)& __m256i_result[1]) = 0x7fe37fe3001d001d; *((unsigned long*)& __m256i_result[0]) = 0x7fff7fff7fff0000; - __m256i_out = __lasx_xvpermi_q (__m256i_op0, __m256i_op1, 0x2a); + __m256i_out = __lasx_xvpermi_q (__m256i_op0, __m256i_op1, 0x22); ASSERTEQ_64 (__LINE__, __m256i_result, __m256i_out); *((unsigned long*)& __m256i_op0[3]) = 0x0000000000000000; @@ -42,7 +42,7 @@ main () *((unsigned long*)& __m256i_result[2]) = 0x000000000019001c; *((unsigned long*)& __m256i_result[1]) = 0x0000000000000000; *((unsigned long*)& __m256i_result[0]) = 0x00000000000001fe; - __m256i_out = __lasx_xvpermi_q (__m256i_op0, __m256i_op1, 0xb9); + __m256i_out = __lasx_xvpermi_q (__m256i_op0, __m256i_op1, 0x31); ASSERTEQ_64 (__LINE__, __m256i_result, __m256i_out); *((unsigned long*)& __m256i_op0[3]) = 0x00ff00ff00ff00ff; @@ -57,7 +57,7 @@ main () *((unsigned long*)& __m256i_result[2]) = 0xffff0000ffff0000; *((unsigned long*)& __m256i_result[1]) = 0x00ff00ff00ff00ff; *((unsigned long*)& __m256i_result[0]) = 0x00ff00ff00ff00ff; - __m256i_out = __lasx_xvpermi_q (__m256i_op0, __m256i_op1, 0xca); + __m256i_out = __lasx_xvpermi_q (__m256i_op0, __m256i_op1, 0x02); ASSERTEQ_64 (__LINE__, __m256i_result, __m256i_out); return 0; -- 2.39.3