From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id 3A7153858426 for ; Mon, 1 Apr 2024 20:29:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A7153858426 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A7153858426 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=116.202.254.214 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712003352; cv=none; b=ASYO2v6AVltrqn0m8YBder6oiH2hl45VeUpulG7dE0FI+T+n4bl9XgKcNm5PuTycJgOJxmooQ0D652J7wpM8rHnLKR6BULDP6va7Y62OIM2kDOydXawItZ7dPxScw+xBeFmum2jm5KueVfvX5bfTQWaTBoKIalRcwJze2Y+/1+k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712003352; c=relaxed/simple; bh=REYvryo6h9gJmsMRSuXsveanILj58EKG37YES8ctwfw=; h=To:From:Subject:Date:Message-ID:Mime-Version; b=uBwodj+7AN1kUyEqCLmdPIZJur5mC0ecp1+63k1uyyuTznFp64nrQMc9jvQ/2Jv343X7Ub2ZHXvQWCQ+b8u5x8tZE736gbVVWcyv33iys5Ubf3VrC9/HoOng3LTFaDjxf1wQ5KWd7s37/ILNOipUqICR2+rFlMRfg08R2GRaLkg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rrOHF-0006Q8-SO for gcc-patches@gcc.gnu.org; Mon, 01 Apr 2024 22:29:09 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Harald Anlauf Subject: Re: [Patch, fortran] PR106999 [11/12/13/14 Regression] ICE tree check: expected record_type or union_type or qual_union_type, have function_type in gfc_class_data_get, at fortran/trans-expr.cc:233 Date: Mon, 1 Apr 2024 22:29:00 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla Thunderbird Content-Language: en-US In-Reply-To: Cc: fortran@gcc.gnu.org X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_PORT autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20240401202900.oFbo3e64X7kTwWIBW-a5ELoMBd881maVinaAezKkAAs@z> Hi Paul, On 3/31/24 15:01, Paul Richard Thomas wrote: > This regression has a relatively simple fix. The passing of a subroutine > procedure pointer component to a dummy variable was being missed > completely. The error has been added. Conversely, an error was generated > for a procedure pointer variable but no use was being made of the > interface, if one was available. This has been corrected. > > OK for mainline and backporting in a couple of weeks? this is all OK. Thanks for the patch! Harald > Paul > > Fortran: Add error for subroutine passed to a variable dummy [PR106999] > > 2024-03-31 Paul Thomas > > gcc/fortran > PR fortran/106999 > *interface.cc (gfc_compare_interfaces): Add error for a > subroutine proc pointer passed to a variable formal. > (compare_parameter): If a procedure pointer is being passed to > a non-procedure formal arg, and there is an an interface, use > gfc_compare_interfaces to check and provide a more useful error > message. > > gcc/testsuite/ > PR fortran/106999 > * gfortran.dg/pr106999.f90: New test. >