public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Iain Sandoe <iains.gcc@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: [pushed] Darwin: Correct a version check.
Date: Tue,  2 Apr 2024 12:26:07 +0100	[thread overview]
Message-ID: <20240402112607.86615-1-iain@sandoe.co.uk> (raw)

Tested on x86_64-darwin17,21,23, pushed to trunk, thanks,
Iain

--- 8< ---

When the version for dsymutil comes from a clang build, it is
of the form NNmm.pp.qq where NN and mm are the major and minor
LLVM version components.  We need to check for a major version
greater than or equal to 7 - so use 700 in the check.

gcc/ChangeLog:

	* config/darwin.cc (darwin_override_options): Update the
	clang major version value in the dsymutil check.

Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
---
 gcc/config/darwin.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/darwin.cc b/gcc/config/darwin.cc
index c37a1a4756f..63b8c509405 100644
--- a/gcc/config/darwin.cc
+++ b/gcc/config/darwin.cc
@@ -3420,7 +3420,7 @@ darwin_override_options (void)
       /* External toolchains based on LLVM or clang 7+ have support for
 	 dwarf-4.  */
       if ((dsymutil_version.kind == LLVM && dsymutil_version.major >= 7)
-	  || (dsymutil_version.kind == CLANG && dsymutil_version.major >= 7))
+	  || (dsymutil_version.kind == CLANG && dsymutil_version.major >= 700))
 	dwarf_version = 4;
       else if (dsymutil_version.kind == DWARFUTILS
 	       && dsymutil_version.major >= 121)
-- 
2.39.2 (Apple Git-143)


                 reply	other threads:[~2024-04-02 11:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240402112607.86615-1-iain@sandoe.co.uk \
    --to=iains.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iain@sandoe.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).