public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Jørgen Kvalsvik" <j@lambda.is>
To: gcc-patches@gcc.gnu.org
Cc: hjl.tools@gmail.com, rguenther@suse.de, hubicka@ucw.cz,
	ro@CeBiTec.Uni-Bielefeld.DE, "Jørgen Kvalsvik" <j@lambda.is>
Subject: [PATCH 0/2] Condition coverage fixes
Date: Fri,  5 Apr 2024 21:58:29 +0200	[thread overview]
Message-ID: <20240405195831.2728853-1-j@lambda.is> (raw)

Hi,

I propose these fixes for the current issues with the condition
coverage.

Rainer, I propose to simply delete the test with __sigsetjmp. I don't
think it actually detects anything reasonable any more, I kept it around
to prevent a regression. Since then I have built a lot of programs (with
optimization enabled) and not really seen this problem.

H.J., the problem you found with -O2 was really a problem of
tree-inlining, which was actually caught earlier by Jan [1]. It probably
warrants some more testing, but I could reproduce by tuning your test
case to use always_inline and not -O2 and trigger the error.

[1] https://gcc.gnu.org/pipermail/gcc-patches/2024-April/648785.html

Thanks,
Jørgen

Jørgen Kvalsvik (2):
  Remove unecessary and broken MC/DC compile test
  Copy condition->expr map when inlining [PR114599]

 gcc/testsuite/gcc.misc-tests/gcov-19.c       | 11 ---------
 gcc/testsuite/gcc.misc-tests/gcov-pr114599.c | 25 ++++++++++++++++++++
 gcc/tree-inline.cc                           | 20 +++++++++++++++-
 3 files changed, 44 insertions(+), 12 deletions(-)
 create mode 100644 gcc/testsuite/gcc.misc-tests/gcov-pr114599.c

-- 
2.30.2


             reply	other threads:[~2024-04-05 19:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 19:58 Jørgen Kvalsvik [this message]
2024-04-05 19:58 ` [PATCH 1/2] Remove unecessary and broken MC/DC compile test Jørgen Kvalsvik
2024-04-15  8:56   ` Rainer Orth
2024-04-05 19:58 ` [PATCH 2/2] Copy condition->expr map when inlining [PR114599] Jørgen Kvalsvik
2024-04-06  5:50 ` [PATCH 0/2] Condition coverage fixes Richard Biener
2024-04-06 11:15   ` Jørgen Kvalsvik
2024-04-06 20:41     ` Jørgen Kvalsvik
2024-04-07  6:26       ` Richard Biener
2024-04-07  7:28         ` Jørgen Kvalsvik
2024-04-08  6:31 ` Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240405195831.2728853-1-j@lambda.is \
    --to=j@lambda.is \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    --cc=hubicka@ucw.cz \
    --cc=rguenther@suse.de \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).