From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx.kolabnow.com (mx.kolabnow.com [212.103.80.155]) by sourceware.org (Postfix) with ESMTPS id E259A3847725 for ; Fri, 5 Apr 2024 19:58:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E259A3847725 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lambda.is Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lambda.is ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E259A3847725 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.103.80.155 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712347139; cv=none; b=Kc9UB5f6evjxG8f+nYsP+gSZ838YIujYWemppITEh08IzmeO8+kuAusvjBI/CTZkuxOZxpiPwBqG/vqRBCT7O+wRrOg/+agG5eiYEq+PyaYDexvKmAY70El9SaM7J5o4iXY5FF/exnP/dJJY6tJpxVYhz4sbmQR3G79v6KmaK8o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712347139; c=relaxed/simple; bh=h3EEYhoVVCddxdWbXzh7DH3cnkIbRn7y9vIlXUt/lz0=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=RHRTGmiW2LXlQ7KwUdyIgcY72JKEEHqEZmeIsy0qedsMkqlOjQ7lNoL4Y56dyaRNoRWhP3+MmoH9EjcHze2SAYFyVw+NwnviTUrJv/th0o43e2IAuGSJXVauiUEwjfyDeZrylYPtSU7GAbiZJV/k4Vqw2tIKBm6WgwpbY5hlEL0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id EDBA42096DCD; Fri, 5 Apr 2024 21:58:55 +0200 (CEST) Authentication-Results: ext-mx-out011.mykolab.com (amavis); dkim=pass (4096-bit key) reason="pass (just generated, assumed good)" header.d=kolabnow.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:date:date:subject:subject:from:from:received :received:received; s=dkim20160331; t=1712347133; x=1714161534; bh=CmZmXPLCGhB2MvbzyA5SrTIjAJNoUIZEomMGIyao9dM=; b=k6zDldOt/Frl lTDx/mVMfXMINe/xMF0W0TUk7s2V2WRNDr9FYE5/st8iw2IEiQyNu7SUMF76wpQu /iR6+bEXY+k4cAmbntQ5edzcRc0Fe9So3xS7waR/YwY/WwjsSBh4n9tr1pvr6ISq KAK4x7DSV/AIJJiL70AEh6cxaexS81nsIfye/o/qWFBLY1QLZ1BUaPxM23P7hVky fg+2ZRhI90cu8+0nMEusa3z2dIy1cIkJ+zvsl2bPALlJh116SllEHNhWQ7TI6euv I2n2zIgKIESlfoJDv82cs2jdR6nWa/21tohZIh1Ypanm/d4uhJuIdCQvRCCW2HK8 eCe09NszdQMf1cB7hEdfR7MgJBpHfDrUZS9lFPnputeQw6QsUrbvj2sePoGFGHFS FsxNdd0U/kMRXqWrnM1xr9JRjVszTmTZZDDfBIS3jYNZXtuqRcJr3SlJkdVflX3G hQ5qDyJ2jEo9robK0iUE/mTgBbik/nuOlL2StM5UCVLL1CnAP0lsnwPoJhrLBI1s qdWaRzQA1RtgWt9sKYPfoiMIsXaG85QfpaqVXWt/gFNecW3S8Hiu47PdATLd2btE 1qJBlUtxgglgXo1wGCRwnkI1e4+vb8Qd+gS/vHsQJtuRWLXZZMv4+m5c3y5JH60/ uKM5pEkXACrs047uof6XWbgzq3ywLC0= X-Virus-Scanned: amavis at mykolab.com X-Spam-Score: -0.999 X-Spam-Level: X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out011.mykolab.com [127.0.0.1]) (amavis, port 10024) with ESMTP id CbUecxCj5am7; Fri, 5 Apr 2024 21:58:53 +0200 (CEST) Received: from int-mx011.mykolab.com (unknown [10.9.13.11]) by mx.kolabnow.com (Postfix) with ESMTPS id 1EE7B2096DC2; Fri, 5 Apr 2024 21:58:51 +0200 (CEST) Received: from ext-subm010.mykolab.com (unknown [10.9.6.10]) by int-mx011.mykolab.com (Postfix) with ESMTPS id 79D1430FB470; Fri, 5 Apr 2024 21:58:51 +0200 (CEST) From: =?UTF-8?q?J=C3=B8rgen=20Kvalsvik?= To: gcc-patches@gcc.gnu.org Cc: hjl.tools@gmail.com, rguenther@suse.de, hubicka@ucw.cz, ro@CeBiTec.Uni-Bielefeld.DE, =?UTF-8?q?J=C3=B8rgen=20Kvalsvik?= Subject: [PATCH 0/2] Condition coverage fixes Date: Fri, 5 Apr 2024 21:58:29 +0200 Message-Id: <20240405195831.2728853-1-j@lambda.is> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, I propose these fixes for the current issues with the condition coverage. Rainer, I propose to simply delete the test with __sigsetjmp. I don't think it actually detects anything reasonable any more, I kept it around to prevent a regression. Since then I have built a lot of programs (with optimization enabled) and not really seen this problem. H.J., the problem you found with -O2 was really a problem of tree-inlining, which was actually caught earlier by Jan [1]. It probably warrants some more testing, but I could reproduce by tuning your test case to use always_inline and not -O2 and trigger the error. [1] https://gcc.gnu.org/pipermail/gcc-patches/2024-April/648785.html Thanks, Jørgen Jørgen Kvalsvik (2): Remove unecessary and broken MC/DC compile test Copy condition->expr map when inlining [PR114599] gcc/testsuite/gcc.misc-tests/gcov-19.c | 11 --------- gcc/testsuite/gcc.misc-tests/gcov-pr114599.c | 25 ++++++++++++++++++++ gcc/tree-inline.cc | 20 +++++++++++++++- 3 files changed, 44 insertions(+), 12 deletions(-) create mode 100644 gcc/testsuite/gcc.misc-tests/gcov-pr114599.c -- 2.30.2