public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Cc: Jakub Jelinek <jakub@redhat.com>, amacleod@redhat.com
Subject: [PATCH] middle-end/114604 - ranger allocates bitmap without initialized obstack
Date: Mon, 8 Apr 2024 11:49:01 +0200 (CEST)	[thread overview]
Message-ID: <20240408094901.rIPfiMGzVx6h8e-LiIWd3fYYxQpB0VuGOZ03IiMgRNg@z> (raw)

The following fixes ranger bitmap allocation when invoked from IPA
context where the global bitmap obstack possibly isn't initialized.
Instead of trying to use one of the ranger obstacks the following
simply initializes the global bitmap obstack around an active ranger.

Bootstrapped and tested on x86_64-unknown-linux-gnu with bitmap_alloc
instrumentation (all ICEs gone, so ranger was the only offender).

OK?

Thanks,
Richard.

	PR middle-end/114604
	* gimple-range.cc (enable_ranger): Initialize the global
	bitmap obstack.
	(disable_ranger): Release it.
---
 gcc/gimple-range.cc | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gcc/gimple-range.cc b/gcc/gimple-range.cc
index c16b776c1e3..4d3b1ce8588 100644
--- a/gcc/gimple-range.cc
+++ b/gcc/gimple-range.cc
@@ -689,6 +689,8 @@ enable_ranger (struct function *fun, bool use_imm_uses)
 {
   gimple_ranger *r;
 
+  bitmap_obstack_initialize (NULL);
+
   gcc_checking_assert (!fun->x_range_query);
   r = new gimple_ranger (use_imm_uses);
   fun->x_range_query = r;
@@ -705,6 +707,8 @@ disable_ranger (struct function *fun)
   gcc_checking_assert (fun->x_range_query);
   delete fun->x_range_query;
   fun->x_range_query = NULL;
+
+  bitmap_obstack_release (NULL);
 }
 
 // ------------------------------------------------------------------------
-- 
2.35.3

             reply	other threads:[~2024-04-08  9:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08  9:49 Richard Biener [this message]
     [not found] <20240408095018.4853D385841E@sourceware.org>
2024-04-08 15:40 ` Aldy Hernandez
2024-04-08 15:54   ` Jakub Jelinek
2024-04-08 16:08     ` Aldy Hernandez
2024-04-08 16:28       ` Richard Biener
2024-04-08 16:39         ` Aldy Hernandez
2024-04-08 17:47           ` Richard Biener
2024-04-09  5:43             ` Aldy Hernandez
2024-04-09  6:48               ` Richard Biener
2024-06-20  8:08             ` Aldy Hernandez
2024-06-20  9:31               ` Richard Biener
2024-06-20 14:05                 ` Andrew MacLeod
2024-06-20 14:36                   ` Richard Biener
2024-06-26  8:50                     ` Aldy Hernandez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240408094901.rIPfiMGzVx6h8e-LiIWd3fYYxQpB0VuGOZ03IiMgRNg@z \
    --to=rguenther@suse.de \
    --cc=amacleod@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).