public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] Revert "combine: Don't combine if I2 does not change"
@ 2024-04-10  5:59 Richard Biener
  0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2024-04-10  5:59 UTC (permalink / raw)
  To: gcc-patches

This reverts commit 839bc42772ba7af66af3bd16efed4a69511312ae.

I have now pushed the temporary reversion of this to resolve the
P1 regressions this caused.  I'll re-install it on trunk once 14.1
was released (which might be a week or two after stage1 opens).

Richard.

---
 gcc/combine.cc | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/gcc/combine.cc b/gcc/combine.cc
index 71c9abc145c..92b8d98e6c1 100644
--- a/gcc/combine.cc
+++ b/gcc/combine.cc
@@ -4196,17 +4196,6 @@ try_combine (rtx_insn *i3, rtx_insn *i2, rtx_insn *i1, rtx_insn *i0,
       adjust_for_new_dest (i3);
     }
 
-  /* If I2 didn't change, this is not a combination (but a simplification or
-     canonicalisation with context), which should not be done here.  Doing
-     it here explodes the algorithm.  Don't.  */
-  if (rtx_equal_p (newi2pat, PATTERN (i2)))
-    {
-      if (dump_file)
-	fprintf (dump_file, "i2 didn't change, not doing this\n");
-      undo_all ();
-      return 0;
-    }
-
   /* We now know that we can do this combination.  Merge the insns and
      update the status of registers and LOG_LINKS.  */
 
-- 
2.35.3

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-04-10  5:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-10  5:59 [PATCH] Revert "combine: Don't combine if I2 does not change" Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).