From: Segher Boessenkool <segher@kernel.crashing.org>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Jeff Law <jeffreyalaw@gmail.com>,
Richard Biener <rguenther@suse.de>
Subject: Re: Combine patch ping
Date: Wed, 10 Apr 2024 12:52:27 -0500 [thread overview]
Message-ID: <20240410175227.GN19790@gate.crashing.org> (raw)
In-Reply-To: <CAFULd4bzX1sHEsbCV1jLRTuwOPy3ThVirhQsZXBvn_YLYV_+tA@mail.gmail.com>
On Sun, Apr 07, 2024 at 08:31:38AM +0200, Uros Bizjak wrote:
> If there are no further comments, I plan to commit the referred patch
> to the mainline on Wednesday. The latest version can be considered an
> obvious patch that solves certain oversight in the original
> implementation.
This is never okay. You cannot commit a patch without approval, *ever*.
That patch is also obvious -- obviously *wrong*, that is. There are
big assumptions everywhere in the compiler how a CC reg can be used.
This violates that, as explained elsewhere.
Segher
next prev parent reply other threads:[~2024-04-10 17:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 19:28 Uros Bizjak
2024-04-07 6:31 ` Uros Bizjak
2024-04-10 17:52 ` Segher Boessenkool [this message]
2024-04-10 18:32 ` Uros Bizjak
2024-04-11 6:15 ` Richard Biener
2024-04-11 14:00 ` Segher Boessenkool
2024-04-11 14:53 ` Richard Biener
2024-04-11 20:37 ` Uros Bizjak
2024-04-07 8:00 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410175227.GN19790@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=rguenther@suse.de \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).