From: David Malcolm <dmalcolm@redhat.com>
To: gcc-patches@gcc.gnu.org
Cc: David Malcolm <dmalcolm@redhat.com>
Subject: [pushed] analyzer, testuite: comment fixes
Date: Wed, 10 Apr 2024 16:55:55 -0400 [thread overview]
Message-ID: <20240410205555.335678-1-dmalcolm@redhat.com> (raw)
Successfully regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r14-9896-g082374f6570a31.
gcc/testsuite/ChangeLog:
* c-c++-common/analyzer/memset-1.c: Clarify some comments.
Signed-off-by: David Malcolm <dmalcolm@redhat.com>
---
gcc/testsuite/c-c++-common/analyzer/memset-1.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/c-c++-common/analyzer/memset-1.c b/gcc/testsuite/c-c++-common/analyzer/memset-1.c
index 75aef53d3487..d6695d494111 100644
--- a/gcc/testsuite/c-c++-common/analyzer/memset-1.c
+++ b/gcc/testsuite/c-c++-common/analyzer/memset-1.c
@@ -58,7 +58,7 @@ void test_5 (int n)
__analyzer_eval (buf[42] == 'A'); /* { dg-warning "TRUE" } */
memset (buf, 0, n);
- /* We can't know if buf[42] was written to or not. */
+ /* We can't know if buf[42] was overwritten by the memset or not. */
__analyzer_eval (buf[42] == 'A'); /* { dg-warning "UNKNOWN" } */
__analyzer_eval (buf[42] == '\0'); /* { dg-warning "UNKNOWN" } */
}
@@ -72,7 +72,7 @@ void test_5a (int n)
__analyzer_eval (buf[42] == 'A'); /* { dg-warning "TRUE" } */
__builtin___memset_chk (buf, 0, n, __builtin_object_size (buf, 0));
- /* We can't know if buf[42] was written to or not. */
+ /* We can't know if buf[42] was overwritten by the memset or not. */
__analyzer_eval (buf[42] == 'A'); /* { dg-warning "UNKNOWN" } */
__analyzer_eval (buf[42] == '\0'); /* { dg-warning "UNKNOWN" } */
}
--
2.26.3
reply other threads:[~2024-04-10 20:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410205555.335678-1-dmalcolm@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).